meta-arm.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Jon Mason <jon.mason@arm.com>, meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH] arm-toolchain: use variables
Date: Mon, 27 Sep 2021 19:13:51 -0400	[thread overview]
Message-ID: <CAPoiz9ypbAtwjHDv_F6=1PT9_PbMYWDFbjV9EZMvT+Ogxwjm9A@mail.gmail.com> (raw)
In-Reply-To: <20210927181500.GT1528@denix.org>

On Mon, Sep 27, 2021 at 2:15 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> On Mon, Sep 27, 2021 at 09:18:20AM -0400, Jon Mason wrote:
> > Use variables to make it easier to upgrade when the time comes.
> >
> > Change-Id: I9f2575279fe79bc0d895d47fdaffd2d5edd4aa59
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > ---
> >  .../recipes-devtools/gcc/gcc-arm-10.3.inc              | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc b/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > index 72a6b46..187f4f4 100644
> > --- a/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > +++ b/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > @@ -1,8 +1,8 @@
> >  require recipes-devtools/gcc/gcc-common.inc
> >
> >  # Third digit in PV should be incremented after a minor release
> > -
> > -PV = "arm-10.3"
> > +GCC_VERSION = "10.3"
>
> Isn't it too close to be confused with the global GCCVERSION variable in
> meta/conf/distro/include/tcmode-default.inc that specifies gcc preference.
> I realize this GCC_VERSION has a different use, but maybe the name should
> be a bit clearer?

I was a little quick on the trigger and pushed it already, but I agree
with your point.  I'll do a follow-on patch to change it to a better
name.  Suggestions?

Thanks,
Jon

>
>
> > +PV = "arm-${GCC_VERSION}"
> >  CVE_VERSION = "10.3"
> >
> >  # BINV should be incremented to a revision after a minor gcc release
> > @@ -13,7 +13,7 @@ MMYY = "21.07"
> >  RELEASE = "20${MMYY}"
> >  PR = "r${RELEASE}"
> >
> > -FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-arm-10.3:${FILE_DIRNAME}/gcc-arm-10.3/backport:"
> > +FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-arm-${GCC_VERSION}:${FILE_DIRNAME}/gcc-arm-${GCC_VERSION}/backport:"
> >
> >  DEPENDS =+ "mpfr gmp libmpc zlib flex-native"
> >  NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native flex-native"
> > @@ -28,7 +28,7 @@ LIC_FILES_CHKSUM = "\
> >      file://COPYING.RUNTIME;md5=fe60d87048567d4fe8c8a0ed2448bcc8 \
> >  "
> >
> > -BASEURI ?= "https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-2021.07/srcrel/gcc-arm-src-snapshot-10.3-2021.07.tar.xz"
> > +BASEURI ?= "https://developer.arm.com/-/media/Files/downloads/gnu-a/${GCC_VERSION}-${RELEASE}/srcrel/gcc-arm-src-snapshot-${GCC_VERSION}-${RELEASE}.tar.xz"
> >  SRC_URI = "\
> >             ${BASEURI} \
> >             file://0001-gcc-4.3.1-ARCH_FLAGS_FOR_TARGET.patch \
> > @@ -72,7 +72,7 @@ SRC_URI = "\
> >  "
> >  SRC_URI[md5sum] = "5f582fd50eee0e40475b93d2d7a18979"
> >
> > -S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-arm-src-snapshot-10.3-2021.07"
> > +S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-arm-src-snapshot-${GCC_VERSION}-${RELEASE}"
> >
> >  # For dev release snapshotting
> >  #S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-${RELEASE}"
> > --
> > 2.17.1
> >
>
> --
> Regards,
> Denys Dmytriyenko <denis@denix.org>
> PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
> Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2237): https://lists.yoctoproject.org/g/meta-arm/message/2237
> Mute This Topic: https://lists.yoctoproject.org/mt/85900244/3616920
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>


  reply	other threads:[~2021-09-27 23:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:18 [PATCH] arm-toolchain: use variables Jon Mason
2021-09-27 18:15 ` [meta-arm] " Denys Dmytriyenko
2021-09-27 23:13   ` Jon Mason [this message]
2021-09-28  5:05     ` Sumit Garg
2021-10-05 23:57       ` Denys Dmytriyenko
2021-10-06  2:14         ` Jon Mason
2021-10-06  2:18           ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPoiz9ypbAtwjHDv_F6=1PT9_PbMYWDFbjV9EZMvT+Ogxwjm9A@mail.gmail.com' \
    --to=jdmason@kudzu.us \
    --cc=denis@denix.org \
    --cc=jon.mason@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).