From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] criu: fix QA issue about shebang too long
Date: Tue, 7 Jun 2022 10:01:35 -0400 [thread overview]
Message-ID: <20220607140133.GA54262@gmail.com> (raw)
In-Reply-To: <20220526035519.63646-1-Qi.Chen@windriver.com>
merged (to master and kirkstone)
Bruce
In message: [meta-virtualization][PATCH] criu: fix QA issue about shebang too long
on 25/05/2022 Chen Qi wrote:
> There's a QA issue about criu complaining the shebang
> of crit script is too long. We should replace it with
> '#!/usr/bin/env python3'.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> recipes-containers/criu/criu_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/criu/criu_git.bb b/recipes-containers/criu/criu_git.bb
> index 4b616ccf..77a12abf 100644
> --- a/recipes-containers/criu/criu_git.bb
> +++ b/recipes-containers/criu/criu_git.bb
> @@ -81,7 +81,7 @@ do_install () {
> # scripts. 'crit' is one of those scripts. The "executable" or "e" option to the
> # setup call should fix it, but it is being ignored. So to avoid getting our native
> # intepreter replaced in the script, we'll do an explicit update ourselves.
> - sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%g' ${D}/usr/bin/crit
> + sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%' ${D}/usr/bin/crit ${D}${libdir}/python3*/site-packages/crit-0.0.1-py3*.egg/EGG-INFO/scripts/crit
> }
>
> FILES:${PN} += "${systemd_unitdir}/ \
> --
> 2.36.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7325): https://lists.yoctoproject.org/g/meta-virtualization/message/7325
> Mute This Topic: https://lists.yoctoproject.org/mt/91348088/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2022-06-07 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 3:55 [meta-virtualization][PATCH] criu: fix QA issue about shebang too long Chen Qi
2022-06-07 14:01 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607140133.GA54262@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).