meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen: remove obsolete sdl PACKAGECONFIG
@ 2022-07-13 11:02 Ross Burton
  2022-07-13 19:29 ` [meta-virtualization] " Christopher Clark
  0 siblings, 1 reply; 3+ messages in thread
From: Ross Burton @ 2022-07-13 11:02 UTC (permalink / raw)
  To: meta-virtualization; +Cc: nd

Nothing in Xen respects --enable-sdl, and nothing in Xen links to libSDL,
so this PACKAGECONFIG is obsolete.

It looks like the last user of SDL in Xen was removed in "Remove
internal tools/ioemu tree"[1] back in 2008.

[1] xen 19dc3860dcfde9bc4ec4ef35bb1337e13276f630

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 recipes-extended/xen/xen.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index 2bbf1e3..5937763 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -7,12 +7,10 @@ inherit autotools-brokensep pkgconfig
 require xen-arch.inc
 
 PACKAGECONFIG ??= " \
-    sdl \
     ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
     "
 
 PACKAGECONFIG[lzo] = ",,lzo"
-PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl,"
 PACKAGECONFIG[xsm] = "--enable-xsmpolicy,--disable-xsmpolicy,checkpolicy-native,"
 PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd,"
 PACKAGECONFIG[externalblktap] = ",,,"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization] [PATCH] xen: remove obsolete sdl PACKAGECONFIG
  2022-07-13 11:02 [PATCH] xen: remove obsolete sdl PACKAGECONFIG Ross Burton
@ 2022-07-13 19:29 ` Christopher Clark
  2022-07-13 20:32   ` Bruce Ashfield
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Clark @ 2022-07-13 19:29 UTC (permalink / raw)
  To: Ross Burton
  Cc: meta-virtualization, nd, Bruce Ashfield, Doug Goldstein,
	Bertrand Marquis

On Wed, Jul 13, 2022 at 4:02 AM Ross Burton <ross.burton@arm.com> wrote:
>
> Nothing in Xen respects --enable-sdl, and nothing in Xen links to libSDL,
> so this PACKAGECONFIG is obsolete.
>
> It looks like the last user of SDL in Xen was removed in "Remove
> internal tools/ioemu tree"[1] back in 2008.
>
> [1] xen 19dc3860dcfde9bc4ec4ef35bb1337e13276f630
>

I was surprised by this but think it is correct.
There are also no SDL header file inclusions in the Xen tools source,
and the xen and xen-tools recipes build successfully with this patch
applied.

> Signed-off-by: Ross Burton <ross.burton@arm.com>

Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>

Christopher


> ---
>  recipes-extended/xen/xen.inc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index 2bbf1e3..5937763 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -7,12 +7,10 @@ inherit autotools-brokensep pkgconfig
>  require xen-arch.inc
>
>  PACKAGECONFIG ??= " \
> -    sdl \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
>      "
>
>  PACKAGECONFIG[lzo] = ",,lzo"
> -PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl,"
>  PACKAGECONFIG[xsm] = "--enable-xsmpolicy,--disable-xsmpolicy,checkpolicy-native,"
>  PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd,"
>  PACKAGECONFIG[externalblktap] = ",,,"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7453): https://lists.yoctoproject.org/g/meta-virtualization/message/7453
> Mute This Topic: https://lists.yoctoproject.org/mt/92354872/3619036
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [christopher.w.clark+meta-virt@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization] [PATCH] xen: remove obsolete sdl PACKAGECONFIG
  2022-07-13 19:29 ` [meta-virtualization] " Christopher Clark
@ 2022-07-13 20:32   ` Bruce Ashfield
  0 siblings, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2022-07-13 20:32 UTC (permalink / raw)
  To: Christopher Clark
  Cc: Ross Burton, meta-virtualization, nd, Doug Goldstein, Bertrand Marquis

On Wed, Jul 13, 2022 at 3:29 PM Christopher Clark
<christopher.w.clark@gmail.com> wrote:
>
> On Wed, Jul 13, 2022 at 4:02 AM Ross Burton <ross.burton@arm.com> wrote:
> >
> > Nothing in Xen respects --enable-sdl, and nothing in Xen links to libSDL,
> > so this PACKAGECONFIG is obsolete.
> >
> > It looks like the last user of SDL in Xen was removed in "Remove
> > internal tools/ioemu tree"[1] back in 2008.
> >
> > [1] xen 19dc3860dcfde9bc4ec4ef35bb1337e13276f630
> >
>
> I was surprised by this but think it is correct.
> There are also no SDL header file inclusions in the Xen tools source,
> and the xen and xen-tools recipes build successfully with this patch
> applied.
>
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
>
> Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>
>

Since this is showing up on the yocto autobuilder as well, I've bumped
it up the queue and done the merge.

Bruce

> Christopher
>
>
> > ---
> >  recipes-extended/xen/xen.inc | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> > index 2bbf1e3..5937763 100644
> > --- a/recipes-extended/xen/xen.inc
> > +++ b/recipes-extended/xen/xen.inc
> > @@ -7,12 +7,10 @@ inherit autotools-brokensep pkgconfig
> >  require xen-arch.inc
> >
> >  PACKAGECONFIG ??= " \
> > -    sdl \
> >      ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
> >      "
> >
> >  PACKAGECONFIG[lzo] = ",,lzo"
> > -PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl,"
> >  PACKAGECONFIG[xsm] = "--enable-xsmpolicy,--disable-xsmpolicy,checkpolicy-native,"
> >  PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd,"
> >  PACKAGECONFIG[externalblktap] = ",,,"
> > --
> > 2.34.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7453): https://lists.yoctoproject.org/g/meta-virtualization/message/7453
> > Mute This Topic: https://lists.yoctoproject.org/mt/92354872/3619036
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [christopher.w.clark+meta-virt@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-13 20:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 11:02 [PATCH] xen: remove obsolete sdl PACKAGECONFIG Ross Burton
2022-07-13 19:29 ` [meta-virtualization] " Christopher Clark
2022-07-13 20:32   ` Bruce Ashfield

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).