From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDBEC433EF for ; Tue, 21 Dec 2021 04:52:53 +0000 (UTC) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by mx.groups.io with SMTP id smtpd.web11.2317.1640062372506520521 for ; Mon, 20 Dec 2021 20:52:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YyBjvdi2; spf=pass (domain: gmail.com, ip: 209.85.221.172, mailfrom: christopher.w.clark@gmail.com) Received: by mail-vk1-f172.google.com with SMTP id m185so7453268vkm.5 for ; Mon, 20 Dec 2021 20:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=btzgZmUj7fOiqh6N1JGHMuOKEoMoHZbVmNS8tNnqGg0=; b=YyBjvdi2qbXA66rlfmHtjUG4ix6tqfrLX1kjGo7jmK4jUab1BH3SzYKsNeCBxNJ0pJ 4vlZ+ijT9qTZ1LYYktgI4PNMKEQZ6FcjrG/CxCjEp9AMgMMD+SIqfJnR0kX0944KKnne WvSRaegY6JlKbz1Gd4Z3RgH23p92IU5NRLnz32TfgI28a6tTtx0igPHJy1LNrZCl9eaT zXQK/2DM3Vlj3rXvgvU9CN2k7F2C/gnAduBVcBv1n30Tz0n1v/DkcAVrcGwyNFLW6Jt0 Hm8hU/GljijcAu41JeARyc17cnIfGMd/dIcCOgVS+mukm83L3vdtUceK/5TpLR+vvlI8 yp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=btzgZmUj7fOiqh6N1JGHMuOKEoMoHZbVmNS8tNnqGg0=; b=qq5d0CQuBI8gK3lFHBOZfVmEvUyCRd1eLrHDEtT+BkJ5i8+rpXzKcg/ASEZ1PvLpxw o7nY5V2kTvB4OQyAFGolWsrRMbwAfTNz59b0oUq1p3Nv5vhiDY7VzGuiRIKuSLBuVqZ9 xSRcLd2zTa6tcti9JsBSElrKXJAzyuu0v2iEN78S3/ovult/fBlUx9u2pTwinx8sNFTc dJQlAqPwuoZgf72VLiZwrVROKYOIIqAH/24vidSxr2rrHfA09YOxTa4ubi+eri5DGw8V 4RdZ7xqeqXFQBBVOpnCdSRru8Zn0U83MoeZSw2KKBChA+SimDhRZoiczsh9UXqiDrLyn gMPA== X-Gm-Message-State: AOAM531aTfrmnRXeUjvUK5j4s5Ck1i/bTQs0ac9rrz4cLqWrJ2XVXCkF MttYKs3ecnYI7DgV3jK69KqFZ94EPy1A9AtzsTo= X-Google-Smtp-Source: ABdhPJxUqJOjUij+f2R3dT6E0HzHsjU2yTfhdMMV9zDQ0n5FvKGyBpGksZQ54x3lra9RuUQjB5okOdk2wySO/nssk+0= X-Received: by 2002:a05:6122:1687:: with SMTP id 7mr635929vkl.5.1640062371682; Mon, 20 Dec 2021 20:52:51 -0800 (PST) MIME-Version: 1.0 References: <20211209135752.6872-1-kamil.dziezyk@arm.com> <20211209135752.6872-3-kamil.dziezyk@arm.com> In-Reply-To: <20211209135752.6872-3-kamil.dziezyk@arm.com> From: Christopher Clark Date: Mon, 20 Dec 2021 20:52:40 -0800 Message-ID: Subject: Re: [meta-virtualization][PATCH v2 3/3] grub-efi: Add xen_boot support when 'xen' is in DISTRO_FEATURES for aarch64 To: Kamil Dziezyk Cc: meta-virtualization@lists.yoctoproject.org, nd , Bruce Ashfield , Doug Goldstein Content-Type: multipart/alternative; boundary="00000000000012dd1d05d3a0c792" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Dec 2021 04:52:53 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-virtualization/message/6985 --00000000000012dd1d05d3a0c792 Content-Type: text/plain; charset="UTF-8" On Thu, Dec 9, 2021 at 5:59 AM Kamil Dziezyk wrote: > Signed-off-by: Kamil Dziezyk > I think this might be better changed in the grub-efi recipe in OE core instead, where the GRUB recipe maintainer can review it? Should this xen_boot build-in feature be enabled for more architectures than just aarch64? Christopher > --- > recipes-bsp/grub/grub-efi_%.bbappend | 1 + > recipes-bsp/grub/grub-efi_xen.inc | 1 + > 2 files changed, 2 insertions(+) > create mode 100644 recipes-bsp/grub/grub-efi_%.bbappend > create mode 100644 recipes-bsp/grub/grub-efi_xen.inc > > diff --git a/recipes-bsp/grub/grub-efi_%.bbappend > b/recipes-bsp/grub/grub-efi_%.bbappend > new file mode 100644 > index 0000000..df2b688 > --- /dev/null > +++ b/recipes-bsp/grub/grub-efi_%.bbappend > @@ -0,0 +1 @@ > +require ${@bb.utils.contains('DISTRO_FEATURES', 'xen', '${BPN}_xen.inc', > '', d)} > diff --git a/recipes-bsp/grub/grub-efi_xen.inc > b/recipes-bsp/grub/grub-efi_xen.inc > new file mode 100644 > index 0000000..5aa0958 > --- /dev/null > +++ b/recipes-bsp/grub/grub-efi_xen.inc > @@ -0,0 +1 @@ > +GRUB_BUILDIN:append:aarch64 = "${@bb.utils.contains('DISTRO_FEATURES', > 'xen', ' xen_boot', '', d)}" > -- > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#6974): > https://lists.yoctoproject.org/g/meta-virtualization/message/6974 > Mute This Topic: https://lists.yoctoproject.org/mt/87611988/3619037 > Group Owner: meta-virtualization+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [ > christopher.w.clark@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > --00000000000012dd1d05d3a0c792 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Dec 9, 2021 at 5:59 AM Kamil Dzie= zyk <kamil.dziezyk@arm.com&= gt; wrote:
Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>

I think this might be better changed in the g= rub-efi recipe in OE core instead, where the GRUB recipe maintainer can rev= iew it?

Should this xen_boot build-in feature be e= nabled for more architectures than just aarch64?

C= hristopher
=C2=A0
---
=C2=A0recipes-bsp/grub/grub-efi_%.bbappend | 1 +
=C2=A0recipes-bsp/grub/grub-efi_xen.inc=C2=A0 =C2=A0 | 1 +
=C2=A02 files changed, 2 insertions(+)
=C2=A0create mode 100644 recipes-bsp/grub/grub-efi_%.bbappend
=C2=A0create mode 100644 recipes-bsp/grub/grub-efi_xen.inc

diff --git a/recipes-bsp/grub/grub-efi_%.bbappend b/recipes-bsp/grub/grub-e= fi_%.bbappend
new file mode 100644
index 0000000..df2b688
--- /dev/null
+++ b/recipes-bsp/grub/grub-efi_%.bbappend
@@ -0,0 +1 @@
+require ${@bb.utils.contains('DISTRO_FEATURES', 'xen', = 9;${BPN}_xen.inc', '', d)}
diff --git a/recipes-bsp/grub/grub-efi_xen.inc b/recipes-bsp/grub/grub-efi_= xen.inc
new file mode 100644
index 0000000..5aa0958
--- /dev/null
+++ b/recipes-bsp/grub/grub-efi_xen.inc
@@ -0,0 +1 @@
+GRUB_BUILDIN:append:aarch64 =3D "${@bb.utils.contains('DISTRO_FEA= TURES', 'xen', ' xen_boot', '', d)}"
--
2.17.1


-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-
Links: You receive all messages sent to this group.
View/Reply Online (#6974): https://= lists.yoctoproject.org/g/meta-virtualization/message/6974
Mute This Topic: https://lists.yoctoproject.org/mt= /87611988/3619037
Group Owner: meta-virtualization+owner@lists.yoctoproject.org<= /a>
Unsubscribe: https://lists.yoctoproject.or= g/g/meta-virtualization/unsub [christopher.w.clark@gmail.com]
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-

--00000000000012dd1d05d3a0c792--