From: Christopher Clark <christopher.w.clark@gmail.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: meta-virtualization@lists.yoctoproject.org, nd <nd@arm.com>
Subject: Re: [meta-virtualization] [PATCH v2 1/4] xen: Fix class inherit in xen-image
Date: Tue, 17 May 2022 17:06:32 -0700 [thread overview]
Message-ID: <CACMJ4GZikQQLNbdSv2Mw8HaMtO-4TPuR_ZL+GsL+2=WMOsHrzQ@mail.gmail.com> (raw)
In-Reply-To: <cba614bcf3d974cb7e8c711f66e25d3c0b229776.1652196703.git.bertrand.marquis@arm.com>
On Tue, May 10, 2022 at 8:35 AM Bertrand Marquis
<bertrand.marquis@arm.com> wrote:
>
> Remove inherit of qemuboot classes when not build for qemu in
> xen-image-minimal.
> When reverted the handling for only adding inherited classes for qemu
> was kept but the line always inheriting them was kept to.
> This patch is fixing that so that qemuboot classes are now only added
> when the image is built for qemu.
>
> This fixes commit 27e5ade0abc2660226389b8b62ef07d85f4b8758
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>
thanks,
Christopher
> ---
> recipes-extended/images/xen-image-minimal.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
> index 7f10b1d..9fd05d2 100644
> --- a/recipes-extended/images/xen-image-minimal.bb
> +++ b/recipes-extended/images/xen-image-minimal.bb
> @@ -36,7 +36,7 @@ LICENSE = "MIT"
>
> QB_NETWORK_XEN_BRIDGE = "1"
>
> -inherit core-image qemuboot-xen-defaults qemuboot-xen-dtb qemuboot-testimage-network
> +inherit core-image
> # Only inherit the qemuboot classes when building for a qemu machine
> QB_QEMU_CLASSES = ""
> QB_QEMU_CLASSES:qemuall = "qemuboot-xen-defaults qemuboot-xen-dtb qemuboot-testimage-network"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7271): https://lists.yoctoproject.org/g/meta-virtualization/message/7271
> Mute This Topic: https://lists.yoctoproject.org/mt/91015798/3619036
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [christopher.w.clark+meta-virt@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2022-05-18 0:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 15:35 [PATCH v2 0/4] Vairous fixes for qemu support Bertrand Marquis
2022-05-10 15:35 ` [PATCH v2 1/4] xen: Fix class inherit in xen-image Bertrand Marquis
2022-05-18 0:06 ` Christopher Clark [this message]
2022-05-10 15:35 ` [PATCH v2 2/4] qemuboot: Fix command line and enable other machines Bertrand Marquis
2022-05-10 15:35 ` [PATCH v2 3/4] xen: enable qemuboot for arm32 Bertrand Marquis
2022-05-18 0:11 ` [meta-virtualization] " Christopher Clark
2022-05-10 15:35 ` [PATCH v2 4/4] xen: Disable PCI on qemuarm with Xen Bertrand Marquis
2022-05-18 0:14 ` [meta-virtualization] " Christopher Clark
2022-05-18 7:36 ` Bertrand Marquis
2022-05-18 17:59 ` Bruce Ashfield
2022-05-19 7:21 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACMJ4GZikQQLNbdSv2Mw8HaMtO-4TPuR_ZL+GsL+2=WMOsHrzQ@mail.gmail.com' \
--to=christopher.w.clark@gmail.com \
--cc=bertrand.marquis@arm.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).