meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] xen: PCI runqemu issue follow-up
@ 2022-06-09  9:57 Michal Orzel
  2022-06-09  9:57 ` [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen" Michal Orzel
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Michal Orzel @ 2022-06-09  9:57 UTC (permalink / raw)
  To: christopher.w.clark, bruce.ashfield; +Cc: meta-virtualization, nd

This series acts as a follow-up to the commit:
fb0a7b97db4f ("xen: Disable PCI on qemuarm with Xen")

This wants to be backported to kirkstone.

Michal Orzel (2):
  Revert "xen: Disable PCI on qemuarm with Xen"
  xen: Disable highmem on qemuarm

 classes/qemuboot-xen-defaults.bbclass |  6 ++++--
 classes/qemuboot-xen-dtb.bbclass      | 22 ----------------------
 2 files changed, 4 insertions(+), 24 deletions(-)

-- 
2.25.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen"
  2022-06-09  9:57 [PATCH 0/2] xen: PCI runqemu issue follow-up Michal Orzel
@ 2022-06-09  9:57 ` Michal Orzel
  2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
  2022-06-09  9:57 ` [PATCH 2/2] xen: Disable highmem on qemuarm Michal Orzel
  2022-06-14 19:47 ` [PATCH 0/2] xen: PCI runqemu issue follow-up Bruce Ashfield
  2 siblings, 1 reply; 10+ messages in thread
From: Michal Orzel @ 2022-06-09  9:57 UTC (permalink / raw)
  To: christopher.w.clark, bruce.ashfield; +Cc: meta-virtualization, nd

This reverts commit fb0a7b97db4f419b82309f98a4944ae3330d1e2e.

Justification:
Commit fb0a7b97db4f removed the PCI node from the qemu device tree
due to the issue when trying to access PCI configuration space that
was causing Linux running on top of Xen to end up in an infinite loop.
The investigation showed that the problem occurs due to qemu placing
ECAM space at 256GiB mark. Even though Xen officially supports on arm32
up to 12GiB of physical address space, it is able to map it correctly
for dom0. However, when Linux tries to access the ECAM space and the
stage2 translation fault occurs, HPFAR register contains incorrect IPA.
We can say it is incorrect because using hardware AT instruction or
software lookup, we can obtain the correct IPA from the same VA. This
can suggest that the problem is related to QEMU fault handling.

Instead of removing the PCI node the follow-up commit will disable
highmem option in qemu which will cause placing ECAM space in the
32-bit space.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 classes/qemuboot-xen-dtb.bbclass | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
index 1f17a86..d43d23a 100644
--- a/classes/qemuboot-xen-dtb.bbclass
+++ b/classes/qemuboot-xen-dtb.bbclass
@@ -63,21 +63,6 @@ write_lops_xen_section() {
 EOF
 }
 
-write_lop_rm_pci() {
-    cat <<EOF >"$1"
-/dts-v1/;
-/ {
-    compatible = "system-device-tree-v1";
-    lops {
-        lop_1 {
-            compatible = "system-device-tree-v1,lop,modify";
-            modify = "/pcie@10000000::";
-        };
-     };
-};
-EOF
-}
-
 write_lop_add_to_xen_cmdline() {
     EXTRA_XEN_BOOTARGS="$2"
     cat <<EOF >"$1"
@@ -150,13 +135,6 @@ generate_xen_qemuboot_dtb() {
     write_lop_add_to_xen_cmdline "${B}/lop-xen-cmdline.dts" \
         "${QB_XEN_CMDLINE_EXTRA}"
 
-    # On Qemu Arm32, Dom0 accessing PCI config space ends up in an
-    # infinite loop. Remove pci node from the device tree
-    if [ "${MACHINE}" = "qemuarm" ]; then
-        write_lop_rm_pci "${B}/lop-rm-pci.dts"
-        LOP_MODULE_ARGS="${LOP_MODULE_ARGS} -i ${B}/lop-rm-pci.dts"
-    fi
-
     if [ -z "${QB_XEN_DOMAIN_MODULES}" ]; then
         bbwarn "No domain modules: please set QB_XEN_DOMAIN_MODULES"
     fi
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] xen: Disable highmem on qemuarm
  2022-06-09  9:57 [PATCH 0/2] xen: PCI runqemu issue follow-up Michal Orzel
  2022-06-09  9:57 ` [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen" Michal Orzel
@ 2022-06-09  9:57 ` Michal Orzel
  2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
  2022-06-14 19:47 ` [PATCH 0/2] xen: PCI runqemu issue follow-up Bruce Ashfield
  2 siblings, 1 reply; 10+ messages in thread
From: Michal Orzel @ 2022-06-09  9:57 UTC (permalink / raw)
  To: christopher.w.clark, bruce.ashfield; +Cc: meta-virtualization, nd

By default, highmem option is enabled for machine types later than
virt-2.12. This allows qemu to place devices and RAM in physical
address space above 32-bits. This can cause issues as according to the
documentation Xen supports up to 12GiB of physical address space.
Recently the issue was observed using runqemu, that was causing Linux
running on top of Xen to stall when trying to access ECAM space placed
by qemu at 256GiB mark. Even though this issue is most probably related
to QEMU and not Xen (the investigation showed that it can map ECAM
space correctly), it is best to avoid such issues by disabling highmem
on qemuarm.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 classes/qemuboot-xen-defaults.bbclass | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/classes/qemuboot-xen-defaults.bbclass b/classes/qemuboot-xen-defaults.bbclass
index f1550cc..460cbe6 100644
--- a/classes/qemuboot-xen-defaults.bbclass
+++ b/classes/qemuboot-xen-defaults.bbclass
@@ -23,8 +23,10 @@ QB_DEFAULT_KERNEL:qemuarm = "xen-${MACHINE}"
 
 # 64-bit Arm: gic version 3
 QB_MACHINE:qemuarm64 = "-machine virt,gic-version=3 -machine virtualization=true"
-# 32-bit Arm
-QB_MACHINE:qemuarm = "-machine virt -machine virtualization=true"
+# 32-bit Arm: highmem=off
+# Disable highmem so that qemu does not use highmem IO regions that end up
+# being placed at the 256GiB mark (e.g. ECAM space) and can cause issues in Xen.
+QB_MACHINE:qemuarm = "-machine virt,highmem=off -machine virtualization=true"
 
 # Increase the default qemu memory allocation to allow for the hypervisor.
 # Use a weak assignment to allow for change of default and override elsewhere.
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen"
  2022-06-09  9:57 ` [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen" Michal Orzel
@ 2022-06-09 10:01   ` Bertrand Marquis
  2022-06-17 14:32     ` Christopher Clark
  0 siblings, 1 reply; 10+ messages in thread
From: Bertrand Marquis @ 2022-06-09 10:01 UTC (permalink / raw)
  To: Michal Orzel; +Cc: christopher.w.clark, bruce.ashfield, meta-virtualization, nd

Hi Michal,

> On 9 Jun 2022, at 10:57, Michal Orzel via lists.yoctoproject.org <michal.orzel=arm.com@lists.yoctoproject.org> wrote:
> 
> This reverts commit fb0a7b97db4f419b82309f98a4944ae3330d1e2e.
> 
> Justification:
> Commit fb0a7b97db4f removed the PCI node from the qemu device tree
> due to the issue when trying to access PCI configuration space that
> was causing Linux running on top of Xen to end up in an infinite loop.
> The investigation showed that the problem occurs due to qemu placing
> ECAM space at 256GiB mark. Even though Xen officially supports on arm32
> up to 12GiB of physical address space, it is able to map it correctly
> for dom0. However, when Linux tries to access the ECAM space and the
> stage2 translation fault occurs, HPFAR register contains incorrect IPA.
> We can say it is incorrect because using hardware AT instruction or
> software lookup, we can obtain the correct IPA from the same VA. This
> can suggest that the problem is related to QEMU fault handling.
> 
> Instead of removing the PCI node the follow-up commit will disable
> highmem option in qemu which will cause placing ECAM space in the
> 32-bit space.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Also tested on kirkstone and dom0 boots fine and pci is working.

Thanks a lot
Cheers
Bertrand

> ---
> classes/qemuboot-xen-dtb.bbclass | 22 ----------------------
> 1 file changed, 22 deletions(-)
> 
> diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> index 1f17a86..d43d23a 100644
> --- a/classes/qemuboot-xen-dtb.bbclass
> +++ b/classes/qemuboot-xen-dtb.bbclass
> @@ -63,21 +63,6 @@ write_lops_xen_section() {
> EOF
> }
> 
> -write_lop_rm_pci() {
> -    cat <<EOF >"$1"
> -/dts-v1/;
> -/ {
> -    compatible = "system-device-tree-v1";
> -    lops {
> -        lop_1 {
> -            compatible = "system-device-tree-v1,lop,modify";
> -            modify = "/pcie@10000000::";
> -        };
> -     };
> -};
> -EOF
> -}
> -
> write_lop_add_to_xen_cmdline() {
>     EXTRA_XEN_BOOTARGS="$2"
>     cat <<EOF >"$1"
> @@ -150,13 +135,6 @@ generate_xen_qemuboot_dtb() {
>     write_lop_add_to_xen_cmdline "${B}/lop-xen-cmdline.dts" \
>         "${QB_XEN_CMDLINE_EXTRA}"
> 
> -    # On Qemu Arm32, Dom0 accessing PCI config space ends up in an
> -    # infinite loop. Remove pci node from the device tree
> -    if [ "${MACHINE}" = "qemuarm" ]; then
> -        write_lop_rm_pci "${B}/lop-rm-pci.dts"
> -        LOP_MODULE_ARGS="${LOP_MODULE_ARGS} -i ${B}/lop-rm-pci.dts"
> -    fi
> -
>     if [ -z "${QB_XEN_DOMAIN_MODULES}" ]; then
>         bbwarn "No domain modules: please set QB_XEN_DOMAIN_MODULES"
>     fi
> -- 
> 2.25.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7351): https://lists.yoctoproject.org/g/meta-virtualization/message/7351
> Mute This Topic: https://lists.yoctoproject.org/mt/91642063/3619089
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 2/2] xen: Disable highmem on qemuarm
  2022-06-09  9:57 ` [PATCH 2/2] xen: Disable highmem on qemuarm Michal Orzel
@ 2022-06-09 10:01   ` Bertrand Marquis
  2022-06-17 14:33     ` Christopher Clark
  0 siblings, 1 reply; 10+ messages in thread
From: Bertrand Marquis @ 2022-06-09 10:01 UTC (permalink / raw)
  To: Michal Orzel; +Cc: christopher.w.clark, bruce.ashfield, meta-virtualization, nd

Hi Michal,

> On 9 Jun 2022, at 10:57, Michal Orzel via lists.yoctoproject.org <michal.orzel=arm.com@lists.yoctoproject.org> wrote:
> 
> By default, highmem option is enabled for machine types later than
> virt-2.12. This allows qemu to place devices and RAM in physical
> address space above 32-bits. This can cause issues as according to the
> documentation Xen supports up to 12GiB of physical address space.
> Recently the issue was observed using runqemu, that was causing Linux
> running on top of Xen to stall when trying to access ECAM space placed
> by qemu at 256GiB mark. Even though this issue is most probably related
> to QEMU and not Xen (the investigation showed that it can map ECAM
> space correctly), it is best to avoid such issues by disabling highmem
> on qemuarm.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Also tested on kirkstone and dom0 boots fine and pci is working.

Thanks a lot
Cheers
Bertrand

> ---
> classes/qemuboot-xen-defaults.bbclass | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/qemuboot-xen-defaults.bbclass b/classes/qemuboot-xen-defaults.bbclass
> index f1550cc..460cbe6 100644
> --- a/classes/qemuboot-xen-defaults.bbclass
> +++ b/classes/qemuboot-xen-defaults.bbclass
> @@ -23,8 +23,10 @@ QB_DEFAULT_KERNEL:qemuarm = "xen-${MACHINE}"
> 
> # 64-bit Arm: gic version 3
> QB_MACHINE:qemuarm64 = "-machine virt,gic-version=3 -machine virtualization=true"
> -# 32-bit Arm
> -QB_MACHINE:qemuarm = "-machine virt -machine virtualization=true"
> +# 32-bit Arm: highmem=off
> +# Disable highmem so that qemu does not use highmem IO regions that end up
> +# being placed at the 256GiB mark (e.g. ECAM space) and can cause issues in Xen.
> +QB_MACHINE:qemuarm = "-machine virt,highmem=off -machine virtualization=true"
> 
> # Increase the default qemu memory allocation to allow for the hypervisor.
> # Use a weak assignment to allow for change of default and override elsewhere.
> -- 
> 2.25.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7352): https://lists.yoctoproject.org/g/meta-virtualization/message/7352
> Mute This Topic: https://lists.yoctoproject.org/mt/91642064/3619089
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/2] xen: PCI runqemu issue follow-up
  2022-06-09  9:57 [PATCH 0/2] xen: PCI runqemu issue follow-up Michal Orzel
  2022-06-09  9:57 ` [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen" Michal Orzel
  2022-06-09  9:57 ` [PATCH 2/2] xen: Disable highmem on qemuarm Michal Orzel
@ 2022-06-14 19:47 ` Bruce Ashfield
  2022-06-17 15:41   ` Christopher Clark
  2 siblings, 1 reply; 10+ messages in thread
From: Bruce Ashfield @ 2022-06-14 19:47 UTC (permalink / raw)
  To: Michal Orzel; +Cc: Christopher Clark, meta-virtualization, nd

I was waiting to hear from Christopher on this one, so I'll let it
soak a few more days before staging.

Bruce

On Thu, Jun 9, 2022 at 5:58 AM Michal Orzel <michal.orzel@arm.com> wrote:
>
> This series acts as a follow-up to the commit:
> fb0a7b97db4f ("xen: Disable PCI on qemuarm with Xen")
>
> This wants to be backported to kirkstone.
>
> Michal Orzel (2):
>   Revert "xen: Disable PCI on qemuarm with Xen"
>   xen: Disable highmem on qemuarm
>
>  classes/qemuboot-xen-defaults.bbclass |  6 ++++--
>  classes/qemuboot-xen-dtb.bbclass      | 22 ----------------------
>  2 files changed, 4 insertions(+), 24 deletions(-)
>
> --
> 2.25.1
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen"
  2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
@ 2022-06-17 14:32     ` Christopher Clark
  0 siblings, 0 replies; 10+ messages in thread
From: Christopher Clark @ 2022-06-17 14:32 UTC (permalink / raw)
  To: Bertrand Marquis; +Cc: Michal Orzel, bruce.ashfield, meta-virtualization, nd

On Thu, Jun 9, 2022 at 3:01 AM Bertrand Marquis
<Bertrand.Marquis@arm.com> wrote:
>
> Hi Michal,
>
> > On 9 Jun 2022, at 10:57, Michal Orzel via lists.yoctoproject.org <michal.orzel=arm.com@lists.yoctoproject.org> wrote:
> >
> > This reverts commit fb0a7b97db4f419b82309f98a4944ae3330d1e2e.
> >
> > Justification:
> > Commit fb0a7b97db4f removed the PCI node from the qemu device tree
> > due to the issue when trying to access PCI configuration space that
> > was causing Linux running on top of Xen to end up in an infinite loop.
> > The investigation showed that the problem occurs due to qemu placing
> > ECAM space at 256GiB mark. Even though Xen officially supports on arm32
> > up to 12GiB of physical address space, it is able to map it correctly
> > for dom0. However, when Linux tries to access the ECAM space and the
> > stage2 translation fault occurs, HPFAR register contains incorrect IPA.
> > We can say it is incorrect because using hardware AT instruction or
> > software lookup, we can obtain the correct IPA from the same VA. This
> > can suggest that the problem is related to QEMU fault handling.
> >
> > Instead of removing the PCI node the follow-up commit will disable
> > highmem option in qemu which will cause placing ECAM space in the
> > 32-bit space.
> >
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>

>
> Also tested on kirkstone and dom0 boots fine and pci is working.

Thanks for this

Christopher

>
> Thanks a lot
> Cheers
> Bertrand
>
> > ---
> > classes/qemuboot-xen-dtb.bbclass | 22 ----------------------
> > 1 file changed, 22 deletions(-)
> >
> > diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> > index 1f17a86..d43d23a 100644
> > --- a/classes/qemuboot-xen-dtb.bbclass
> > +++ b/classes/qemuboot-xen-dtb.bbclass
> > @@ -63,21 +63,6 @@ write_lops_xen_section() {
> > EOF
> > }
> >
> > -write_lop_rm_pci() {
> > -    cat <<EOF >"$1"
> > -/dts-v1/;
> > -/ {
> > -    compatible = "system-device-tree-v1";
> > -    lops {
> > -        lop_1 {
> > -            compatible = "system-device-tree-v1,lop,modify";
> > -            modify = "/pcie@10000000::";
> > -        };
> > -     };
> > -};
> > -EOF
> > -}
> > -
> > write_lop_add_to_xen_cmdline() {
> >     EXTRA_XEN_BOOTARGS="$2"
> >     cat <<EOF >"$1"
> > @@ -150,13 +135,6 @@ generate_xen_qemuboot_dtb() {
> >     write_lop_add_to_xen_cmdline "${B}/lop-xen-cmdline.dts" \
> >         "${QB_XEN_CMDLINE_EXTRA}"
> >
> > -    # On Qemu Arm32, Dom0 accessing PCI config space ends up in an
> > -    # infinite loop. Remove pci node from the device tree
> > -    if [ "${MACHINE}" = "qemuarm" ]; then
> > -        write_lop_rm_pci "${B}/lop-rm-pci.dts"
> > -        LOP_MODULE_ARGS="${LOP_MODULE_ARGS} -i ${B}/lop-rm-pci.dts"
> > -    fi
> > -
> >     if [ -z "${QB_XEN_DOMAIN_MODULES}" ]; then
> >         bbwarn "No domain modules: please set QB_XEN_DOMAIN_MODULES"
> >     fi
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7351): https://lists.yoctoproject.org/g/meta-virtualization/message/7351
> > Mute This Topic: https://lists.yoctoproject.org/mt/91642063/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 2/2] xen: Disable highmem on qemuarm
  2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
@ 2022-06-17 14:33     ` Christopher Clark
  0 siblings, 0 replies; 10+ messages in thread
From: Christopher Clark @ 2022-06-17 14:33 UTC (permalink / raw)
  To: Bertrand Marquis; +Cc: Michal Orzel, bruce.ashfield, meta-virtualization, nd

On Thu, Jun 9, 2022 at 3:01 AM Bertrand Marquis
<Bertrand.Marquis@arm.com> wrote:
>
> Hi Michal,
>
> > On 9 Jun 2022, at 10:57, Michal Orzel via lists.yoctoproject.org <michal.orzel=arm.com@lists.yoctoproject.org> wrote:
> >
> > By default, highmem option is enabled for machine types later than
> > virt-2.12. This allows qemu to place devices and RAM in physical
> > address space above 32-bits. This can cause issues as according to the
> > documentation Xen supports up to 12GiB of physical address space.
> > Recently the issue was observed using runqemu, that was causing Linux
> > running on top of Xen to stall when trying to access ECAM space placed
> > by qemu at 256GiB mark. Even though this issue is most probably related
> > to QEMU and not Xen (the investigation showed that it can map ECAM
> > space correctly), it is best to avoid such issues by disabling highmem
> > on qemuarm.
> >
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>

>
> Also tested on kirkstone and dom0 boots fine and pci is working.

Thanks,

Christopher

>
> Thanks a lot
> Cheers
> Bertrand
>
> > ---
> > classes/qemuboot-xen-defaults.bbclass | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/classes/qemuboot-xen-defaults.bbclass b/classes/qemuboot-xen-defaults.bbclass
> > index f1550cc..460cbe6 100644
> > --- a/classes/qemuboot-xen-defaults.bbclass
> > +++ b/classes/qemuboot-xen-defaults.bbclass
> > @@ -23,8 +23,10 @@ QB_DEFAULT_KERNEL:qemuarm = "xen-${MACHINE}"
> >
> > # 64-bit Arm: gic version 3
> > QB_MACHINE:qemuarm64 = "-machine virt,gic-version=3 -machine virtualization=true"
> > -# 32-bit Arm
> > -QB_MACHINE:qemuarm = "-machine virt -machine virtualization=true"
> > +# 32-bit Arm: highmem=off
> > +# Disable highmem so that qemu does not use highmem IO regions that end up
> > +# being placed at the 256GiB mark (e.g. ECAM space) and can cause issues in Xen.
> > +QB_MACHINE:qemuarm = "-machine virt,highmem=off -machine virtualization=true"
> >
> > # Increase the default qemu memory allocation to allow for the hypervisor.
> > # Use a weak assignment to allow for change of default and override elsewhere.
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7352): https://lists.yoctoproject.org/g/meta-virtualization/message/7352
> > Mute This Topic: https://lists.yoctoproject.org/mt/91642064/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/2] xen: PCI runqemu issue follow-up
  2022-06-14 19:47 ` [PATCH 0/2] xen: PCI runqemu issue follow-up Bruce Ashfield
@ 2022-06-17 15:41   ` Christopher Clark
  2022-06-20  7:33     ` [meta-virtualization] " Bertrand Marquis
  0 siblings, 1 reply; 10+ messages in thread
From: Christopher Clark @ 2022-06-17 15:41 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: Michal Orzel, meta-virtualization, nd

On Tue, Jun 14, 2022 at 12:47 PM Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
>
> I was waiting to hear from Christopher on this one, so I'll let it
> soak a few more days before staging.
>
> Bruce
>
> On Thu, Jun 9, 2022 at 5:58 AM Michal Orzel <michal.orzel@arm.com> wrote:
> >
> > This series acts as a follow-up to the commit:
> > fb0a7b97db4f ("xen: Disable PCI on qemuarm with Xen")
> >
> > This wants to be backported to kirkstone.

Thanks for these patches and for working out what was needed for the
fix, Michal.

Apologies for the slow review - am catching up now after a few days
down with an injury (should be ok).

Christopher


> >
> > Michal Orzel (2):
> >   Revert "xen: Disable PCI on qemuarm with Xen"
> >   xen: Disable highmem on qemuarm
> >
> >  classes/qemuboot-xen-defaults.bbclass |  6 ++++--
> >  classes/qemuboot-xen-dtb.bbclass      | 22 ----------------------
> >  2 files changed, 4 insertions(+), 24 deletions(-)
> >
> > --
> > 2.25.1
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 0/2] xen: PCI runqemu issue follow-up
  2022-06-17 15:41   ` Christopher Clark
@ 2022-06-20  7:33     ` Bertrand Marquis
  0 siblings, 0 replies; 10+ messages in thread
From: Bertrand Marquis @ 2022-06-20  7:33 UTC (permalink / raw)
  To: Christopher Clark; +Cc: Bruce Ashfield, Michal Orzel, meta-virtualization, nd

Hi,

> On 17 Jun 2022, at 16:41, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> 
> On Tue, Jun 14, 2022 at 12:47 PM Bruce Ashfield
> <bruce.ashfield@gmail.com> wrote:
>> 
>> I was waiting to hear from Christopher on this one, so I'll let it
>> soak a few more days before staging.
>> 
>> Bruce
>> 
>> On Thu, Jun 9, 2022 at 5:58 AM Michal Orzel <michal.orzel@arm.com> wrote:
>>> 
>>> This series acts as a follow-up to the commit:
>>> fb0a7b97db4f ("xen: Disable PCI on qemuarm with Xen")
>>> 
>>> This wants to be backported to kirkstone.
> 
> Thanks for these patches and for working out what was needed for the
> fix, Michal.
> 
> Apologies for the slow review - am catching up now after a few days
> down with an injury (should be ok).

I would also suggest to push this to kirkstone branch.

Cheers
Bertrand

> 
> Christopher
> 
> 
>>> 
>>> Michal Orzel (2):
>>> Revert "xen: Disable PCI on qemuarm with Xen"
>>> xen: Disable highmem on qemuarm
>>> 
>>> classes/qemuboot-xen-defaults.bbclass | 6 ++++--
>>> classes/qemuboot-xen-dtb.bbclass | 22 ----------------------
>>> 2 files changed, 4 insertions(+), 24 deletions(-)
>>> 
>>> --
>>> 2.25.1
>>> 
>> 
>> 
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7389): https://lists.yoctoproject.org/g/meta-virtualization/message/7389
> Mute This Topic: https://lists.yoctoproject.org/mt/91642062/3619089
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-06-20  7:34 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09  9:57 [PATCH 0/2] xen: PCI runqemu issue follow-up Michal Orzel
2022-06-09  9:57 ` [PATCH 1/2] Revert "xen: Disable PCI on qemuarm with Xen" Michal Orzel
2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
2022-06-17 14:32     ` Christopher Clark
2022-06-09  9:57 ` [PATCH 2/2] xen: Disable highmem on qemuarm Michal Orzel
2022-06-09 10:01   ` [meta-virtualization] " Bertrand Marquis
2022-06-17 14:33     ` Christopher Clark
2022-06-14 19:47 ` [PATCH 0/2] xen: PCI runqemu issue follow-up Bruce Ashfield
2022-06-17 15:41   ` Christopher Clark
2022-06-20  7:33     ` [meta-virtualization] " Bertrand Marquis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).