[PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Kamil Dziezyk]

This patch changes the location of xen.conf file, that contains list of kernel
modules to be loaded during system boot, to "${nonarch_libdir}". This is done
by removing '--with-systemd-modules-load=' flag from EXTRA_OECONF variable.

Previous path based on "${systemd_unitdir}" was not considered by default by
systemd-modules-load.service.

Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
---
 recipes-extended/xen/xen-tools.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/recipes-extended/xen/xen-tools.inc b/recipes-extended/xen/xen-tools.inc
index ca924f4..6e25046 100644
--- a/recipes-extended/xen/xen-tools.inc
+++ b/recipes-extended/xen/xen-tools.inc
@@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
     "

 FILES:${PN}-xencommons += "\
+    ${nonarch_libdir}/modules-load.d/xen.conf \
     ${sysconfdir}/default/xencommons \
     ${sysconfdir}/init.d/xencommons \
     ${sysconfdir}/xen/scripts/launch-xenstore \
-    ${systemd_unitdir}/modules-load.d/xen.conf \
     ${systemd_unitdir}/system/proc-xen.mount \
     ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
     ${systemd_unitdir}/system/xenconsoled.service \
@@ -744,7 +744,6 @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"

 EXTRA_OECONF += " \
     --with-systemd=${systemd_unitdir}/system \
-    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
     --with-initddir=${INIT_D_DIR} \
     --with-sysconfig-leaf-dir=default \
     --with-system-qemu=${bindir}/qemu-system-i386 \
--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH v3 2/2] xen: Clear TUNE_CCARGS for Xen build for aarch64 machines

[Kamil Dziezyk]

Xen build may fail for arm machines that have enabled extra flags,
that can be enabled only for specific architecture version, e.g. armv8-2a.

Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
---
 recipes-extended/xen/xen-hypervisor.inc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/recipes-extended/xen/xen-hypervisor.inc b/recipes-extended/xen/xen-hypervisor.inc
index cffd491..81e361f 100644
--- a/recipes-extended/xen/xen-hypervisor.inc
+++ b/recipes-extended/xen/xen-hypervisor.inc
@@ -103,3 +103,7 @@ CROSS_CURSES_LIB += "-L${STAGING_LIBDIR_NATIVE}"
 # Specify the root dir of the .config file for do_menuconfig and do_diffconfig
 # tasks
 KCONFIG_CONFIG_ROOTDIR = "${S}/xen"
+
+# Xen is setting all CC flags on its own. Make sure that they are not modified
+# for aarch64, e.g. with architecture-specific optimizations.
+TUNE_CCARGS:aarch64=""
--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Bertrand Marquis]

Hi Kamil,

> On 13 Jan 2022, at 11:30, Kamil Dziezyk via lists.yoctoproject.org <kamil.dziezyk=arm.com@lists.yoctoproject.org> wrote:
>
> This patch changes the location of xen.conf file, that contains list of kernel
> modules to be loaded during system boot, to "${nonarch_libdir}". This is done
> by removing '--with-systemd-modules-load=' flag from EXTRA_OECONF variable.
>
> Previous path based on "${systemd_unitdir}" was not considered by default by
> systemd-modules-load.service.
>
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/xen/xen-tools.inc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/recipes-extended/xen/xen-tools.inc b/recipes-extended/xen/xen-tools.inc
> index ca924f4..6e25046 100644
> --- a/recipes-extended/xen/xen-tools.inc
> +++ b/recipes-extended/xen/xen-tools.inc
> @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
>     "
>
> FILES:${PN}-xencommons += "\
> +    ${nonarch_libdir}/modules-load.d/xen.conf \
>     ${sysconfdir}/default/xencommons \
>     ${sysconfdir}/init.d/xencommons \
>     ${sysconfdir}/xen/scripts/launch-xenstore \
> -    ${systemd_unitdir}/modules-load.d/xen.conf \
>     ${systemd_unitdir}/system/proc-xen.mount \
>     ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
>     ${systemd_unitdir}/system/xenconsoled.service \
> @@ -744,7 +744,6 @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"
>
> EXTRA_OECONF += " \
>     --with-systemd=${systemd_unitdir}/system \
> -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
>     --with-initddir=${INIT_D_DIR} \
>     --with-sysconfig-leaf-dir=default \
>     --with-system-qemu=${bindir}/qemu-system-i386 \
> --
> 2.17.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6999): https://lists.yoctoproject.org/g/meta-virtualization/message/6999
> Mute This Topic: https://lists.yoctoproject.org/mt/88394698/3619089
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization] [PATCH v3 2/2] xen: Clear TUNE_CCARGS for Xen build for aarch64 machines

[Bertrand Marquis]

Hi Kamil,

> On 13 Jan 2022, at 11:30, Kamil Dziezyk via lists.yoctoproject.org <kamil.dziezyk=arm.com@lists.yoctoproject.org> wrote:
>
> Xen build may fail for arm machines that have enabled extra flags,
> that can be enabled only for specific architecture version, e.g. armv8-2a.
>
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/xen/xen-hypervisor.inc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/recipes-extended/xen/xen-hypervisor.inc b/recipes-extended/xen/xen-hypervisor.inc
> index cffd491..81e361f 100644
> --- a/recipes-extended/xen/xen-hypervisor.inc
> +++ b/recipes-extended/xen/xen-hypervisor.inc
> @@ -103,3 +103,7 @@ CROSS_CURSES_LIB += "-L${STAGING_LIBDIR_NATIVE}"
> # Specify the root dir of the .config file for do_menuconfig and do_diffconfig
> # tasks
> KCONFIG_CONFIG_ROOTDIR = "${S}/xen"
> +
> +# Xen is setting all CC flags on its own. Make sure that they are not modified
> +# for aarch64, e.g. with architecture-specific optimizations.
> +TUNE_CCARGS:aarch64=""
> --
> 2.17.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7000): https://lists.yoctoproject.org/g/meta-virtualization/message/7000
> Mute This Topic: https://lists.yoctoproject.org/mt/88394702/3619089
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization] [PATCH v3 2/2] xen: Clear TUNE_CCARGS for Xen build for aarch64 machines

[Christopher Clark]

[-- Attachment #1: Type: text/plain, Size: 2496 bytes --]

On Mon, Jan 17, 2022 at 12:34 AM Bertrand Marquis <Bertrand.Marquis@arm.com>
wrote:

> Hi Kamil,
>
> > On 13 Jan 2022, at 11:30, Kamil Dziezyk via lists.yoctoproject.org
> <kamil.dziezyk=arm.com@lists.yoctoproject.org> wrote:
> >
> > Xen build may fail for arm machines that have enabled extra flags,
> > that can be enabled only for specific architecture version, e.g.
> armv8-2a.
> >
> > Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>

Acked-by: Christopher Clark <christopher.w.clark@gmail.com>

Christopher



>
> Cheers
> Bertrand
>
> > ---
> > recipes-extended/xen/xen-hypervisor.inc | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/recipes-extended/xen/xen-hypervisor.inc
> b/recipes-extended/xen/xen-hypervisor.inc
> > index cffd491..81e361f 100644
> > --- a/recipes-extended/xen/xen-hypervisor.inc
> > +++ b/recipes-extended/xen/xen-hypervisor.inc
> > @@ -103,3 +103,7 @@ CROSS_CURSES_LIB += "-L${STAGING_LIBDIR_NATIVE}"
> > # Specify the root dir of the .config file for do_menuconfig and
> do_diffconfig
> > # tasks
> > KCONFIG_CONFIG_ROOTDIR = "${S}/xen"
> > +
> > +# Xen is setting all CC flags on its own. Make sure that they are not
> modified
> > +# for aarch64, e.g. with architecture-specific optimizations.
> > +TUNE_CCARGS:aarch64=""
> > --
> > 2.17.1
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7000):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7000
> > Mute This Topic: https://lists.yoctoproject.org/mt/88394702/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>

[-- Attachment #2: Type: text/html, Size: 4063 bytes --]

Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Christopher Clark]

[-- Attachment #1: Type: text/plain, Size: 3197 bytes --]

On Mon, Jan 17, 2022 at 12:33 AM Bertrand Marquis <Bertrand.Marquis@arm.com>
wrote:

> Hi Kamil,
>
> > On 13 Jan 2022, at 11:30, Kamil Dziezyk via lists.yoctoproject.org
> <kamil.dziezyk=arm.com@lists.yoctoproject.org> wrote:
> >
> > This patch changes the location of xen.conf file, that contains list of
> kernel
> > modules to be loaded during system boot, to "${nonarch_libdir}". This is
> done
> > by removing '--with-systemd-modules-load=' flag from EXTRA_OECONF
> variable.
> >
> > Previous path based on "${systemd_unitdir}" was not considered by
> default by
> > systemd-modules-load.service.
> >
> > Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>

Acked-by: Christopher Clark <christopher.w.clark@gmail.com>

Christopher



>
> Cheers
> Bertrand
>
> > ---
> > recipes-extended/xen/xen-tools.inc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/recipes-extended/xen/xen-tools.inc
> b/recipes-extended/xen/xen-tools.inc
> > index ca924f4..6e25046 100644
> > --- a/recipes-extended/xen/xen-tools.inc
> > +++ b/recipes-extended/xen/xen-tools.inc
> > @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
> >     "
> >
> > FILES:${PN}-xencommons += "\
> > +    ${nonarch_libdir}/modules-load.d/xen.conf \
> >     ${sysconfdir}/default/xencommons \
> >     ${sysconfdir}/init.d/xencommons \
> >     ${sysconfdir}/xen/scripts/launch-xenstore \
> > -    ${systemd_unitdir}/modules-load.d/xen.conf \
> >     ${systemd_unitdir}/system/proc-xen.mount \
> >     ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
> >     ${systemd_unitdir}/system/xenconsoled.service \
> > @@ -744,7 +744,6 @@ SYSTEMD_SERVICE:${PN}-xendomains =
> "xendomains.service"
> >
> > EXTRA_OECONF += " \
> >     --with-systemd=${systemd_unitdir}/system \
> > -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
> >     --with-initddir=${INIT_D_DIR} \
> >     --with-sysconfig-leaf-dir=default \
> >     --with-system-qemu=${bindir}/qemu-system-i386 \
> > --
> > 2.17.1
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#6999):
> https://lists.yoctoproject.org/g/meta-virtualization/message/6999
> > Mute This Topic: https://lists.yoctoproject.org/mt/88394698/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>

[-- Attachment #2: Type: text/html, Size: 4923 bytes --]

Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Bruce Ashfield]

merged.

Bruce

In message: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot
on 13/01/2022 Kamil Dziezyk wrote:

> This patch changes the location of xen.conf file, that contains list of kernel
> modules to be loaded during system boot, to "${nonarch_libdir}". This is done
> by removing '--with-systemd-modules-load=' flag from EXTRA_OECONF variable.
> 
> Previous path based on "${systemd_unitdir}" was not considered by default by
> systemd-modules-load.service.
> 
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> ---
>  recipes-extended/xen/xen-tools.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/recipes-extended/xen/xen-tools.inc b/recipes-extended/xen/xen-tools.inc
> index ca924f4..6e25046 100644
> --- a/recipes-extended/xen/xen-tools.inc
> +++ b/recipes-extended/xen/xen-tools.inc
> @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
>      "
> 
>  FILES:${PN}-xencommons += "\
> +    ${nonarch_libdir}/modules-load.d/xen.conf \
>      ${sysconfdir}/default/xencommons \
>      ${sysconfdir}/init.d/xencommons \
>      ${sysconfdir}/xen/scripts/launch-xenstore \
> -    ${systemd_unitdir}/modules-load.d/xen.conf \
>      ${systemd_unitdir}/system/proc-xen.mount \
>      ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
>      ${systemd_unitdir}/system/xenconsoled.service \
> @@ -744,7 +744,6 @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"
> 
>  EXTRA_OECONF += " \
>      --with-systemd=${systemd_unitdir}/system \
> -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
>      --with-initddir=${INIT_D_DIR} \
>      --with-sysconfig-leaf-dir=default \
>      --with-system-qemu=${bindir}/qemu-system-i386 \
> --
> 2.17.1
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6999): https://lists.yoctoproject.org/g/meta-virtualization/message/6999
> Mute This Topic: https://lists.yoctoproject.org/mt/88394698/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


In message: [meta-virtualization] [PATCH v3 2/2] xen: Clear TUNE_CCARGS for Xen build for aarch64 machines
on 13/01/2022 Kamil Dziezyk wrote:

> Xen build may fail for arm machines that have enabled extra flags,
> that can be enabled only for specific architecture version, e.g. armv8-2a.
> 
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> ---
>  recipes-extended/xen/xen-hypervisor.inc | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/recipes-extended/xen/xen-hypervisor.inc b/recipes-extended/xen/xen-hypervisor.inc
> index cffd491..81e361f 100644
> --- a/recipes-extended/xen/xen-hypervisor.inc
> +++ b/recipes-extended/xen/xen-hypervisor.inc
> @@ -103,3 +103,7 @@ CROSS_CURSES_LIB += "-L${STAGING_LIBDIR_NATIVE}"
>  # Specify the root dir of the .config file for do_menuconfig and do_diffconfig
>  # tasks
>  KCONFIG_CONFIG_ROOTDIR = "${S}/xen"
> +
> +# Xen is setting all CC flags on its own. Make sure that they are not modified
> +# for aarch64, e.g. with architecture-specific optimizations.
> +TUNE_CCARGS:aarch64=""
> --
> 2.17.1
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7000): https://lists.yoctoproject.org/g/meta-virtualization/message/7000
> Mute This Topic: https://lists.yoctoproject.org/mt/88394702/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

RE: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Diego Sueiro]

Hello Bruce,

Thanks for getting this merged.

We consider these patches as bug fixing and in this case is it possible to have them backported (cherry picked) to honister branch?

Cheers,

--
Diego Sueiro

>-----Original Message-----
>From: meta-virtualization@lists.yoctoproject.org <meta-
>virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield via
>lists.yoctoproject.org
>Sent: 19 January 2022 03:44
>To: Kamil Dzieżyk <Kamil.Dziezyk@arm.com>
>Cc: meta-virtualization@lists.yoctoproject.org;
>christopher.w.clark@gmail.com; cardoe@gentoo.org
>Subject: Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
>kernel modules during system boot
>
>merged.
>
>Bruce
>
>In message: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
>kernel modules during system boot on 13/01/2022 Kamil Dziezyk wrote:
>
>> This patch changes the location of xen.conf file, that contains list
>> of kernel modules to be loaded during system boot, to
>> "${nonarch_libdir}". This is done by removing '--with-systemd-modules-
>load=' flag from EXTRA_OECONF variable.
>>
>> Previous path based on "${systemd_unitdir}" was not considered by
>> default by systemd-modules-load.service.
>>
>> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
>> ---
>>  recipes-extended/xen/xen-tools.inc | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/recipes-extended/xen/xen-tools.inc
>> b/recipes-extended/xen/xen-tools.inc
>> index ca924f4..6e25046 100644
>> --- a/recipes-extended/xen/xen-tools.inc
>> +++ b/recipes-extended/xen/xen-tools.inc
>> @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
>>      "
>>
>>  FILES:${PN}-xencommons += "\
>> +    ${nonarch_libdir}/modules-load.d/xen.conf \
>>      ${sysconfdir}/default/xencommons \
>>      ${sysconfdir}/init.d/xencommons \
>>      ${sysconfdir}/xen/scripts/launch-xenstore \
>> -    ${systemd_unitdir}/modules-load.d/xen.conf \
>>      ${systemd_unitdir}/system/proc-xen.mount \
>>      ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
>>      ${systemd_unitdir}/system/xenconsoled.service \ @@ -744,7 +744,6
>> @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"
>>
>>  EXTRA_OECONF += " \
>>      --with-systemd=${systemd_unitdir}/system \
>> -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
>>      --with-initddir=${INIT_D_DIR} \
>>      --with-sysconfig-leaf-dir=default \
>>      --with-system-qemu=${bindir}/qemu-system-i386 \
>> --
>> 2.17.1
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>confidential and may also be privileged. If you are not the intended recipient,
>please notify the sender immediately and do not disclose the contents to any
>other person, use it for any purpose, or store or copy the information in any
>medium. Thank you.
>
>>
>>
>>
>

Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related kernel modules during system boot

[Bruce Ashfield]

On Wed, Jan 19, 2022 at 7:39 AM Diego Sueiro <Diego.Sueiro@arm.com> wrote:
>
> Hello Bruce,
>
> Thanks for getting this merged.
>
> We consider these patches as bug fixing and in this case is it possible to have them backported (cherry picked) to honister branch?
>

Agreed. they are bug fixes, so I've done the cherry pick to honister.

Bruce

> Cheers,
>
> --
> Diego Sueiro
>
> >-----Original Message-----
> >From: meta-virtualization@lists.yoctoproject.org <meta-
> >virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield via
> >lists.yoctoproject.org
> >Sent: 19 January 2022 03:44
> >To: Kamil Dzieżyk <Kamil.Dziezyk@arm.com>
> >Cc: meta-virtualization@lists.yoctoproject.org;
> >christopher.w.clark@gmail.com; cardoe@gentoo.org
> >Subject: Re: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
> >kernel modules during system boot
> >
> >merged.
> >
> >Bruce
> >
> >In message: [meta-virtualization] [PATCH v3 1/2] xen-tools: Load xen related
> >kernel modules during system boot on 13/01/2022 Kamil Dziezyk wrote:
> >
> >> This patch changes the location of xen.conf file, that contains list
> >> of kernel modules to be loaded during system boot, to
> >> "${nonarch_libdir}". This is done by removing '--with-systemd-modules-
> >load=' flag from EXTRA_OECONF variable.
> >>
> >> Previous path based on "${systemd_unitdir}" was not considered by
> >> default by systemd-modules-load.service.
> >>
> >> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> >> ---
> >>  recipes-extended/xen/xen-tools.inc | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/recipes-extended/xen/xen-tools.inc
> >> b/recipes-extended/xen/xen-tools.inc
> >> index ca924f4..6e25046 100644
> >> --- a/recipes-extended/xen/xen-tools.inc
> >> +++ b/recipes-extended/xen/xen-tools.inc
> >> @@ -653,10 +653,10 @@ FILES:${PN}-xm = "\
> >>      "
> >>
> >>  FILES:${PN}-xencommons += "\
> >> +    ${nonarch_libdir}/modules-load.d/xen.conf \
> >>      ${sysconfdir}/default/xencommons \
> >>      ${sysconfdir}/init.d/xencommons \
> >>      ${sysconfdir}/xen/scripts/launch-xenstore \
> >> -    ${systemd_unitdir}/modules-load.d/xen.conf \
> >>      ${systemd_unitdir}/system/proc-xen.mount \
> >>      ${systemd_unitdir}/system/xen-qemu-dom0-disk-backend.service \
> >>      ${systemd_unitdir}/system/xenconsoled.service \ @@ -744,7 +744,6
> >> @@ SYSTEMD_SERVICE:${PN}-xendomains = "xendomains.service"
> >>
> >>  EXTRA_OECONF += " \
> >>      --with-systemd=${systemd_unitdir}/system \
> >> -    --with-systemd-modules-load=${systemd_unitdir}/modules-load.d \
> >>      --with-initddir=${INIT_D_DIR} \
> >>      --with-sysconfig-leaf-dir=default \
> >>      --with-system-qemu=${bindir}/qemu-system-i386 \
> >> --
> >> 2.17.1
> >>
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> >confidential and may also be privileged. If you are not the intended recipient,
> >please notify the sender immediately and do not disclose the contents to any
> >other person, use it for any purpose, or store or copy the information in any
> >medium. Thank you.
> >
> >>
> >>
> >>
> >
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II