Re: [meta-virtualization] [PATCH] libvirt: do not install /var/log for target

["kai" <kai.kang@windriver.com>]

On 11/12/21 12:03 PM, Bruce Ashfield wrote:
> On Thu, Nov 11, 2021 at 10:23 PM kai <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> /var/log is normally a link to /var/volatile/log and /var/volatile is a tmpfs
>> mount. So anything created in /var/log will not be available when the tmpfs is
>> mounted.
>>
>> Not install /var/log to avoid 'empty-dirs' qa issue:
>>
>> | ERROR: libvirt-7.2.0-r0 do_package_qa: QA Issue: libvirt installs files in
>>    /var/volatile, but it is expected to be empty [empty-dirs]
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   recipes-extended/libvirt/libvirt_7.2.0.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/recipes-extended/libvirt/libvirt_7.2.0.bb b/recipes-extended/libvirt/libvirt_7.2.0.bb
>> index b7f8383a..b49bd11a 100644
>> --- a/recipes-extended/libvirt/libvirt_7.2.0.bb
>> +++ b/recipes-extended/libvirt/libvirt_7.2.0.bb
>> @@ -232,6 +232,10 @@ do_install:append() {
>>          echo "d root root 0755 /run/libvirt/qemu none" \
>>               >> ${D}${sysconfdir}/default/volatiles/99_libvirt
>>
>> +       # /var/log is normally a link to /var/volatile/log
>> +       # and /var/volatile is a tmpfs mount which should be clean.
>> +       rm -rf ${D}${localstatedir}/log
> We should be preventing the install from happening at all, not
> deleting it after the fact.
>
> If libvirt thinks something needs to be in the directory, then we
> should be looking into why it does exactly that.

OK.I'll figure out.

Regards,
Kai

>
> Bruce
>
>> +
>>          # Manually set permissions and ownership to match polkit recipe
>>          if ${@bb.utils.contains('PACKAGECONFIG', 'polkit', 'true', 'false', d)}; then
>>                  install -d -m 0700 ${D}/${datadir}/polkit-1/rules.d
>> --
>> 2.33.0
>>
>>
>> 
>>
>

-- 
Kai Kang
Wind River Linux