From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392D2C4167B for ; Thu, 9 Nov 2023 22:18:20 +0000 (UTC) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by mx.groups.io with SMTP id smtpd.web10.14720.1699568289956615649 for ; Thu, 09 Nov 2023 14:18:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=p5hsNE+M; spf=pass (domain: savoirfairelinux.com, ip: 208.88.110.44, mailfrom: alassane.yattara@savoirfairelinux.com) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id D15F09C34C8; Thu, 9 Nov 2023 17:18:08 -0500 (EST) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id nVeQQrvuz95A; Thu, 9 Nov 2023 17:18:08 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 2BF149C34CF; Thu, 9 Nov 2023 17:18:08 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 2BF149C34CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1699568288; bh=Zt3vTWXC8vvH2/mBdltPB0z9Bfvqac6DxLBCa1czh3g=; h=Date:From:To:Message-ID:MIME-Version; b=p5hsNE+MDahc52jIuhn8OMOLMasgOwOl3GHmiRgndAVsl24MOkyaYTdNox8PEGT9+ WKbSjvT6crmy8/QatF73uEL7Ztm17caawEqgNg+g55kiDBmC7fcBDaTxNlfMBx/1AG qEXBu6W2i/x4tFmH9kPc174nbViTswcOm6NL9iLYl+gabJ0w/RnqcKjOMfwHUZhMBL /Xyl2gggXN2YGb4/10GjVuYKtgyy8vfwu+Ahdjqlf4Y6bHP6P+6HuDkMB6DuUKyx8f dfNK4UwQPsJz6bs6P62/7Ul+DoaInlDY2figFF95yUiaVwjSLNK0qwDWNcu4eZAluA 2GWrkHFl5727A== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id J1S0t8odrlIT; Thu, 9 Nov 2023 17:18:08 -0500 (EST) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 150029C34C8; Thu, 9 Nov 2023 17:18:08 -0500 (EST) Date: Thu, 9 Nov 2023 17:18:08 -0500 (EST) From: Alassane Yattara To: Richard Purdie Cc: toaster Message-ID: <1623693830.585694.1699568288037.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <9c199140956897c2424bf866cb40f1084164f609.camel@linuxfoundation.org> References: <20231109215514.92165-1-alassane.yattara@savoirfairelinux.com> <20231109215514.92165-3-alassane.yattara@savoirfairelinux.com> <9c199140956897c2424bf866cb40f1084164f609.camel@linuxfoundation.org> Subject: Re: [Toaster] [PATCH v2 3/3] Toaster: Write UI TestCase import new project using MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.15_GA_4562 (ZimbraWebClient - GC117 (Linux)/8.8.15_GA_4570) Thread-Topic: Toaster: Write UI TestCase import new project using Thread-Index: +mTRbzWtEoFOY2Vmqeqvez+pnRR69w== List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 09 Nov 2023 22:18:20 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/toaster/message/5984 Richard, Yes you right below line should be remove from commit msg. > * Update copyright, remove "Inc" ----- Mail original ----- De: "Richard Purdie" =C3=80: "Alassane Yattara" , "toaste= r" Envoy=C3=A9: Jeudi 9 Novembre 2023 23:06:28 Objet: Re: [Toaster] [PATCH v2 3/3] Toaster: Write UI TestCase import new p= roject using On Thu, 2023-11-09 at 22:55 +0100, Alassane Yattara wrote: > * Test import new project using: > - Project Name: Any string > - Project type: select (Import command line project) > - Import existing project directory: Wrong Path > * Update copyright, remove "Inc" This patch series looks *much* better in general, thanks! I was a little bit puzzled by this last line item about copyright? Cheers, Richard >=20 > Signed-off-by: Alassane Yattara > --- > .../functional/test_create_new_project.py | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/lib/toaster/tests/functional/test_create_new_project.py b/li= b/toaster/tests/functional/test_create_new_project.py > index f33eb16d..a211d8b7 100644 > --- a/lib/toaster/tests/functional/test_create_new_project.py > +++ b/lib/toaster/tests/functional/test_create_new_project.py > @@ -149,3 +149,28 @@ class TestCreateNewProject(SeleniumFunctionalTestCas= e): > create_btn =3D self.driver.find_element(By.ID, "create-project-b= utton") > self.assertIsNotNone(create_btn.get_attribute('disabled'), > 'Create button is not disabled') > + > + def test_import_new_project(self): > + """ Test import new project using: > + - Project Name: Any string > + - Project type: select (Import command line project) > + - Import existing project directory: Wrong Path > + """ > + project_name =3D 'projectimport' > + self.get(reverse('newproject')) > + self.driver.find_element(By.ID, > + "new-project-name").send_keys(project_n= ame) > + # select import project > + self.find('#type-import').click() > + > + # set wrong path > + wrong_path =3D '/wrongpath' > + self.driver.find_element(By.ID, > + "import-project-dir").send_keys(wrong_p= ath) > + self.driver.find_element(By.ID, "create-project-button").click() > + > + # check error message > + self.assertTrue(self.element_exists('.alert-danger'), > + 'Allert message not shown') > + self.assertTrue(wrong_path in self.find('.alert-danger').text, > + "Wrong path not in alert message") > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- > Links: You receive all messages sent to this group. > View/Reply Online (#5976): https://lists.yoctoproject.org/g/toaster/messa= ge/5976 > Mute This Topic: https://lists.yoctoproject.org/mt/102495675/1686473 > Group Owner: toaster+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [richard.purd= ie@linuxfoundation.org] > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- >