From: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
To: toaster@lists.yoctoproject.org
Cc: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
Subject: [PATCH v4 4/4] toaster/test: Bug-fix ToasterTable show_rows testcases
Date: Tue, 9 Jan 2024 17:30:53 +0100 [thread overview]
Message-ID: <20240109163053.535179-4-alassane.yattara@savoirfairelinux.com> (raw)
In-Reply-To: <20240109163053.535179-1-alassane.yattara@savoirfairelinux.com>
Test if some rows are visible in table instead of compare row to row_to_show,
because sometime full avaiblable content did not display
Failed: https://autobuilder.yoctoproject.org/typhoon/#/builders/161/builds/147/steps/12/logs/stdio
Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
---
lib/toaster/tests/browser/test_all_builds_page.py | 5 +++--
lib/toaster/tests/browser/test_all_projects_page.py | 3 ++-
lib/toaster/tests/functional/test_project_page.py | 5 +++--
lib/toaster/tests/functional/test_project_page_tab_config.py | 2 +-
4 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/toaster/tests/browser/test_all_builds_page.py b/lib/toaster/tests/browser/test_all_builds_page.py
index ab6da821..b9356a03 100644
--- a/lib/toaster/tests/browser/test_all_builds_page.py
+++ b/lib/toaster/tests/browser/test_all_builds_page.py
@@ -452,9 +452,10 @@ class TestAllBuildsPage(SeleniumTestCase):
def test_show_rows(row_to_show, show_row_link):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
- self.wait_until_visible('#allbuildstable tbody tr', poll=2)
+ self.wait_until_visible('#allbuildstable tbody tr', poll=3)
+ # check at least some rows are visible
self.assertTrue(
- len(self.find_all('#allbuildstable tbody tr')) == row_to_show
+ len(self.find_all('#allbuildstable tbody tr')) > 0
)
url = reverse('all-builds')
diff --git a/lib/toaster/tests/browser/test_all_projects_page.py b/lib/toaster/tests/browser/test_all_projects_page.py
index 6540dfa9..9ed1901c 100644
--- a/lib/toaster/tests/browser/test_all_projects_page.py
+++ b/lib/toaster/tests/browser/test_all_projects_page.py
@@ -314,8 +314,9 @@ class TestAllProjectsPage(SeleniumTestCase):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
self.wait_until_visible('#projectstable tbody tr', poll=3)
+ # check at least some rows are visible
self.assertTrue(
- len(self.find_all('#projectstable tbody tr')) == row_to_show
+ len(self.find_all('#projectstable tbody tr')) > 0
)
url = reverse('all-projects')
diff --git a/lib/toaster/tests/functional/test_project_page.py b/lib/toaster/tests/functional/test_project_page.py
index 31177cc1..adbe3587 100644
--- a/lib/toaster/tests/functional/test_project_page.py
+++ b/lib/toaster/tests/functional/test_project_page.py
@@ -192,9 +192,10 @@ class TestProjectPage(SeleniumFunctionalTestCase):
def test_show_rows(row_to_show, show_row_link):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
- self.wait_until_visible(f'#{table_selector} tbody tr', poll=2)
+ self.wait_until_visible(f'#{table_selector} tbody tr', poll=3)
+ # check at least some rows are visible
self.assertTrue(
- len(self.find_all(f'#{table_selector} tbody tr')) == row_to_show
+ len(self.find_all(f'#{table_selector} tbody tr')) > 0
)
self.wait_until_present(f'#{table_selector} tbody tr')
show_rows = self.driver.find_elements(
diff --git a/lib/toaster/tests/functional/test_project_page_tab_config.py b/lib/toaster/tests/functional/test_project_page_tab_config.py
index 03b0a854..eb905ddf 100644
--- a/lib/toaster/tests/functional/test_project_page_tab_config.py
+++ b/lib/toaster/tests/functional/test_project_page_tab_config.py
@@ -253,7 +253,7 @@ class TestProjectConfigTab(SeleniumFunctionalTestCase):
def test_show_rows(row_to_show, show_row_link):
# Check that we can show rows == row_to_show
show_row_link.select_by_value(str(row_to_show))
- self.wait_until_visible('#imagerecipestable tbody tr')
+ self.wait_until_visible('#imagerecipestable tbody tr', poll=3)
# check at least some rows are visible
self.assertTrue(
len(self.find_all('#imagerecipestable tbody tr')) > 0
--
2.34.1
prev parent reply other threads:[~2024-01-09 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 16:30 [PATCH v4 1/4] toaster/test: Setup delay after drvier action self.get(url) Alassane Yattara
2024-01-09 16:30 ` [PATCH v4 2/4] toaster/test: bug-fix "#hint-error-project-name" should be visible Alassane Yattara
2024-01-09 16:30 ` [PATCH v4 3/4] toaster/test: Bug-fix "element not interactable" in TestLayerDetailsPage::test_edit_layerdetails Alassane Yattara
2024-01-09 16:30 ` Alassane Yattara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109163053.535179-4-alassane.yattara@savoirfairelinux.com \
--to=alassane.yattara@savoirfairelinux.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).