From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BDB4C46CA0 for ; Wed, 6 Dec 2023 23:02:22 +0000 (UTC) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.58423.1701903735771344551 for ; Wed, 06 Dec 2023 15:02:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=CdOhwMQS; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.49, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40c08af319cso3784635e9.2 for ; Wed, 06 Dec 2023 15:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1701903731; x=1702508531; darn=lists.yoctoproject.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=IMFeCT/5c3dJOTngXRl93lB/5Lto3LYmR6c8ftzDUXA=; b=CdOhwMQSqqXWSn9qRScU+m2VFj0letNufGbelc++KFO8fDjJTYkvrUC9U5TB/11zJP cyw28i1uXsNBgU2dKikzvtFFOy9eQsalSSIB44Vo350xss+5k7NCJy3cSOCrunGEGx4T VVGRKd7LW4SoHCv2Kf6ZdOC1VyPrLPKNUUeaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701903731; x=1702508531; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IMFeCT/5c3dJOTngXRl93lB/5Lto3LYmR6c8ftzDUXA=; b=xCBDPIdgQUYRCMzGUPhrq18wWlnIPCE5B47cCTwAB0CppzPdHmZjqIAvihzNex1JSK NT/7+hkKLPJIMerx2BXTSjQXt9Uz1GwXcPGE9Md38oIBH3oL2JtLLDmyq3nalJV12vbU dAHAFU1kWCM0LasETPjAW8pEhW0Av60GQmIOjYSIREeRE8LPW6ROm7cyvUpuoLQ+Ge74 Nhrzj0x9ABaEnad8wrdjgjeXSjZaRNUAFFHr4o+4NJ0f11x/1XlQ3LeqRBz2TeULr7oE v1+j/Sm8a5nbejPeQoYOKWDuwJSu4ZAzUcVyYy0j8VbH1nW9AiiZ8/KARzoB98xpVDyn aLgw== X-Gm-Message-State: AOJu0Yykf6BpoR/CPzKZu7RZXBCWXYDQZo8NjLiuujtgEvMFit91CfQl maMYfmJsE2z/l6prUg19oWM8MA== X-Google-Smtp-Source: AGHT+IGO5RL9x/DwFg895dYRxr3Qp0/pqyf37KYT+7B8qNlpASRfYUtTTSg3MOgAVR5Wolrzef/DbQ== X-Received: by 2002:a05:600c:1c8f:b0:40b:5e59:e9fc with SMTP id k15-20020a05600c1c8f00b0040b5e59e9fcmr896788wms.155.1701903730982; Wed, 06 Dec 2023 15:02:10 -0800 (PST) Received: from ?IPv6:2001:8b0:aba:5f3c:30b4:b44a:2cc6:3876? ([2001:8b0:aba:5f3c:30b4:b44a:2cc6:3876]) by smtp.gmail.com with ESMTPSA id i22-20020a05600c355600b004083729fc14sm1066640wmq.20.2023.12.06.15.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 15:02:10 -0800 (PST) Message-ID: <9e1be8c6a333fcbb50b7e6fdfab98094a341e025.camel@linuxfoundation.org> Subject: Re: [toaster][PATCHv3 3/3] toaster: Update eventreplay functionality for new eventlog file structure From: Richard Purdie To: Marlon Rodriguez Garcia , bitbake-devel@lists.openembedded.org, toaster@lists.yoctoproject.org Date: Wed, 06 Dec 2023 23:02:09 +0000 In-Reply-To: <20231206224305.34686-4-marlon.rodriguez-garcia@savoirfairelinux.com> References: <20231206224305.34686-1-marlon.rodriguez-garcia@savoirfairelinux.com> <20231206224305.34686-4-marlon.rodriguez-garcia@savoirfairelinux.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1-0ubuntu1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 06 Dec 2023 23:02:22 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/toaster/message/6060 On Wed, 2023-12-06 at 17:43 -0500, Marlon Rodriguez Garcia wrote: > Added class EventPlayer to list of libraries under bitbake/bb/ui/ > Update file read functionality to match new eventlog format >=20 > Exclude listing of files that don't contain the allvariables definitions = used to replay builds > This part of the feature should be revisited. Over a long period of time,= the BB_DEFAULT_EVENTLOG > will exponentially increase the size of the log file and cause bottleneck= s when importing. >=20 > Signed-off-by: Marlon Rodriguez Garcia > --- > lib/bb/ui/eventreplay.py | 85 +++++++++++++++++++++ > lib/toaster/toastergui/views.py | 131 ++++++++++++-------------------- > 2 files changed, 132 insertions(+), 84 deletions(-) > create mode 100644 lib/bb/ui/eventreplay.py Our patches overlapped! I've merged a patch to fix toaster-eventreplay and it is slightly different to the code below. The major tweaks are handling a second 'allvariables' entry and adding a eventfile.seek(0) to reset the stream before calling the player. We should probably have a standalone patch moving that code from toaster-eventreplay to lib/bb/ui/eventreplay.py and making it use it, when can then be followed by the patch below to have views.py use it as well? Cheers, Richard