Re: [toaster][PATCHv3 3/3] toaster: Update eventreplay functionality for new eventlog file structure

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2023-12-06 at 18:32 -0500, Marlon Rodriguez Garcia wrote:
> I think this could be merge as it is now, and another patch will be
> added to update the Views and the eventreplay lib, can you share the
> patch with the new changes ?

It is sub optimal that the series adds the code to views.py in 1/3 and
then moves it again in 3/3 so I'm leaning to reworking the patches to
clean things up.

The patches still need work since they cause two existing tests to
regress too (as far as I can tell anyway).

The changes to eventreplay merged here:

https://git.yoctoproject.org/poky/commit/?id=3ee5c86da3773deb091e24b98ad592c5d19274fb

Cheers,

Richard 

> 
> ----- Original Message -----
> From: "richard purdie" <richard.purdie@linuxfoundation.org>
> To: "Marlon Rodriguez Garcia" <marlon.rodriguez-garcia@savoirfairelinux.com>, bitbake-devel@lists.openembedded.org, toaster@lists.yoctoproject.org
> Sent: Wednesday, December 6, 2023 6:02:09 PM
> Subject: Re: [toaster][PATCHv3 3/3] toaster: Update eventreplay functionality for new eventlog file structure
> 
> On Wed, 2023-12-06 at 17:43 -0500, Marlon Rodriguez Garcia wrote:
> > Added class EventPlayer to list of libraries under bitbake/bb/ui/
> > Update file read functionality to match new eventlog format
> > 
> > Exclude listing of files that don't contain the allvariables definitions used to replay builds
> > This part of the feature should be revisited. Over a long period of time, the BB_DEFAULT_EVENTLOG
> > will exponentially increase the size of the log file and cause bottlenecks when importing.
> > 
> > Signed-off-by: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
> > ---
> >  lib/bb/ui/eventreplay.py        |  85 +++++++++++++++++++++
> >  lib/toaster/toastergui/views.py | 131 ++++++++++++--------------------
> >  2 files changed, 132 insertions(+), 84 deletions(-)
> >  create mode 100644 lib/bb/ui/eventreplay.py
> 
> Our patches overlapped!
> 
> I've merged a patch to fix toaster-eventreplay and it is slightly
> different to the code below. The major tweaks are handling a second
> 'allvariables' entry and adding a eventfile.seek(0) to reset the stream
> before calling the player.
> 
> We should probably have a standalone patch moving that code from
> toaster-eventreplay to lib/bb/ui/eventreplay.py and making it use it,
> when can then be followed by the patch below to have views.py use it as
> well?
> 
> Cheers,
> 
> Richard
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6060): https://lists.yoctoproject.org/g/toaster/message/6060
> Mute This Topic: https://lists.yoctoproject.org/mt/103023929/7896800
> Group Owner: toaster+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [marlon.rodriguez-garcia@savoirfairelinux.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>