toaster.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Marlon Rodriguez Garcia
	<marlon.rodriguez-garcia@savoirfairelinux.com>,
	 bitbake-devel@lists.openembedded.org,
	toaster@lists.yoctoproject.org
Subject: Re: [Toaster] [PATCH] toaster: Added dataTables library to include sorting and pagination for table element
Date: Wed, 13 Dec 2023 13:11:06 +0000	[thread overview]
Message-ID: <a4075d7dacd13a9c974c227c987ac112093204d7.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231212215713.235263-1-marlon.rodriguez-garcia@savoirfairelinux.com>

On Tue, 2023-12-12 at 16:57 -0500, Marlon Rodriguez Garcia wrote:
> Added jquery.dataTables to customize table rendering in section
> "Import eventlogs".
> This library includes the following: sorting, pagination, search and
> CSS styles.

Thanks, this looks good. I noticed that there are a couple of static
images missing:

http://localhost:8000/static/images/sort_asc.png
http://localhost:8000/static/images/sort_both.png

I also wondered about something like this:

diff --git a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
index 25a5e8062fb..c9fefef01a2 100644
--- a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
+++ b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
@@ -197,7 +197,7 @@ $( "#form_file").on( "submit", function( event ) {
 });
 
 $(document).ready( function () {
-    $('#eventlog-table').DataTable();
+    $('#eventlog-table').DataTable({order: [[0, 'desc']], "pageLength": 50})
 });
 
 </script>

to set the default sort and show a few more file entries per page. Not
sure if I have that in the right place!

I did also realise the issue I was trying to explain yesterday.

If you start an import of a commandline build, then try and import a
second one whilst the first is still running, it crashes. Is there
something we can do about that so they queue?

Cheers,

Richard




  reply	other threads:[~2023-12-13 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 21:57 [PATCH] toaster: Added dataTables library to include sorting and pagination for table element Marlon Rodriguez Garcia
2023-12-13 13:11 ` Richard Purdie [this message]
2023-12-13 15:00   ` [bitbake-devel] [Toaster] " Marlon Rodriguez Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4075d7dacd13a9c974c227c987ac112093204d7.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=marlon.rodriguez-garcia@savoirfairelinux.com \
    --cc=toaster@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).