From: Alex Stewart <alex.stewart@ni.com>
To: Petar Koynov <petar.koynov@ni.com>
Cc: opkg-devel@googlegroups.com, yocto@lists.yoctoproject.org
Subject: Re: [opkg-utils PATCH V2] opkg-feed: Fix adding feeds with same name as architecture
Date: Mon, 22 May 2023 13:35:13 -0500 [thread overview]
Message-ID: <003e7b9a-5633-1716-44cd-99353fb696e7@ni.com> (raw)
In-Reply-To: <20230522174815.1110222-1-petar.koynov@ni.com>
ACK; looks good to me.
I'll pull this tomorrow, if there are no objections.
On 5/22/23 12:48, Petar Koynov wrote:
> Attempting to add feeds with some special names that match
> architecture names was returning an error:
> "5 The named feed already exists"
> Make sourceTypePattern in createFeedLineRegex only match
> feed configuration lines src or dist
>
> Signed-off-by: Petar Koynov <petar.koynov@ni.com>
> ---
> opkg-feed | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opkg-feed b/opkg-feed
> index 25ef879..36d4463 100755
> --- a/opkg-feed
> +++ b/opkg-feed
> @@ -171,7 +171,7 @@ createFeedLineRegex()
> # 1 = full source type with any quotes
> # 2 = source type without quotes if quoted
> # 3 = source type if unquoted
> - sourceTypePattern='("([^"]*)"|(\S+))\s+';
> + sourceTypePattern='("([^"](src|dist)(/gz)?)"|(src|dist)(/gz)?)\s+';
>
> # Feed name capture groups (4, 5, 6)
> # 4 = full feed name with any quotes
--
Alex Stewart
Software Engineer - NI Real-Time OS
NI (National Instruments)
alex.stewart@ni.com
next prev parent reply other threads:[~2023-05-22 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 17:48 [opkg-utils PATCH V2] opkg-feed: Fix adding feeds with same name as architecture Petar Koynov
2023-05-22 18:35 ` Alex Stewart [this message]
2023-05-24 16:01 ` Alex Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003e7b9a-5633-1716-44cd-99353fb696e7@ni.com \
--to=alex.stewart@ni.com \
--cc=opkg-devel@googlegroups.com \
--cc=petar.koynov@ni.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).