All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasily Gorbik <gor@linux.ibm.com>
To: Vineeth Vijayan <vneethv@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] s390/cio: make sch->lock a spinlock (is a pointer)
Date: Tue, 7 Nov 2023 22:14:26 +0100	[thread overview]
Message-ID: <your-ad-here.call-01699391666-ext-4064@work.hours> (raw)
In-Reply-To: <b54e18a9-582d-3619-773e-695dcf19eaad@linux.ibm.com>

On Tue, Nov 07, 2023 at 01:39:00PM +0100, Vineeth Vijayan wrote:
> 
> 
> On 11/1/23 12:57, Halil Pasic wrote:
> > The lock member of struct subchannel used to be a spinlock, but became
> > a pointer to a spinlock with commit 2ec2298412e1 ("[S390] subchannel
> > lock conversion."). This might have been justified back then, but with
> > the current state of affairs, there is no reason to manage a separate
> > spinlock object.
> > 
> > Let's simplify things and pull the spinlock back into struct subchannel.
> > 
> > Signed-off-by: Halil Pasic<pasic@linux.ibm.com>
> > ---
> > I know it is a lot of churn, but I do believe in the end it does make
> > the code more maintainable.
> 
> You are right. Makes the code easy to read and a bit less complex.
> Looks good to me. Thanks
> 
> Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>

Applied, thank you.

      reply	other threads:[~2023-11-07 21:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 11:57 [PATCH 1/1] s390/cio: make sch->lock a spinlock (is a pointer) Halil Pasic
2023-11-07 12:39 ` Vineeth Vijayan
2023-11-07 21:14   ` Vasily Gorbik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=your-ad-here.call-01699391666-ext-4064@work.hours \
    --to=gor@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=farman@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=oberpar@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=vneethv@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.