From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Zheyu Ma <zheyuma97@gmail.com>
Subject: Re: [PATCHv2] myrb: fixup null pointer access on myrb_cleanup()
Date: Mon, 23 May 2022 23:24:39 -0400 [thread overview]
Message-ID: <yq17d6bhatr.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220523120244.99515-1-hare@suse.de> (Hannes Reinecke's message of "Mon, 23 May 2022 14:02:44 +0200")
Hannes,
> When myrb_probe() fails the callback might not be set, so we need
> to validate the 'disable_intr' callback in myrb_cleanup() to not
> cause a null pointer exception. And while at it do not call
> myrb_cleanup() if we cannot enable the PCI device at all.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-05-24 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 12:02 [PATCHv2] myrb: fixup null pointer access on myrb_cleanup() Hannes Reinecke
2022-05-23 12:52 ` Zheyu Ma
2022-05-24 3:24 ` Martin K. Petersen [this message]
2022-05-24 18:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17d6bhatr.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.