All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Laurence Oberman <loberman@redhat.com>
Cc: QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org,
	djeffery@redhat.com, jpittman@redhat.com, cdupuis1@gmail.com
Subject: Re: [PATCH] bnx2fc: timeout calculation invalid for bnx2fc_eh_abort()
Date: Tue, 19 Nov 2019 22:32:11 -0500	[thread overview]
Message-ID: <yq18sobfcjo.fsf@oracle.com> (raw)
In-Reply-To: <1574178394-16635-1-git-send-email-loberman@redhat.com> (Laurence Oberman's message of "Tue, 19 Nov 2019 10:46:34 -0500")


Laurence,

> In the bnx2fc_eh_abort() function there is a calculation for
> wait_for_completion that uses a HZ multiplier.  This is incorrect, it
> scales the timeout by 1000 seconds instead of converting the ms value
> to jiffies.  Therefore change the calculation.

Applied to 5.5/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

      parent reply	other threads:[~2019-11-20  3:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 15:46 [PATCH] bnx2fc: timeout calculation invalid for bnx2fc_eh_abort() Laurence Oberman
2019-11-20  3:14 ` cdupuis1
2019-11-20  3:32 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq18sobfcjo.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=cdupuis1@gmail.com \
    --cc=djeffery@redhat.com \
    --cc=jpittman@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.