From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Martin Wilck <Martin.Wilck@suse.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.de>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Ales Novak <alnovak@suse.cz>
Subject: Re: [PATCH] scsi: scsi_dh_rdac: zero cdb in send_mode_select()
Date: Tue, 10 Sep 2019 21:31:40 -0400 [thread overview]
Message-ID: <yq1blvrfwjn.fsf@oracle.com> (raw)
In-Reply-To: <20190904155205.1666-1-martin.wilck@suse.com> (Martin Wilck's message of "Wed, 4 Sep 2019 15:52:29 +0000")
Martin,
> cdb in send_mode_select() is not zeroed and is only partially filled
> in rdac_failover_get(), which leads to some random data getting to the
> device. Users have reported storage responding to such commands with
> INVALID FIELD IN CDB. Code before commit 327825574132 was not
> affected, as it called blk_rq_set_block_pc().
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-09-11 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 15:52 [PATCH] scsi: scsi_dh_rdac: zero cdb in send_mode_select() Martin Wilck
2019-09-04 23:53 ` Seymour, Shane M
2019-09-11 1:31 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blvrfwjn.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Martin.Wilck@suse.com \
--cc=alnovak@suse.cz \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.