From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
krisman@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH 3/3] [RESEND] ipr: Fix invalid array indexing for HRRQ
Date: Thu, 16 Jul 2015 22:00:32 -0400 [thread overview]
Message-ID: <yq1d1zrmtkv.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <201507141641.t6EGfXmA021616@d01av05.pok.ibm.com> (Brian King's message of "Tue, 14 Jul 2015 11:41:33 -0500")
>>>>> "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:
Brian> Fixes another signed / unsigned array indexing bug in the ipr
Brian> driver. Currently, when hrrq_index wraps, it becomes a negative
Brian> number. We do the modulo, but still have a negative number, so we
Brian> end up indexing backwards in the array. Given where the hrrq
Brian> array is located in memory, we probably won't actually reference
Brian> memory we don't own, but nonetheless ipr is still looking at data
Brian> within struct ipr_ioa_cfg and interpreting it as struct
Brian> ipr_hrr_queue data, so bad things could certainly happen.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2015-07-17 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 16:41 [PATCH 3/3] [RESEND] ipr: Fix invalid array indexing for HRRQ Brian King
2015-07-17 2:00 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d1zrmtkv.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.