From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Martin Wilck <martin.wilck@suse.com>,
Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH V2] scsi: core: reallocate scsi device's budget map if default queue depth is changed
Date: Mon, 31 Jan 2022 12:56:27 -0500 [thread overview]
Message-ID: <yq1ee4naiwv.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220127153733.409132-1-ming.lei@redhat.com> (Ming Lei's message of "Thu, 27 Jan 2022 23:37:33 +0800")
Ming,
> Martin reported that sdev->queue_depth can often be changed in
> ->slave_configure(), and now we uses ->cmd_per_lun as initial queue
> depth for setting up sdev->budget_map. And some extreme ->cmd_per_lun
> or ->can_queue won't be used at default actually, if they are used to
> allocate sdev->budget_map, huge memory may be consumed just because of
> bad ->cmd_per_lun.
Applied to 5.17/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-01-31 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:37 [PATCH V2] scsi: core: reallocate scsi device's budget map if default queue depth is changed Ming Lei
2022-01-27 17:19 ` Bart Van Assche
2022-01-31 17:56 ` Martin K. Petersen [this message]
2022-02-01 2:03 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ee4naiwv.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.wilck@suse.com \
--cc=ming.lei@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.