From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-scsi@vger.kernel.org, patches@lists.linux.dev,
Igor Zhbanov <i.zhbanov@omprussia.ru>,
"Juergen E. Fischer" <fischer@norbit.de>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: aha152x: fix aha152x_setup() __setup handler return value
Date: Sun, 27 Feb 2022 21:40:03 -0500 [thread overview]
Message-ID: <yq1h78j7lz7.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220223000623.5920-1-rdunlap@infradead.org> (Randy Dunlap's message of "Tue, 22 Feb 2022 16:06:23 -0800")
Randy,
> __setup() handlers should return 1 if the command line option is handled
> and 0 if not (or maybe never return 0; doing so just pollutes init's
> environment with strings that are not init arguments/parameters).
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-02-28 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 0:06 [PATCH] scsi: aha152x: fix aha152x_setup() __setup handler return value Randy Dunlap
2022-02-28 2:40 ` Martin K. Petersen [this message]
2022-03-02 5:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h78j7lz7.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=fischer@norbit.de \
--cc=i.zhbanov@omprussia.ru \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.