From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tony Asleson <tasleson@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
pmladek@suse.com, David Lehman <dlehman@redhat.com>,
sergey.senozhatsky@gmail.com, jbaron@akamai.com,
James.Bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, rafael@kernel.org,
martin.petersen@oracle.com, kbusch@kernel.org, axboe@fb.com,
sagi@grimberg.me, akpm@linux-foundation.org,
orson.zhai@unisoc.com, viro@zeniv.linux.org.uk
Subject: Re: [v5 01/12] struct device: Add function callback durable_name
Date: Thu, 08 Oct 2020 16:49:17 -0400 [thread overview]
Message-ID: <yq1tuv41m8u.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20201008044849.GA163423@kroah.com> (Greg Kroah-Hartman's message of "Thu, 8 Oct 2020 06:48:49 +0200")
Greg,
>> > What text is changing? The format of of the prefix of dev_*() is well
>> > known and has been stable for 15+ years now, right? What is difficult
>> > in parsing it?
>>
>> Many of the storage layer messages are using printk, not dev_printk.
>
> Ok, then stop right there. Fix that up. Don't try to route around the
> standard way of displaying log messages by creating a totally different
> way of doing things.
Couldn't agree more!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-08 20:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:19 [v5 00/12] Add persistent durable identifier to storage log messages Tony Asleson
2020-09-25 16:19 ` [v5 01/12] struct device: Add function callback durable_name Tony Asleson
2020-09-26 9:08 ` Sergei Shtylyov
2020-09-27 14:22 ` Tony Asleson
2020-09-27 16:15 ` Sergei Shtylyov
2020-09-29 17:51 ` Christoph Hellwig
2020-09-29 18:04 ` Greg Kroah-Hartman
2020-09-29 22:04 ` Tony Asleson
2020-09-30 7:38 ` Greg Kroah-Hartman
2020-09-30 7:40 ` Greg Kroah-Hartman
2020-09-30 14:35 ` Tony Asleson
2020-10-01 11:48 ` Greg Kroah-Hartman
2020-10-07 20:10 ` Tony Asleson
2020-10-08 4:48 ` Greg Kroah-Hartman
2020-10-08 20:49 ` Martin K. Petersen [this message]
2020-10-08 5:54 ` Hannes Reinecke
2020-10-08 6:22 ` Finn Thain
2020-09-25 16:19 ` [v5 02/12] create_syslog_header: Add durable name Tony Asleson
2020-09-25 16:19 ` [v5 03/12] dev_vprintk_emit: Increase hdr size Tony Asleson
2020-09-25 16:19 ` [v5 04/12] scsi: Add durable_name for dev_printk Tony Asleson
2020-09-25 16:19 ` [v5 05/12] nvme: Add durable name " Tony Asleson
2020-09-25 16:19 ` [v5 06/12] libata: Add ata_scsi_durable_name Tony Asleson
2020-09-25 16:19 ` [v5 07/12] libata: Make ata_scsi_durable_name static Tony Asleson
2020-09-26 8:40 ` Sergei Shtylyov
2020-09-26 14:17 ` Tony Asleson
2020-09-26 15:57 ` James Bottomley
2020-09-28 20:35 ` Tony Asleson
2020-09-25 16:19 ` [v5 08/12] Add durable_name_printk Tony Asleson
2020-09-26 23:53 ` Randy Dunlap
2020-09-28 15:52 ` Tony Asleson
2020-09-28 17:32 ` Randy Dunlap
2020-09-25 16:19 ` [v5 09/12] libata: use durable_name_printk Tony Asleson
2020-09-25 16:19 ` [v5 10/12] Add durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 11/12] print_req_error: Use durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 12/12] buffer_io_error: " Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tuv41m8u.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=dlehman@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbaron@akamai.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=orson.zhai@unisoc.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=sergey.senozhatsky@gmail.com \
--cc=tasleson@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.