From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices
Date: Mon, 04 Jan 2016 20:58:43 -0500 [thread overview]
Message-ID: <yq1twmslrcc.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1449583704-32400-1-git-send-email-emilne@redhat.com> (Ewan D. Milne's message of "Tue, 8 Dec 2015 09:08:22 -0500")
>>>>> "Ewan" == Ewan D Milne <emilne@redhat.com> writes:
Ewan> The klist traversal used by the reading of /proc/scsi/scsi is not
Ewan> interlocked against device removal. It takes a reference on the
Ewan> containing object, but this does not prevent the device from being
Ewan> removed from the list. Thus, we get errors and eventually panic,
Ewan> as shown in the traces below. Fix this by keeping a klist
Ewan> iterator in the seq_file private data.
Applied to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-01-05 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:08 [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices Ewan D. Milne
2015-12-08 14:08 ` [PATCH RFC 1/2] drivers/base: add bus_device_iter_init, bus_device_iter_next, bus_device_iter_exit Ewan D. Milne
2015-12-18 9:22 ` Hannes Reinecke
2015-12-08 14:08 ` [PATCH RFC 2/2] scsi_proc: Change /proc/scsi/scsi to use bus device iterator Ewan D. Milne
2015-12-18 9:23 ` Hannes Reinecke
2015-12-18 9:22 ` [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices Hannes Reinecke
2016-01-05 1:58 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1twmslrcc.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.