From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: wenxiong <wenxiong@imap.linux.ibm.com>
Cc: jejb@linux.ibm.com, wenxiong@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org, brking@linux.vnet.ibm.com,
martin.petersen@oracle.com, wenxiong@us.ibm.com
Subject: Re: [PATCH V2 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1"
Date: Mon, 13 Sep 2021 17:13:37 -0400 [thread overview]
Message-ID: <yq1v934yysg.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <f754c31d348465f96ad4cd7541a86168@imap.linux.ibm.com> (wenxiong@imap.linux.ibm.com's message of "Mon, 13 Sep 2021 15:51:50 -0500")
Hi Wendy!
> I am going to re-do V2 patch with retries. Is it ok?
We probably do not want to blindly retry on all errors. We should only
retry in cases where the command has the potential to subsequently
succeed. Hence the request to retry "transient errors" in my previous
mail.
Classifying which errors should result in a retry is the important
piece. And for that we need to know exactly what error your tray is
returning.
I also suggest you have a look at scsi_check_sense().
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-13 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 19:04 [PATCH V2 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1" wenxiong
2021-09-11 0:23 ` kernel test robot
2021-09-11 0:23 ` kernel test robot
2021-09-11 0:44 ` James Bottomley
[not found] ` <f754c31d348465f96ad4cd7541a86168@imap.linux.ibm.com>
2021-09-13 21:13 ` Martin K. Petersen [this message]
[not found] ` <OF31B21169.103CCF65-ON0025874F.00776468-0025874F.00778F79@ibm.com>
2021-09-14 15:27 ` Martin K. Petersen
2021-09-14 15:50 ` James Bottomley
2021-09-14 18:13 ` Martin K. Petersen
2021-09-14 15:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v934yysg.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@linux.vnet.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@imap.linux.ibm.com \
--cc=wenxiong@linux.vnet.ibm.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.