All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Andrew Lutomirski <luto@mit.edu>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Dave Airlie <airlied@redhat.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing
Date: Mon, 25 Jul 2011 10:55:05 -0700	[thread overview]
Message-ID: <yun8vrmutxi.fsf@aiko.keithp.com> (raw)
In-Reply-To: <CAObL_7F+xiQrsdJzaSR3nnWm-=ZiHZf8dE+Q3yv+TQC7PUYjEA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Mon, 25 Jul 2011 13:40:58 -0400, Andrew Lutomirski <luto@mit.edu> wrote:

> Will test tonight.

Thanks. 

> It looks like there is a lot of hotplug activity when 'xset dpms force
> off' gets run.  (That's not a typo.  I do mean "off," not "on."

Yup, that's what I've seen as well -- do a mode set to turn stuff off
and you get spammed with hotplug events.

> See attached trace.  perf rocks, even over ssh :)

Wow. You're nested about three deep in the mode setting code due to
overlapping hotplug events. What could possibly go wrong?

Makes me optimistic that a bit of locking will help a lot here.

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2011-07-25 17:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-25 17:10 [PATCH] drm/i915: Hold struct_mutex during hotplug processing Keith Packard
2011-07-25 17:37 ` [Intel-gfx] " Jesse Barnes
2011-07-25 17:40   ` Andrew Lutomirski
2011-07-25 17:55     ` Keith Packard [this message]
2011-07-26  2:52   ` Andrew Lutomirski
2011-07-26  2:52     ` Andrew Lutomirski
2011-07-26  5:54     ` Keith Packard
2011-07-26  5:54       ` Keith Packard
2011-07-26 12:35       ` [Intel-gfx] " Andrew Lutomirski
2011-07-26 12:35         ` Andrew Lutomirski
2011-07-26  7:24 ` Daniel Vetter
2011-07-26 15:23   ` Keith Packard
2011-07-26 19:12     ` Jesse Barnes
2011-07-26 19:12       ` Jesse Barnes
2011-07-27  9:21       ` [Intel-gfx] " Keith Packard
2011-07-27  9:21         ` Keith Packard
2011-07-27 16:03         ` [Intel-gfx] " Jesse Barnes
2011-07-28 22:50           ` Keith Packard
2011-07-29 10:25             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yun8vrmutxi.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.