From: Keith Packard <keithp@keithp.com>
To: Andy Lutomirski <luto@MIT.EDU>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Aggressively disable vblanks
Date: Mon, 20 Dec 2010 19:23:40 -0800 [thread overview]
Message-ID: <yunfwtrrepv.fsf@aiko.keithp.com> (raw)
In-Reply-To: <372cb262d2d49bd796fa6636d04d431b50a14f69.1292869603.git.luto@mit.edu>
[-- Attachment #1.1: Type: text/plain, Size: 626 bytes --]
On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski <luto@MIT.EDU> wrote:
> Enabling and disabling the vblank interrupt (on devices that
> support it) is cheap. So disable it quickly after each
> interrupt.
So, the concern (and reason for the original design) was that you might
lose count of vblank interrupts as vblanks are counted differently while
off than while on. If vblank interrupts get enabled near the interrupt
time, is it possible that you'll end up off by one somehow?
Leaving them enabled for 'a while' was supposed to reduce the impact of
this potential error.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-12-21 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 19:00 [PATCH] drm: Aggressively disable vblanks Andy Lutomirski
2010-12-21 3:23 ` Keith Packard [this message]
2010-12-21 3:34 ` [Intel-gfx] " Andrew Lutomirski
2010-12-21 3:47 ` Keith Packard
2010-12-21 3:55 ` Andrew Lutomirski
2010-12-21 4:03 ` Jesse Barnes
[not found] <mailman.28.1292917668.19577.dri-devel@lists.freedesktop.org>
2010-12-22 4:36 ` [Intel-gfx] " Mario Kleiner
2010-12-22 17:23 ` Jesse Barnes
2010-12-22 21:06 ` Mario Kleiner
2010-12-26 14:53 ` Andrew Lutomirski
2010-12-27 10:52 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunfwtrrepv.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=luto@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.