From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/8] drm/i915: Flush the plane enable using the DSPCNTR latch
Date: Fri, 18 Mar 2011 08:09:07 -0700 [thread overview]
Message-ID: <yunmxkszcrw.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1300435330-15934-4-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 471 bytes --]
This comment is misleading -- the patch replaces a call to
intel_wait_for_vblank with a call to intel_flush_display_plane.
From my reading of the docs, enable requires two actions:
1) DSPACNTR with enable going from 0->1
2) wait for vblank
At disable, three actions are required:
1) DSPACNTR with enable going from 1->0
2) DSPASURF(965+)/DSPAADDR(otherwise) write to trigger the register updates
3) wait for vblank
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-03-18 15:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 8:02 Patch queue for -fixes Chris Wilson
2011-03-18 8:02 ` [PATCH 1/8] drm/i915: Remove surplus POSTING_READs before wait_for_vblank Chris Wilson
2011-03-18 14:42 ` Keith Packard
2011-03-18 16:23 ` Jesse Barnes
2011-03-18 8:02 ` [PATCH 2/8] drm/i915: skip redundant operations whilst enabling pipes and planes Chris Wilson
2011-03-18 14:46 ` Keith Packard
2011-03-18 16:25 ` Jesse Barnes
2011-03-18 17:37 ` Chris Wilson
2011-03-18 17:41 ` Jesse Barnes
2011-03-18 8:02 ` [PATCH 3/8] drm/i915: Flush the plane enable using the DSPCNTR latch Chris Wilson
2011-03-18 15:09 ` Keith Packard [this message]
2011-03-18 16:26 ` Jesse Barnes
2011-03-18 17:42 ` Chris Wilson
2011-03-18 8:02 ` [PATCH 4/8] drm/i915: Only wait for vblank after pipe enabling on gen2 Chris Wilson
2011-03-18 15:10 ` Keith Packard
2011-03-18 16:27 ` Jesse Barnes
2011-03-18 8:02 ` [PATCH 5/8] drm/i915: Prevent racy removal of request from client list Chris Wilson
2011-03-18 8:02 ` [PATCH 6/8] drm: Fix use-after-free in drm_gem_vm_close() Chris Wilson
2011-03-18 15:15 ` [Intel-gfx] " Keith Packard
2011-03-18 8:02 ` [PATCH 7/8] drm/i915: Re-enable self-refresh Chris Wilson
2011-03-18 15:22 ` Keith Packard
2011-03-18 17:48 ` Chris Wilson
2011-03-18 18:12 ` Eric Anholt
2011-03-18 19:08 ` Chris Wilson
2011-03-18 8:02 ` [PATCH 8/8] drm/i915: Fix tiling corruption from pipelined fencing Chris Wilson
2011-03-19 22:17 ` Daniel Vetter
2011-03-19 22:25 ` Chris Wilson
2011-03-19 23:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunmxkszcrw.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.