From: Keith Packard <keithp@keithp.com>
To: Ben Widawsky <ben@bwidawsk.net>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: reference counted forcewake
Date: Tue, 19 Apr 2011 08:12:16 -0700 [thread overview]
Message-ID: <yunoc42gtrj.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20110418173143.GA10406@bwgnt.jf.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 276 bytes --]
On Mon, 18 Apr 2011 10:31:43 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> gen6_gt_force_wake_get()
> while(foo)
> i915_read32_awake()
> gen6_gt_force_wake_put()
Uh. Anything looping on registers might not want to hold the lock...
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-04-19 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 18:13 forcewake v4 (now with spinlock) Ben Widawsky
2011-04-14 18:13 ` (no subject) Ben Widawsky
2011-04-14 18:13 ` [PATCH 1/3] drm/i915: proper use of forcewake Ben Widawsky
2011-04-14 18:13 ` [PATCH 2/3] drm/i915: reference counted forcewake Ben Widawsky
2011-04-14 19:12 ` Ben Widawsky
2011-04-16 6:52 ` Chris Wilson
2011-04-18 17:31 ` Ben Widawsky
2011-04-19 5:48 ` Chris Wilson
2011-04-19 15:12 ` Keith Packard [this message]
2011-04-14 18:13 ` [PATCH 3/3] drm/i915: userspace interface to the forcewake Ben Widawsky
2011-04-14 19:13 ` Ben Widawsky
2011-04-14 19:56 ` Paul Menzel
2011-04-16 7:05 ` Chris Wilson
2011-04-17 16:55 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunoc42gtrj.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.