Re: [PATCH D 01/11] OMAP: Add clk_get_parent() for OMAP2/3

From: "Måns Rullgård" <mans@mansr.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Paul Walmsley" <paul@pwsan.com>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	"Måns Rullgård" <mans@mansr.com>,
	"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH D 01/11] OMAP: Add clk_get_parent() for OMAP2/3
Date: Sat, 31 Jan 2009 15:07:06 +0000	[thread overview]
Message-ID: <yw1xhc3f5xb9.fsf@thrashbarg.mansr.com> (raw)
In-Reply-To: <20090131142344.GM1394@n2100.arm.linux.org.uk> (Russell King's message of "Sat, 31 Jan 2009 14:23:44 +0000")

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> On Thu, Jan 29, 2009 at 11:29:31PM -0700, Paul Walmsley wrote:
>> On Thu, 29 Jan 2009, Russell King - ARM Linux wrote:
>> 
>> > On Wed, Jan 28, 2009 at 12:18:16PM -0700, Paul Walmsley wrote:
>> > > From: Mans Rullgard <mans@mansr.com>
>> > > 
>> > > This makes clk_get_parent() work on OMAP2/3.
>> > 
>> > This is clearly something that the generic code should be doing.
>> > It's not something specific to OMAP2/3.  Please move it to
>> > arch/arm/plat-omap/clock.c
>> 
>> Done; revised patch below.
>
> Great, thanks.  However, I'd forgotten that one of my patches completely
> removes clk_get_parent() since it's unused by any code in OMAP at present.
>
> What was the reasoning behind making this work?

It is needed for the omapfb/dss driver to set an optimal rate for
dpll4_m4_ck.

-- 
Måns Rullgård
mans@mansr.com