Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled

From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
	 "Chang S. Bae" <chang.seok.bae@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	 "Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Weihong Zhang <weihong.zhang@intel.com>,
	 Binbin Wu <binbin.wu@linux.intel.com>,
	angquan yu <angquan21@gmail.com>,
	kernel@collabora.com,  linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled
Date: Mon, 11 Mar 2024 14:39:40 +0200	[thread overview]
Message-ID: <zictuia2d66mhb4hdr436quvkyef5a433pnem2yoxgybhbrki5@54vv3sk4sxkl> (raw)
In-Reply-To: <20240307183730.2858264-1-usama.anjum@collabora.com>

On Thu, Mar 07, 2024 at 11:37:22PM +0500, Muhammad Usama Anjum wrote:
> diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
> index 215b8150b7cca..c0f016f45ee17 100644
> --- a/tools/testing/selftests/x86/lam.c
> +++ b/tools/testing/selftests/x86/lam.c
> @@ -1183,7 +1183,7 @@ int main(int argc, char **argv)
>  
>  	if (!cpu_has_lam()) {
>  		ksft_print_msg("Unsupported LAM feature!\n");
> -		return -1;
> +		return KSFT_SKIP;
>  	}
>  
>  	while ((c = getopt(argc, argv, "ht:")) != -1) {

Looks good to me:

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov