From: Dan Murphy <dmurphy@ti.com>
To: linux-kernel@vger.kernel.org, mkl@pengutronix.de,
linux-can@vger.kernel.org, wg@grandegger.com,
sriram.dash@samsung.com
Cc: davem@davemloft.net, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH linux-master 3/3] can: m_can: Remove unused clock function from the framework
Date: Fri, 31 Jan 2020 12:34:33 -0600 [thread overview]
Message-ID: <20200131183433.11041-4-dmurphy@ti.com> (raw)
In-Reply-To: <20200131183433.11041-1-dmurphy@ti.com>
Remove the unused clock function from the framework as the clock
discovery, initilaization and management are all within the registrars
code.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/can/m_can/m_can.c | 16 ----------------
drivers/net/can/m_can/m_can.h | 3 ---
2 files changed, 19 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..5794be1ef3ef 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1751,22 +1751,6 @@ void m_can_init_ram(struct m_can_classdev *cdev)
}
EXPORT_SYMBOL_GPL(m_can_init_ram);
-int m_can_class_get_clocks(struct m_can_classdev *m_can_dev)
-{
- int ret = 0;
-
- m_can_dev->hclk = devm_clk_get(m_can_dev->dev, "hclk");
- m_can_dev->cclk = devm_clk_get(m_can_dev->dev, "cclk");
-
- if (IS_ERR(m_can_dev->cclk)) {
- dev_err(m_can_dev->dev, "no clock found\n");
- ret = -ENODEV;
- }
-
- return ret;
-}
-EXPORT_SYMBOL_GPL(m_can_class_get_clocks);
-
struct m_can_classdev *m_can_class_allocate_dev(struct device *dev)
{
struct m_can_classdev *class_dev = NULL;
diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h
index 49f42b50627a..c20a716b14cc 100644
--- a/drivers/net/can/m_can/m_can.h
+++ b/drivers/net/can/m_can/m_can.h
@@ -74,8 +74,6 @@ struct m_can_classdev {
struct napi_struct napi;
struct net_device *net;
struct device *dev;
- struct clk *hclk;
- struct clk *cclk;
struct workqueue_struct *tx_wq;
struct work_struct tx_work;
@@ -101,7 +99,6 @@ struct m_can_classdev {
struct m_can_classdev *m_can_class_allocate_dev(struct device *dev);
int m_can_class_register(struct m_can_classdev *cdev);
void m_can_class_unregister(struct m_can_classdev *cdev);
-int m_can_class_get_clocks(struct m_can_classdev *cdev);
void m_can_init_ram(struct m_can_classdev *priv);
void m_can_config_endisable(struct m_can_classdev *priv, bool enable);
--
2.25.0
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: <linux-kernel@vger.kernel.org>, <mkl@pengutronix.de>,
<linux-can@vger.kernel.org>, <wg@grandegger.com>,
<sriram.dash@samsung.com>
Cc: <davem@davemloft.net>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH linux-master 3/3] can: m_can: Remove unused clock function from the framework
Date: Fri, 31 Jan 2020 12:34:33 -0600 [thread overview]
Message-ID: <20200131183433.11041-4-dmurphy@ti.com> (raw)
In-Reply-To: <20200131183433.11041-1-dmurphy@ti.com>
Remove the unused clock function from the framework as the clock
discovery, initilaization and management are all within the registrars
code.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/can/m_can/m_can.c | 16 ----------------
drivers/net/can/m_can/m_can.h | 3 ---
2 files changed, 19 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..5794be1ef3ef 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1751,22 +1751,6 @@ void m_can_init_ram(struct m_can_classdev *cdev)
}
EXPORT_SYMBOL_GPL(m_can_init_ram);
-int m_can_class_get_clocks(struct m_can_classdev *m_can_dev)
-{
- int ret = 0;
-
- m_can_dev->hclk = devm_clk_get(m_can_dev->dev, "hclk");
- m_can_dev->cclk = devm_clk_get(m_can_dev->dev, "cclk");
-
- if (IS_ERR(m_can_dev->cclk)) {
- dev_err(m_can_dev->dev, "no clock found\n");
- ret = -ENODEV;
- }
-
- return ret;
-}
-EXPORT_SYMBOL_GPL(m_can_class_get_clocks);
-
struct m_can_classdev *m_can_class_allocate_dev(struct device *dev)
{
struct m_can_classdev *class_dev = NULL;
diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h
index 49f42b50627a..c20a716b14cc 100644
--- a/drivers/net/can/m_can/m_can.h
+++ b/drivers/net/can/m_can/m_can.h
@@ -74,8 +74,6 @@ struct m_can_classdev {
struct napi_struct napi;
struct net_device *net;
struct device *dev;
- struct clk *hclk;
- struct clk *cclk;
struct workqueue_struct *tx_wq;
struct work_struct tx_work;
@@ -101,7 +99,6 @@ struct m_can_classdev {
struct m_can_classdev *m_can_class_allocate_dev(struct device *dev);
int m_can_class_register(struct m_can_classdev *cdev);
void m_can_class_unregister(struct m_can_classdev *cdev);
-int m_can_class_get_clocks(struct m_can_classdev *cdev);
void m_can_init_ram(struct m_can_classdev *priv);
void m_can_config_endisable(struct m_can_classdev *priv, bool enable);
--
2.25.0
next prev parent reply other threads:[~2020-01-31 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 18:34 [PATCH linux-master 0/3] MCAN updates for clock discovery Dan Murphy
2020-01-31 18:34 ` Dan Murphy
2020-01-31 18:34 ` [PATCH linux-master 1/3] can: tcan4x5x: Move clock init to TCAN driver Dan Murphy
2020-01-31 18:34 ` Dan Murphy
2020-02-21 14:25 ` Dan Murphy
2020-02-21 14:25 ` Dan Murphy
2020-02-21 14:43 ` Marc Kleine-Budde
2020-02-25 17:45 ` Dan Murphy
2020-02-25 17:45 ` Dan Murphy
2020-02-25 20:48 ` Marc Kleine-Budde
2020-01-31 18:34 ` [PATCH linux-master 2/3] can: m_can_platform: Move clock discovery and init to platform Dan Murphy
2020-01-31 18:34 ` Dan Murphy
2020-01-31 18:34 ` Dan Murphy [this message]
2020-01-31 18:34 ` [PATCH linux-master 3/3] can: m_can: Remove unused clock function from the framework Dan Murphy
2020-02-19 13:07 ` [PATCH linux-master 0/3] MCAN updates for clock discovery Dan Murphy
2020-02-19 13:07 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131183433.11041-4-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.