Re: [PATCH 3/7] dt-bindings: phy: cadence-torrent: Add binding for refclk driver

From: Rob Herring <robh@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>, Nishanth Menon <nm@ti.com>,
	Swapnil Jakhade <sjakhade@cadence.com>,
	Peter Rosin <peda@axentia.se>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] dt-bindings: phy: cadence-torrent: Add binding for refclk driver
Date: Thu, 7 Jan 2021 20:01:01 -0700	[thread overview]
Message-ID: <20210108030101.GA1792772@robh.at.kernel.org> (raw)
In-Reply-To: <20201224114250.1083-4-kishon@ti.com>

On Thu, Dec 24, 2020 at 05:12:46PM +0530, Kishon Vijay Abraham I wrote:
> Add binding for refclk driver used to route the refclk out of the
> SERDES.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../bindings/phy/phy-cadence-torrent.yaml       | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index e266ade53d87..d3b96afd514c 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -125,6 +125,23 @@ patternProperties:
>  
>      additionalProperties: false
>  
> +  "^refclk-driver":
> +    type: object
> +    description: |
> +      Driver to route the reference clock out of the SERDES.
> +    properties:
> +      clocks:
> +        maxItems: 1
> +        description: Phandle to clock nodes representing the input to the
> +          refclk driver.
> +
> +      "#clock-cells":
> +        const: 0

Just move to the parent node.

> +
> +    required:
> +      - clocks
> +      - "#clock-cells"
> +
>  required:
>    - compatible
>    - "#address-cells"
> -- 
> 2.17.1
> 