All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: kernel test robot <lkp@intel.com>, linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection
Date: Mon, 08 Nov 2021 12:00:17 +0000	[thread overview]
Message-ID: <878rxyeu26.mognet@arm.com> (raw)
In-Reply-To: <202111061341.QdauxAuH-lkp@intel.com>

On 06/11/21 13:05, kernel test robot wrote:
>    kernel/sched/core.c:3439:6: error: no previous prototype for function 'sched_set_stop_task' [-Werror,-Wmissing-prototypes]
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>         ^
>    kernel/sched/core.c:3439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>    ^
>    static
>>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
>            static_call_update(preempt_schedule, __preempt_schedule_func);
>            ^

Doh, I broke the

  PREEMPT_DYNAMIC
    select PREEMPT

thing - the above happens with PREEMPT_DYNAMIC && !PREEMPT. Lemme fix.

WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection
Date: Mon, 08 Nov 2021 12:00:17 +0000	[thread overview]
Message-ID: <878rxyeu26.mognet@arm.com> (raw)
In-Reply-To: <202111061341.QdauxAuH-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On 06/11/21 13:05, kernel test robot wrote:
>    kernel/sched/core.c:3439:6: error: no previous prototype for function 'sched_set_stop_task' [-Werror,-Wmissing-prototypes]
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>         ^
>    kernel/sched/core.c:3439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>    ^
>    static
>>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
>            static_call_update(preempt_schedule, __preempt_schedule_func);
>            ^

Doh, I broke the

  PREEMPT_DYNAMIC
    select PREEMPT

thing - the above happens with PREEMPT_DYNAMIC && !PREEMPT. Lemme fix.

  reply	other threads:[~2021-11-08 12:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 10:40 [PATCH] sched: Tweak default dynamic preempt mode selection Valentin Schneider
2021-11-06  4:40 ` Mike Galbraith
2021-11-08 11:17   ` Valentin Schneider
2021-11-08 12:27     ` Mike Galbraith
2021-11-08 15:21       ` Valentin Schneider
2021-11-09  5:30         ` Mike Galbraith
2021-11-09  9:52           ` Valentin Schneider
2021-11-09 11:00             ` Mike Galbraith
2021-11-09 12:19               ` Valentin Schneider
2021-11-09 13:31                 ` Mike Galbraith
2021-11-06  5:05 ` kernel test robot
2021-11-06  5:05   ` kernel test robot
2021-11-08 12:00   ` Valentin Schneider [this message]
2021-11-08 12:00     ` Valentin Schneider
2021-11-06  5:33 ` kernel test robot
2021-11-06  5:33   ` kernel test robot
2021-11-06  7:58 ` kernel test robot
2021-11-06  7:58   ` kernel test robot
2021-11-09 10:25 ` Frederic Weisbecker
2021-11-10  0:03   ` Valentin Schneider
2021-11-10  5:44     ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rxyeu26.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=frederic@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.