From: Felipe Balbi <balbi@kernel.org>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Johan Hovold <johan@kernel.org>,
Jaejoong Kim <climbbb.kim@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Roger Quadros <rogerq@ti.com>,
Manu Gautam <mgautam@codeaurora.org>,
martin.petersen@oracle.com, Bart Van Assche <bvanassche@acm.org>,
Mike Christie <mchristi@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Colin Ian King <colin.king@canonical.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
v.anuragkumar@gmail.com, Thinh Nguyen <thinhn@synopsys.com>,
Tejas Joglekar <tejas.joglekar@synopsys.com>,
Ajay Yugalkishore Pandey <APANDEY@xilinx.com>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Subject: Re: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete
Date: Wed, 05 Dec 2018 11:01:37 +0200 [thread overview]
Message-ID: <878t142vpq.fsf@linux.intel.com> (raw)
In-Reply-To: <1543662811-5194-6-git-send-email-anurag.kumar.vulisha@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Hi,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> writes:
> @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
> }
>
> switch (event->endpoint_event) {
> + case DWC3_DEPEVT_XFERCOMPLETE:
> + if (!dep->stream_capable)
> + break;
> + dep->flags &= ~DWC3_EP_TRANSFER_STARTED;
> + /* Fall Through */
instead, let's add a proper handler for this:
dwc3_gadget_endpoint_transfer_complete(dep, event);
That handler should be "self-sufficient". IOW, we shouldn't have this
fall through here. This means that the other patch where you modify
dwc3_gadget_transfer_in_progress() shouldn't be necessary, since that
event shouldn't run for stream capable endpoints.
While rewriting the patches, please rebase on my testing/next as I have
applied a few of the patches in this series.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Johan Hovold <johan@kernel.org>,
Jaejoong Kim <climbbb.kim@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Roger Quadros <rogerq@ti.com>,
Manu Gautam <mgautam@codeaurora.org>,
martin.petersen@oracle.com, Bart Van Assche <bvanassche@acm.org>,
Mike Christie <mchristi@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Colin Ian King <colin.king@canonical.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
v.anuragkumar@gmail.com, Thinh Nguyen <thinhn@synopsys.com>,
Tejas Joglekar <tejas.joglekar@synopsys.com>,
Ajay Yugalkishore Pandey <APANDEY@xilinx.com>
Subject: [v7,05/10] usb: dwc3: make controller clear transfer resources after complete
Date: Wed, 05 Dec 2018 11:01:37 +0200 [thread overview]
Message-ID: <878t142vpq.fsf@linux.intel.com> (raw)
Hi,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> writes:
> @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
> }
>
> switch (event->endpoint_event) {
> + case DWC3_DEPEVT_XFERCOMPLETE:
> + if (!dep->stream_capable)
> + break;
> + dep->flags &= ~DWC3_EP_TRANSFER_STARTED;
> + /* Fall Through */
instead, let's add a proper handler for this:
dwc3_gadget_endpoint_transfer_complete(dep, event);
That handler should be "self-sufficient". IOW, we shouldn't have this
fall through here. This means that the other patch where you modify
dwc3_gadget_transfer_in_progress() shouldn't be necessary, since that
event shouldn't run for stream capable endpoints.
While rewriting the patches, please rebase on my testing/next as I have
applied a few of the patches in this series.
next prev parent reply other threads:[~2018-12-05 9:01 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 11:13 [PATCH v7 00/10] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-02 16:36 ` [PATCH v7 01/10] " Alan Stern
2018-12-02 16:36 ` [v7,01/10] " Alan Stern
2018-12-03 10:23 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-03 10:23 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-03 14:51 ` [PATCH v7 01/10] " Alan Stern
2018-12-03 14:51 ` [v7,01/10] " Alan Stern
2018-12-03 16:05 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-03 16:05 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-03 23:08 ` [PATCH v7 01/10] " Alan Stern
2018-12-03 23:08 ` [v7,01/10] " Alan Stern
2018-12-04 16:18 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-04 16:18 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-04 16:46 ` [PATCH v7 01/10] " Alan Stern
2018-12-04 16:46 ` [v7,01/10] " Alan Stern
2018-12-04 19:07 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-04 19:07 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-04 19:28 ` [PATCH v7 01/10] " Alan Stern
2018-12-04 19:28 ` [v7,01/10] " Alan Stern
2018-12-05 15:43 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-05 15:43 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-07 6:05 ` [PATCH v7 01/10] " Felipe Balbi
2018-12-07 6:05 ` [v7,01/10] " Felipe Balbi
2018-12-07 17:09 ` [PATCH v7 01/10] " Alan Stern
2018-12-07 17:09 ` [v7,01/10] " Alan Stern
2018-12-12 15:11 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2018-12-12 15:11 ` [v7,01/10] " Anurag Kumar Vulisha
2019-01-04 14:17 ` [PATCH v7 01/10] " Anurag Kumar Vulisha
2019-01-04 14:17 ` [v7,01/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 02/10] usb: gadget: function: tcm: Add timeout for stream capable endpoints Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,02/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 03/10] usb: dwc3: gadget: handle stream events Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,03/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 04/10] usb: dwc3: update stream id in depcmd Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,04/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,05/10] " Anurag Kumar Vulisha
2018-12-05 9:01 ` Felipe Balbi [this message]
2018-12-05 9:01 ` Felipe Balbi
2018-12-05 19:05 ` [PATCH v7 05/10] " Anurag Kumar Vulisha
2018-12-05 19:05 ` [v7,05/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 06/10] usb: dwc3: don't issue no-op trb for stream capable endpoints Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,06/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 07/10] usb: dwc3: check for requests in started list " Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,07/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 08/10] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,08/10] " Anurag Kumar Vulisha
2018-12-01 11:13 ` [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,09/10] " Anurag Kumar Vulisha
2018-12-05 9:07 ` [PATCH v7 09/10] " Felipe Balbi
2018-12-05 9:07 ` [v7,09/10] " Felipe Balbi
2018-12-05 19:01 ` [PATCH v7 09/10] " Anurag Kumar Vulisha
2018-12-05 19:01 ` [v7,09/10] " Anurag Kumar Vulisha
2018-12-07 6:11 ` [PATCH v7 09/10] " Felipe Balbi
2018-12-07 6:11 ` [v7,09/10] " Felipe Balbi
2018-12-08 19:03 ` [PATCH v7 09/10] " Anurag Kumar Vulisha
2018-12-08 19:03 ` [v7,09/10] " Anurag Kumar Vulisha
2018-12-10 6:54 ` [PATCH v7 09/10] " Felipe Balbi
2018-12-10 6:54 ` [v7,09/10] " Felipe Balbi
2018-12-10 8:56 ` [PATCH v7 09/10] " Anurag Kumar Vulisha
2018-12-10 8:56 ` [v7,09/10] " Anurag Kumar Vulisha
2018-12-10 9:03 ` [PATCH v7 09/10] " Felipe Balbi
2018-12-10 9:03 ` [v7,09/10] " Felipe Balbi
2018-12-01 11:13 ` [PATCH v7 10/10] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints Anurag Kumar Vulisha
2018-12-01 11:13 ` [v7,10/10] " Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t142vpq.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=APANDEY@xilinx.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=benh@kernel.crashing.org \
--cc=bvanassche@acm.org \
--cc=climbbb.kim@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=mgautam@codeaurora.org \
--cc=rogerq@ti.com \
--cc=shuah@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tejas.joglekar@synopsys.com \
--cc=thinhn@synopsys.com \
--cc=v.anuragkumar@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.