From: Ian Rogers <irogers@google.com> To: Kim Phillips <kim.phillips@amd.com> Cc: "Arnaldo Carvalho de Melo" <acme@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Ingo Molnar" <mingo@redhat.com>, "Arnaldo Carvalho de Melo" <acme@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com>, "Jiri Olsa" <jolsa@redhat.com>, "Namhyung Kim" <namhyung@kernel.org>, "Vijay Thakkar" <vijaythakkar@me.com>, "Andi Kleen" <ak@linux.intel.com>, "John Garry" <john.garry@huawei.com>, "Kan Liang" <kan.liang@linux.intel.com>, "Yunfeng Ye" <yeyunfeng@huawei.com>, "Jin Yao" <yao.jin@linux.intel.com>, "Martin Liška" <mliska@suse.cz>, "Borislav Petkov" <bp@suse.de>, "Jon Grimm" <jon.grimm@amd.com>, "Martin Jambor" <mjambor@suse.cz>, "Michael Petlan" <mpetlan@redhat.com>, "William Cohen" <wcohen@redhat.com>, "Stephane Eranian" <eranian@google.com>, linux-perf-users <linux-perf-users@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 3/4] perf vendor events amd: Add recommended events Date: Thu, 3 Sep 2020 22:48:15 -0700 [thread overview] Message-ID: <CAP-5=fW8zLRgxXgY-CFUnU0HiiZMKhJ6b1znMxT8WeLO5Z-wZA@mail.gmail.com> (raw) In-Reply-To: <7a0b893d-8f65-6423-3818-5dafc880dca1@amd.com> On Thu, Sep 3, 2020 at 11:27 AM Kim Phillips <kim.phillips@amd.com> wrote: > > On 9/3/20 1:19 AM, Ian Rogers wrote: > > On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips <kim.phillips@amd.com> wrote: > >> The nps1_die_to_dram event may need perf stat's --metric-no-group > >> switch if the number of available data fabric counters is less > >> than the number it uses (8). > > > > These are really excellent additions! Does: > > "MetricConstraint": "NO_NMI_WATCHDOG" > > solve the grouping issue? Perhaps the MetricConstraint needs to be > > named more generically to cover this case as it seems sub-optimal to > > require the use of --metric-no-group. > > That metric uses data fabric (DFPMC/amd_df) events, not Core PMC > events, which the watchdog uses, so NO_NMI_WATCHDOG wouldn't have > an effect. The event is defined as an approximation anyway. > > I'll have to get back to you on the other items. > > Thanks for your review! NP, more nits than anything else. Acked-by: Ian Rogers <irogers@google.com> Thanks, Ian > Kim
WARNING: multiple messages have this Message-ID (diff)
From: Ian Rogers <irogers@google.com> To: Kim Phillips <kim.phillips@amd.com> Cc: "Arnaldo Carvalho de Melo" <acme@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Ingo Molnar" <mingo@redhat.com>, "Arnaldo Carvalho de Melo" <acme@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com>, "Jiri Olsa" <jolsa@redhat.com>, "Namhyung Kim" <namhyung@kernel.org>, "Vijay Thakkar" <vijaythakkar@me.com>, "Andi Kleen" <ak@linux.intel.com>, "John Garry" <john.garry@huawei.com>, "Kan Liang" <kan.liang@linux.intel.com>, "Yunfeng Ye" <yeyunfeng@huawei.com>, "Jin Yao" <yao.jin@linux.intel.com>, "Martin Liška" <mliska@suse.cz>, "Borislav Petkov" <bp@suse.de>, "Jon Grimm" <jon.grimm@amd.com>, "Martin Jambor" <mjambor@suse.cz>, "Michael Petlan" <mpetlan@redhat.com>, "William Cohen" <wcohen@redhat.com> Subject: Re: [PATCH 3/4] perf vendor events amd: Add recommended events Date: Thu, 3 Sep 2020 22:48:15 -0700 [thread overview] Message-ID: <CAP-5=fW8zLRgxXgY-CFUnU0HiiZMKhJ6b1znMxT8WeLO5Z-wZA@mail.gmail.com> (raw) In-Reply-To: <7a0b893d-8f65-6423-3818-5dafc880dca1@amd.com> On Thu, Sep 3, 2020 at 11:27 AM Kim Phillips <kim.phillips@amd.com> wrote: > > On 9/3/20 1:19 AM, Ian Rogers wrote: > > On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips <kim.phillips@amd.com> wrote: > >> The nps1_die_to_dram event may need perf stat's --metric-no-group > >> switch if the number of available data fabric counters is less > >> than the number it uses (8). > > > > These are really excellent additions! Does: > > "MetricConstraint": "NO_NMI_WATCHDOG" > > solve the grouping issue? Perhaps the MetricConstraint needs to be > > named more generically to cover this case as it seems sub-optimal to > > require the use of --metric-no-group. > > That metric uses data fabric (DFPMC/amd_df) events, not Core PMC > events, which the watchdog uses, so NO_NMI_WATCHDOG wouldn't have > an effect. The event is defined as an approximation anyway. > > I'll have to get back to you on the other items. > > Thanks for your review! NP, more nits than anything else. Acked-by: Ian Rogers <irogers@google.com> Thanks, Ian > Kim
next prev parent reply other threads:[~2020-09-04 5:48 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-01 22:09 [PATCH 1/4] perf vendor events amd: Add L2 Prefetch events for zen1 Kim Phillips 2020-09-01 22:09 ` Kim Phillips 2020-09-01 22:09 ` [PATCH 2/4] perf vendor events amd: Add ITLB Instruction Fetch Hits event " Kim Phillips 2020-09-01 22:09 ` Kim Phillips 2020-09-03 6:03 ` Ian Rogers 2020-09-03 6:03 ` Ian Rogers 2020-09-04 19:19 ` Arnaldo Carvalho de Melo 2020-09-04 19:19 ` Arnaldo Carvalho de Melo 2020-09-01 22:09 ` [PATCH 3/4] perf vendor events amd: Add recommended events Kim Phillips 2020-09-01 22:09 ` Kim Phillips 2020-09-03 6:19 ` Ian Rogers 2020-09-03 6:19 ` Ian Rogers 2020-09-03 18:26 ` Kim Phillips 2020-09-03 18:26 ` Kim Phillips 2020-09-04 5:48 ` Ian Rogers [this message] 2020-09-04 5:48 ` Ian Rogers 2020-09-04 19:28 ` Arnaldo Carvalho de Melo 2020-09-04 19:28 ` Arnaldo Carvalho de Melo 2020-09-01 22:09 ` [PATCH 4/4] perf vendor events amd: Enable Family 19h users by matching Zen2 events Kim Phillips 2020-09-01 22:09 ` Kim Phillips 2020-09-03 6:20 ` Ian Rogers 2020-09-03 6:20 ` Ian Rogers 2020-09-04 19:33 ` Arnaldo Carvalho de Melo 2020-09-04 19:33 ` Arnaldo Carvalho de Melo 2020-09-03 5:40 ` [PATCH 1/4] perf vendor events amd: Add L2 Prefetch events for zen1 Ian Rogers 2020-09-03 5:40 ` Ian Rogers 2020-09-04 19:18 ` Arnaldo Carvalho de Melo 2020-09-04 19:18 ` Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAP-5=fW8zLRgxXgY-CFUnU0HiiZMKhJ6b1znMxT8WeLO5Z-wZA@mail.gmail.com' \ --to=irogers@google.com \ --cc=acme@kernel.org \ --cc=acme@redhat.com \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=bp@suse.de \ --cc=eranian@google.com \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=jon.grimm@amd.com \ --cc=kan.liang@linux.intel.com \ --cc=kim.phillips@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=mjambor@suse.cz \ --cc=mliska@suse.cz \ --cc=mpetlan@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=vijaythakkar@me.com \ --cc=wcohen@redhat.com \ --cc=yao.jin@linux.intel.com \ --cc=yeyunfeng@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.