From: Arnaldo Carvalho de Melo <acme@kernel.org> To: Leo Yan <leo.yan@linaro.org> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, Jonathan Corbet <corbet@lwn.net>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Daniel Kiss <Daniel.Kiss@arm.com>, Denis Nikitin <denik@chromium.org>, Al Grant <al.grant@arm.com>, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Date: Fri, 5 Mar 2021 14:29:44 -0300 [thread overview] Message-ID: <YEJqiNkIsNWS0E2G@kernel.org> (raw) In-Reply-To: <20210209015855.GA54680@leoy-ThinkPad-X240s> Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > From: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > > takes these two values (14 and 28 prespectively) as bit masks, but > > > actually both are the offset for bits. But this doesn't lead to > > > further failure due to the AND logic operation will be always true for > > > ETM_OPT_CTXTID / ETM_OPT_TS. > > > > > > This patch defines new independent macros (rather than using the > > > "config" bits) for requesting the "contextid" and "timestamp" for > > > cs_etm_set_option(). > > > > > > [leoy: Extract the change as a separate patch for easier review] > > > > This should go just above your name - see below. I fixed this up and added this patch to my perf/urgent branch, for v5.12, since the kernel bits are upstream and this is a fix. Looking at the other patches in the series. - Arnaldo > > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > [Extract the change as a separate patch for easier review] > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > > > > --- > > > tools/perf/arch/arm/util/cs-etm.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > > > index bd446aba64f7..c25c878fd06c 100644 > > > --- a/tools/perf/arch/arm/util/cs-etm.c > > > +++ b/tools/perf/arch/arm/util/cs-etm.c > > > @@ -156,6 +156,10 @@ static int cs_etm_set_timestamp(struct auxtrace_record *itr, > > > return err; > > > } > > > > > > +#define ETM_SET_OPT_CTXTID (1 << 0) > > > +#define ETM_SET_OPT_TS (1 << 1) > > > +#define ETM_SET_OPT_MASK (ETM_SET_OPT_CTXTID | ETM_SET_OPT_TS) > > > + > > > > I would much rather see this fixed with the BIT() macro as it is done in the > > rest of this set than defining new constant. > > > > With the above: > > > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > I have picked up the kernel portion of this set. I suggest you fix the above > > and send another revision to Arnaldo with my RBs. > > Will do this. Thanks for suggestion, Mathieu. > > Leo > > [...] -- - Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org> To: Leo Yan <leo.yan@linaro.org> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, Jonathan Corbet <corbet@lwn.net>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Daniel Kiss <Daniel.Kiss@arm.com>, Denis Nikitin <denik@chromium.org>, Al Grant <al.grant@arm.com>, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Date: Fri, 5 Mar 2021 14:29:44 -0300 [thread overview] Message-ID: <YEJqiNkIsNWS0E2G@kernel.org> (raw) In-Reply-To: <20210209015855.GA54680@leoy-ThinkPad-X240s> Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > From: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > > takes these two values (14 and 28 prespectively) as bit masks, but > > > actually both are the offset for bits. But this doesn't lead to > > > further failure due to the AND logic operation will be always true for > > > ETM_OPT_CTXTID / ETM_OPT_TS. > > > > > > This patch defines new independent macros (rather than using the > > > "config" bits) for requesting the "contextid" and "timestamp" for > > > cs_etm_set_option(). > > > > > > [leoy: Extract the change as a separate patch for easier review] > > > > This should go just above your name - see below. I fixed this up and added this patch to my perf/urgent branch, for v5.12, since the kernel bits are upstream and this is a fix. Looking at the other patches in the series. - Arnaldo > > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > [Extract the change as a separate patch for easier review] > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > > > > --- > > > tools/perf/arch/arm/util/cs-etm.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > > > index bd446aba64f7..c25c878fd06c 100644 > > > --- a/tools/perf/arch/arm/util/cs-etm.c > > > +++ b/tools/perf/arch/arm/util/cs-etm.c > > > @@ -156,6 +156,10 @@ static int cs_etm_set_timestamp(struct auxtrace_record *itr, > > > return err; > > > } > > > > > > +#define ETM_SET_OPT_CTXTID (1 << 0) > > > +#define ETM_SET_OPT_TS (1 << 1) > > > +#define ETM_SET_OPT_MASK (ETM_SET_OPT_CTXTID | ETM_SET_OPT_TS) > > > + > > > > I would much rather see this fixed with the BIT() macro as it is done in the > > rest of this set than defining new constant. > > > > With the above: > > > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > I have picked up the kernel portion of this set. I suggest you fix the above > > and send another revision to Arnaldo with my RBs. > > Will do this. Thanks for suggestion, Mathieu. > > Leo > > [...] -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-05 17:30 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-06 15:08 [PATCH v3 0/8] coresight: etm-perf: Fix pid tracing with VHE Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-06 15:08 ` [PATCH v3 1/8] coresight: etm-perf: Clarify comment on perf options Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-06 15:08 ` [PATCH v3 2/8] tools headers UAPI: Update tools' copy of linux/coresight-pmu.h Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 17:34 ` Mathieu Poirier 2021-02-08 17:34 ` Mathieu Poirier 2021-02-06 15:08 ` [PATCH v3 3/8] coresight: etm-perf: Support PID tracing for kernel at EL2 Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-06 15:08 ` [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 20:46 ` Mathieu Poirier 2021-02-08 20:46 ` Mathieu Poirier 2021-02-09 1:58 ` Leo Yan 2021-02-09 1:58 ` Leo Yan 2021-03-05 17:29 ` Arnaldo Carvalho de Melo [this message] 2021-03-05 17:29 ` Arnaldo Carvalho de Melo 2021-03-06 3:05 ` Leo Yan 2021-03-06 3:05 ` Leo Yan 2021-02-06 15:08 ` [PATCH v3 5/8] perf cs-etm: Support PID tracing in config Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 18:55 ` Mathieu Poirier 2021-02-08 18:55 ` Mathieu Poirier 2021-03-05 17:30 ` Arnaldo Carvalho de Melo 2021-03-05 17:30 ` Arnaldo Carvalho de Melo 2021-02-06 15:08 ` [PATCH v3 6/8] perf cs-etm: Add helper cs_etm__get_pid_fmt() Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 20:32 ` Mathieu Poirier 2021-02-08 20:32 ` Mathieu Poirier 2021-02-11 12:36 ` Suzuki K Poulose 2021-02-11 12:36 ` Suzuki K Poulose 2021-02-06 15:08 ` [PATCH v3 7/8] perf cs-etm: Detect pid in VMID for kernel running at EL2 Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 20:33 ` Mathieu Poirier 2021-02-08 20:33 ` Mathieu Poirier 2021-02-06 15:08 ` [PATCH v3 8/8] Documentation: coresight: Add PID tracing description Leo Yan 2021-02-06 15:08 ` Leo Yan 2021-02-08 20:50 ` Mathieu Poirier 2021-02-08 20:50 ` Mathieu Poirier 2021-02-08 21:15 ` Mike Leach 2021-02-08 21:15 ` Mike Leach 2021-02-11 12:38 ` Suzuki K Poulose 2021-02-11 12:38 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YEJqiNkIsNWS0E2G@kernel.org \ --to=acme@kernel.org \ --cc=Daniel.Kiss@arm.com \ --cc=al.grant@arm.com \ --cc=corbet@lwn.net \ --cc=coresight@lists.linaro.org \ --cc=denik@chromium.org \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.