From: Jingoo Han <jg1.han@samsung.com> To: "'Marek Vasut'" <marex@denx.de>, "'Wolfram Sang'" <wsa@the-dreams.de>, "'Fabio Estevam'" <fabio.estevam@freescale.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Richard Zhu'" <r65037@freescale.com>, linux-pci@vger.kernel.org, "'Bjorn Helgaas'" <bhelgaas@google.com>, "'Shawn Guo'" <shawn.guo@linaro.org>, "'Jingoo Han'" <jg1.han@samsung.com> Subject: Re: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource Date: Wed, 15 Jan 2014 07:32:01 +0900 [thread overview] Message-ID: <001701cf1178$7191ec10$54b5c430$%han@samsung.com> (raw) In-Reply-To: <201401141417.03349.marex@denx.de> On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote: > On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > > True that, > > Acked-by: Marek Vasut <marex@denx.de> (+cc Fabio Estevam) Hi all, The same patch was already sent by Fabio Estevam a month ago.[1] Also, it was applied to pci/next tree.[2] [1] http://www.spinics.net/lists/linux-pci/msg26873.html [2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586 Best regards, Jingoo Han > > > --- > > > > Should go via subsystem tree > > > > drivers/pci/host/pci-imx6.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > > index bd70af8..5002e23 100644 > > --- a/drivers/pci/host/pci-imx6.c > > +++ b/drivers/pci/host/pci-imx6.c > > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct > > platform_device *pdev) "imprecise external abort"); > > > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - if (!dbi_base) { > > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > > - return -ENODEV; > > - } > > - > > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > > if (IS_ERR(pp->dbi_base)) { > > ret = PTR_ERR(pp->dbi_base); > > Best regards, > Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: jg1.han@samsung.com (Jingoo Han) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource Date: Wed, 15 Jan 2014 07:32:01 +0900 [thread overview] Message-ID: <001701cf1178$7191ec10$54b5c430$%han@samsung.com> (raw) In-Reply-To: <201401141417.03349.marex@denx.de> On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote: > On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > > True that, > > Acked-by: Marek Vasut <marex@denx.de> (+cc Fabio Estevam) Hi all, The same patch was already sent by Fabio Estevam a month ago.[1] Also, it was applied to pci/next tree.[2] [1] http://www.spinics.net/lists/linux-pci/msg26873.html [2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586 Best regards, Jingoo Han > > > --- > > > > Should go via subsystem tree > > > > drivers/pci/host/pci-imx6.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > > index bd70af8..5002e23 100644 > > --- a/drivers/pci/host/pci-imx6.c > > +++ b/drivers/pci/host/pci-imx6.c > > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct > > platform_device *pdev) "imprecise external abort"); > > > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - if (!dbi_base) { > > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > > - return -ENODEV; > > - } > > - > > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > > if (IS_ERR(pp->dbi_base)) { > > ret = PTR_ERR(pp->dbi_base); > > Best regards, > Marek Vasut
next prev parent reply other threads:[~2014-01-14 22:32 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-01-14 11:58 [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource Wolfram Sang [not found] ` <1389700739-3696-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-01-14 11:58 ` [PATCH 2/7] drivers/amba: " Wolfram Sang 2014-01-14 11:58 ` Wolfram Sang [not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-01-14 13:32 ` Thierry Reding 2014-01-14 13:32 ` Thierry Reding 2014-01-14 17:40 ` Stephen Warren 2014-01-14 17:40 ` Stephen Warren [not found] ` <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2014-01-14 18:30 ` Wolfram Sang 2014-01-14 18:30 ` Wolfram Sang 2014-02-05 17:18 ` Stephen Warren 2014-02-05 17:18 ` Stephen Warren 2014-01-14 11:58 ` [PATCH 3/7] drivers/gpu/host1x/drm: " Wolfram Sang [not found] ` <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-01-14 13:40 ` Thierry Reding 2014-01-14 13:40 ` Thierry Reding 2014-01-14 11:58 ` [PATCH 4/7] drivers/pci/host: " Wolfram Sang 2014-01-14 11:58 ` Wolfram Sang 2014-01-14 13:17 ` Marek Vasut 2014-01-14 13:17 ` Marek Vasut 2014-01-14 22:32 ` Jingoo Han [this message] 2014-01-14 22:32 ` Jingoo Han 2014-01-14 11:58 ` [PATCH 5/7] drivers/usb/dwc3: " Wolfram Sang 2014-01-14 14:15 ` Felipe Balbi 2014-01-14 14:15 ` Felipe Balbi 2014-01-14 11:58 ` [PATCH 6/7] arch/mips/pci: " Wolfram Sang 2014-01-14 11:58 ` [PATCH 7/7] drivers/gpio: " Wolfram Sang 2014-01-15 9:28 ` Linus Walleij 2014-01-15 12:54 ` Sekhar Nori 2014-01-15 13:51 ` Linus Walleij 2014-01-15 14:04 ` Sekhar Nori 2014-01-15 15:50 ` Kevin Hilman 2014-01-15 15:50 ` Kevin Hilman 2014-01-16 4:29 ` Sekhar Nori 2014-02-03 11:30 ` Grygorii Strashko 2014-01-14 12:03 ` [PATCH 1/7] arch/mips/lantiq/xway: " John Crispin 2014-01-14 12:11 ` Wolfram Sang 2014-01-14 12:22 ` John Crispin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='001701cf1178$7191ec10$54b5c430$%han@samsung.com' \ --to=jg1.han@samsung.com \ --cc=bhelgaas@google.com \ --cc=fabio.estevam@freescale.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=marex@denx.de \ --cc=r65037@freescale.com \ --cc=shawn.guo@linaro.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.