From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Rob Herring'" <robh@kernel.org> Cc: <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <krzk@kernel.org>, <avri.altman@wdc.com>, <martin.petersen@oracle.com>, <kwmad.kim@samsung.com>, <stanley.chu@mediatek.com>, <cang@codeaurora.org>, <linux-samsung-soc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Date: Sat, 9 May 2020 06:06:10 +0530 [thread overview] Message-ID: <006801d62599$d8761690$896243b0$@samsung.com> (raw) In-Reply-To: <20200505155611.GA23690@bogus> Hi Rob > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 05 May 2020 21:26 > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org; > avri.altman@wdc.com; martin.petersen@oracle.com; > kwmad.kim@samsung.com; stanley.chu@mediatek.com; > cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY > bindings > > On Sun, Apr 26, 2020 at 11:00:20PM +0530, Alim Akhtar wrote: > > This patch documents Samsung UFS PHY device tree bindings > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > .../bindings/phy/samsung,ufs-phy.yaml | 74 +++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > new file mode 100644 > > index 000000000000..352d5dda320d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/url?k=5c35df0a-01ffeabd-5c345445-0cc47a3 > > +003e8- > aa6c980dab2ba33a&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2F > > +phy%2Fsamsung%2Cufs-phy.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/url?k=9734fc5e-cafec9e9-97357711-0cc47a3 > > +003e8- > 79d176b992774339&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schem > > +as%2Fcore.yaml%23 > > + > > +title: Samsung SoC series UFS PHY Device Tree Bindings > > + > > +maintainers: > > + - Alim Akhtar <alim.akhtar@samsung.com> > > + > > +properties: > > + "#phy-cells": > > + const: 0 > > + > > + compatible: > > + enum: > > + - samsung,exynos7-ufs-phy > > + > > + reg: > > + maxItems: 1 > > + description: PHY base register address > > Can drop the description. Doesn't add anything special. > > > + > > + reg-names: > > + items: > > + - const: phy-pma > > + > > + clocks: > > + items: > > + - description: PLL reference clock > > + - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > > + - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > > + - description: symbol clock for output symbol ( tx0 symbol > > + clock) > > + > > + clock-names: > > + items: > > + - const: ref_clk > > + - const: rx1_symbol_clk > > + - const: rx0_symbol_clk > > + - const: tx0_symbol_clk > > + > > + samsung,pmu-syscon: > > + $ref: '/schemas/types.yaml#/definitions/phandle' > > + description: phandle for PMU system controller interface, used to > > + control pmu registers bits for ufs m-phy > > + > > +required: > > + - "#phy-cells" > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - clock-names > > + - samsung,pmu-syscon > > Add: > > additionalProperties: false > > With that, > Will update the documentation as per your suggestion > Reviewed-by: Rob Herring <robh@kernel.org> > Thanks for review comments. After fixing, will add your review tag. > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/exynos7-clk.h> > > + > > + ufs_phy: ufs-phy@15571800 { > > + compatible = "samsung,exynos7-ufs-phy"; > > + reg = <0x15571800 0x240>; > > + reg-names = "phy-pma"; > > + samsung,pmu-syscon = <&pmu_system_controller>; > > + #phy-cells = <0>; > > + clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > > + <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, > > + <&clock_fsys1 PHYCLK_UFS20_RX0_SYMBOL_USER>, > > + <&clock_fsys1 PHYCLK_UFS20_TX0_SYMBOL_USER>; > > + clock-names = "ref_clk", "rx1_symbol_clk", > > + "rx0_symbol_clk", "tx0_symbol_clk"; > > + > > + }; > > +... > > -- > > 2.17.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com> To: "'Rob Herring'" <robh@kernel.org> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, krzk@kernel.org, kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org, stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Date: Sat, 9 May 2020 06:06:10 +0530 [thread overview] Message-ID: <006801d62599$d8761690$896243b0$@samsung.com> (raw) In-Reply-To: <20200505155611.GA23690@bogus> Hi Rob > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 05 May 2020 21:26 > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org; > avri.altman@wdc.com; martin.petersen@oracle.com; > kwmad.kim@samsung.com; stanley.chu@mediatek.com; > cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY > bindings > > On Sun, Apr 26, 2020 at 11:00:20PM +0530, Alim Akhtar wrote: > > This patch documents Samsung UFS PHY device tree bindings > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > .../bindings/phy/samsung,ufs-phy.yaml | 74 +++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > new file mode 100644 > > index 000000000000..352d5dda320d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/url?k=5c35df0a-01ffeabd-5c345445-0cc47a3 > > +003e8- > aa6c980dab2ba33a&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2F > > +phy%2Fsamsung%2Cufs-phy.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/url?k=9734fc5e-cafec9e9-97357711-0cc47a3 > > +003e8- > 79d176b992774339&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schem > > +as%2Fcore.yaml%23 > > + > > +title: Samsung SoC series UFS PHY Device Tree Bindings > > + > > +maintainers: > > + - Alim Akhtar <alim.akhtar@samsung.com> > > + > > +properties: > > + "#phy-cells": > > + const: 0 > > + > > + compatible: > > + enum: > > + - samsung,exynos7-ufs-phy > > + > > + reg: > > + maxItems: 1 > > + description: PHY base register address > > Can drop the description. Doesn't add anything special. > > > + > > + reg-names: > > + items: > > + - const: phy-pma > > + > > + clocks: > > + items: > > + - description: PLL reference clock > > + - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > > + - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > > + - description: symbol clock for output symbol ( tx0 symbol > > + clock) > > + > > + clock-names: > > + items: > > + - const: ref_clk > > + - const: rx1_symbol_clk > > + - const: rx0_symbol_clk > > + - const: tx0_symbol_clk > > + > > + samsung,pmu-syscon: > > + $ref: '/schemas/types.yaml#/definitions/phandle' > > + description: phandle for PMU system controller interface, used to > > + control pmu registers bits for ufs m-phy > > + > > +required: > > + - "#phy-cells" > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - clock-names > > + - samsung,pmu-syscon > > Add: > > additionalProperties: false > > With that, > Will update the documentation as per your suggestion > Reviewed-by: Rob Herring <robh@kernel.org> > Thanks for review comments. After fixing, will add your review tag. > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/exynos7-clk.h> > > + > > + ufs_phy: ufs-phy@15571800 { > > + compatible = "samsung,exynos7-ufs-phy"; > > + reg = <0x15571800 0x240>; > > + reg-names = "phy-pma"; > > + samsung,pmu-syscon = <&pmu_system_controller>; > > + #phy-cells = <0>; > > + clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > > + <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, > > + <&clock_fsys1 PHYCLK_UFS20_RX0_SYMBOL_USER>, > > + <&clock_fsys1 PHYCLK_UFS20_TX0_SYMBOL_USER>; > > + clock-names = "ref_clk", "rx1_symbol_clk", > > + "rx0_symbol_clk", "tx0_symbol_clk"; > > + > > + }; > > +... > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-09 0:36 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200426174202epcas5p30e4ebe79a1de0138562219ecd7ea2e18@epcas5p3.samsung.com> 2020-04-26 17:30 ` [PATCH v7 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174204epcas5p24796abe49298815cff344fba2e067169@epcas5p2.samsung.com> 2020-04-26 17:30 ` [PATCH v7 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174206epcas5p3a948de27f9eaa9256e4c3de5294ce234@epcas5p3.samsung.com> 2020-04-26 17:30 ` [PATCH v7 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174209epcas5p2fc312fae0c619674bfd784d8659d3b97@epcas5p2.samsung.com> 2020-04-26 17:30 ` [PATCH v7 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174211epcas5p39d7a1ca820bacb5638b5ba63c1585a53@epcas5p3.samsung.com> 2020-04-26 17:30 ` [PATCH v7 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174213epcas5p3f5b403eafe77d98cbe0b92ccb3fd56b2@epcas5p3.samsung.com> 2020-04-26 17:30 ` [PATCH v7 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar 2020-04-27 7:54 ` Avri Altman 2020-04-27 7:54 ` Avri Altman [not found] ` <CGME20200426174215epcas5p3e87abccf47976f6318eb470efef9db39@epcas5p3.samsung.com> 2020-04-26 17:30 ` [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar 2020-05-05 15:56 ` Rob Herring 2020-05-05 15:56 ` Rob Herring 2020-05-09 0:36 ` Alim Akhtar [this message] 2020-05-09 0:36 ` Alim Akhtar [not found] ` <CGME20200426174217epcas5p2c7d1606b641b73f67a169b8d22f0637d@epcas5p2.samsung.com> 2020-04-26 17:30 ` [PATCH v7 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar 2020-05-07 5:19 ` Kishon Vijay Abraham I 2020-05-07 5:19 ` Kishon Vijay Abraham I 2020-05-09 0:32 ` Alim Akhtar 2020-05-09 0:32 ` Alim Akhtar [not found] ` <CGME20200426174219epcas5p460c8637629afd930313ae0fa936593cd@epcas5p4.samsung.com> 2020-04-26 17:30 ` [PATCH v7 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar 2020-05-05 15:58 ` Rob Herring 2020-05-05 15:58 ` Rob Herring 2020-05-09 0:38 ` Alim Akhtar 2020-05-09 0:38 ` Alim Akhtar [not found] ` <CGME20200426174222epcas5p4c03e929a5cb86bb5fccbcc6e5e98ee80@epcas5p4.samsung.com> 2020-04-26 17:30 ` [PATCH v7 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar [not found] ` <CGME20200426174224epcas5p43a1223a63bb414a5060fa9044681f933@epcas5p4.samsung.com> 2020-04-26 17:30 ` [PATCH v7 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar 2020-04-26 17:30 ` Alim Akhtar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='006801d62599$d8761690$896243b0$@samsung.com' \ --to=alim.akhtar@samsung.com \ --cc=avri.altman@wdc.com \ --cc=cang@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=krzk@kernel.org \ --cc=kwmad.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=robh@kernel.org \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.