[PATCH] cifsd: Select SG_POOL for SMB_SERVER

[PATCH] cifsd: Select SG_POOL for SMB_SERVER

[Zhang Xiaoxu]

hulk-robot following build error:
 fs/cifsd/transport_rdma.c: In function ‘read_write_done’:
 fs/cifsd/transport_rdma.c:1297:2: error: implicit declaration of function ‘sg_free_table_chained’ [-Werror=implicit-function-declaration]
  1297 |  sg_free_table_chained(&msg->sgt, SG_CHUNK_SIZE);

The reason is CONFIG_SG_POOL is not enabled in the config, to
avoid such failure, select SG_POOL in Kconfig for SMB_SERVER.

Fixes: 75b8988dfe83 ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
 fs/cifsd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig
index d1ac53c83125..fb57672424be 100644
--- a/fs/cifsd/Kconfig
+++ b/fs/cifsd/Kconfig
@@ -17,6 +17,7 @@ config SMB_SERVER
 	select CRYPTO_AEAD2
 	select CRYPTO_CCM
 	select CRYPTO_GCM
+	select SG_POOL
 	default n
 	help
 	  Choose Y here if you want to allow SMB3 compliant clients
-- 
2.25.4

RE: [PATCH] cifsd: Select SG_POOL for SMB_SERVER

[Namjae Jeon]

> hulk-robot following build error:
>  fs/cifsd/transport_rdma.c: In function ‘read_write_done’:
>  fs/cifsd/transport_rdma.c:1297:2: error: implicit declaration of function ‘sg_free_table_chained’ [-
> Werror=implicit-function-declaration]
>   1297 |  sg_free_table_chained(&msg->sgt, SG_CHUNK_SIZE);
> 
> The reason is CONFIG_SG_POOL is not enabled in the config, to avoid such failure, select SG_POOL in
> Kconfig for SMB_SERVER.
> 
> Fixes: 75b8988dfe83 ("cifsd: add server handler for central processing and tranport layers")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
>  fs/cifsd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index d1ac53c83125..fb57672424be 100644
> --- a/fs/cifsd/Kconfig
> +++ b/fs/cifsd/Kconfig
> @@ -17,6 +17,7 @@ config SMB_SERVER
>  	select CRYPTO_AEAD2
>  	select CRYPTO_CCM
>  	select CRYPTO_GCM
> +	select SG_POOL
>  	default n
>  	help
>  	  Choose Y here if you want to allow SMB3 compliant clients
transport_rdma.c is built when SMB_SERVER_SMBDIRECT is set.
So we need to move it to config SMB_SERVER_SMBDIRECT.

diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig
index d1ac53c83125..b94cf1158182 100644
--- a/fs/cifsd/Kconfig
+++ b/fs/cifsd/Kconfig
@@ -43,6 +43,7 @@ config SMB_SERVER
 config SMB_SERVER_SMBDIRECT
        bool "Support for SMB Direct protocol"
        depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS || SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
+       select SG_POOL
        default n
 
        help

I will directly update your patch.
Thanks for your patch!
> --
> 2.25.4