* [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5
@ 2022-09-16 14:17 Howard Hsu
2022-09-16 16:25 ` Jeff Johnson
2022-09-16 16:50 ` Johannes Berg
0 siblings, 2 replies; 3+ messages in thread
From: Howard Hsu @ 2022-09-16 14:17 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Evelyn Tsai, linux-mediatek, Howard Hsu
Fix ieee80211_prep_channel to aligh with Draft P80211.be_D1.5. It shall
shift 4 byte to fetch EHT Operation information.
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
---
net/mac80211/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index ff449e0c2e62..9bb085eab12a 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -4735,7 +4735,7 @@ static int ieee80211_prep_channel(struct ieee80211_sub_if_data *sdata,
cbss_ies->data, cbss_ies->len);
if (eht_oper_ie && eht_oper_ie[1] >=
1 + sizeof(struct ieee80211_eht_operation))
- eht_oper = (void *)(eht_oper_ie + 3);
+ eht_oper = (void *)(eht_oper_ie + 4);
else
eht_oper = NULL;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5
2022-09-16 14:17 [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5 Howard Hsu
@ 2022-09-16 16:25 ` Jeff Johnson
2022-09-16 16:50 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2022-09-16 16:25 UTC (permalink / raw)
To: Howard Hsu, Johannes Berg
Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Evelyn Tsai, linux-mediatek
On 9/16/2022 7:17 AM, Howard Hsu wrote:
> Fix ieee80211_prep_channel to aligh with Draft P80211.be_D1.5. It shall
s/aligh/align/
why refer to D1.5? Current code is using D2.0 definitions.
further note it seems at some point we should move all definitions to
D2.1 (in which case EHT operation information is now at offset 8 of the
EHT operation element)
> shift 4 byte to fetch EHT Operation information.
>
> Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
> ---
> net/mac80211/mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index ff449e0c2e62..9bb085eab12a 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -4735,7 +4735,7 @@ static int ieee80211_prep_channel(struct ieee80211_sub_if_data *sdata,
> cbss_ies->data, cbss_ies->len);
> if (eht_oper_ie && eht_oper_ie[1] >=
> 1 + sizeof(struct ieee80211_eht_operation))
> - eht_oper = (void *)(eht_oper_ie + 3);
> + eht_oper = (void *)(eht_oper_ie + 4);
> else
> eht_oper = NULL;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5
2022-09-16 14:17 [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5 Howard Hsu
2022-09-16 16:25 ` Jeff Johnson
@ 2022-09-16 16:50 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2022-09-16 16:50 UTC (permalink / raw)
To: Howard Hsu
Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Evelyn Tsai, linux-mediatek
On Fri, 2022-09-16 at 22:17 +0800, Howard Hsu wrote:
> Fix ieee80211_prep_channel to aligh with Draft P80211.be_D1.5. It shall
> shift 4 byte to fetch EHT Operation information.
>
> Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
> ---
> net/mac80211/mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index ff449e0c2e62..9bb085eab12a 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -4735,7 +4735,7 @@ static int ieee80211_prep_channel(struct ieee80211_sub_if_data *sdata,
> cbss_ies->data, cbss_ies->len);
> if (eht_oper_ie && eht_oper_ie[1] >=
> 1 + sizeof(struct ieee80211_eht_operation))
> - eht_oper = (void *)(eht_oper_ie + 3);
> + eht_oper = (void *)(eht_oper_ie + 4);
>
No, the +3 is just to skip the type/len/ext-tag
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-16 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 14:17 [PATCH] wifi: mac80211: Align with Draft P802.11be_D1.5 Howard Hsu
2022-09-16 16:25 ` Jeff Johnson
2022-09-16 16:50 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.