From: Richard Henderson <richard.henderson@linaro.org> To: "Thomas Huth" <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Fam Zheng" <fam@euphon.net>, "Peter Maydell" <peter.maydell@linaro.org>, kvm@vger.kernel.org, "Alex Bennée" <alex.bennee@linaro.org>, qemu-arm@nongnu.org, "Richard Henderson" <rth@twiddle.net> Subject: Re: [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job Date: Sat, 3 Oct 2020 05:37:00 -0500 [thread overview] Message-ID: <01fa70d1-0f11-78a1-aeb6-885e91501429@linaro.org> (raw) In-Reply-To: <c7140a42-043c-9bc5-88c8-2cdad9ae2a14@redhat.com> On 10/3/20 5:14 AM, Thomas Huth wrote: > On 03/10/2020 12.03, Richard Henderson wrote: >> On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: >>> Add a job to build QEMU on Aarch64 with TCG disabled, so >>> this configuration won't bitrot over time. >>> >>> We explicitly modify default-configs/aarch64-softmmu.mak to >>> only select the 'virt' and 'SBSA-REF' machines. >> >> I really wish we didn't have to do this. >> >> Can't we e.g. *not* list all of the arm boards explicitly in default-configs, >> but use the Kconfig "default y if ..."? >> >> Seems like that would let --disable-tcg work as expected. >> One should still be able to create custom configs with e.g. >> CONFIG_EXYNOS4=n or CONIFIG_ARM_V4=n, correct? > > But that would be different from how we handle all other targets currently... So? Does that automatically mean they're golden? Perhaps they should be doing it the other way around too. > IMHO we shoud go into a different direction instead, e.g. by adding a > "--kconfig-dir" switch to the configure script. If it has not been specified, > the configs will be read from default-configs/ (or maybe we should then rename > it to configs/default/). But if the switch has been specified with a directory > as parameter, the config files will be read from that directory instead. We > could then have folders like: > > - configs/default (current default-configs) > - configs/no-tcg (all machines that work without tcg) > - configs/lean-kvm (for "nemu"-style minimalistic settings) > > etc. > > What do you think? I don't really understand the suggestion. My first reaction is that this is more confusing than --disable-tcg, and trying to automatically dtrt with that. r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org> To: "Thomas Huth" <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org Cc: "Fam Zheng" <fam@euphon.net>, "Peter Maydell" <peter.maydell@linaro.org>, kvm@vger.kernel.org, qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Richard Henderson" <rth@twiddle.net> Subject: Re: [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job Date: Sat, 3 Oct 2020 05:37:00 -0500 [thread overview] Message-ID: <01fa70d1-0f11-78a1-aeb6-885e91501429@linaro.org> (raw) In-Reply-To: <c7140a42-043c-9bc5-88c8-2cdad9ae2a14@redhat.com> On 10/3/20 5:14 AM, Thomas Huth wrote: > On 03/10/2020 12.03, Richard Henderson wrote: >> On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: >>> Add a job to build QEMU on Aarch64 with TCG disabled, so >>> this configuration won't bitrot over time. >>> >>> We explicitly modify default-configs/aarch64-softmmu.mak to >>> only select the 'virt' and 'SBSA-REF' machines. >> >> I really wish we didn't have to do this. >> >> Can't we e.g. *not* list all of the arm boards explicitly in default-configs, >> but use the Kconfig "default y if ..."? >> >> Seems like that would let --disable-tcg work as expected. >> One should still be able to create custom configs with e.g. >> CONFIG_EXYNOS4=n or CONIFIG_ARM_V4=n, correct? > > But that would be different from how we handle all other targets currently... So? Does that automatically mean they're golden? Perhaps they should be doing it the other way around too. > IMHO we shoud go into a different direction instead, e.g. by adding a > "--kconfig-dir" switch to the configure script. If it has not been specified, > the configs will be read from default-configs/ (or maybe we should then rename > it to configs/default/). But if the switch has been specified with a directory > as parameter, the config files will be read from that directory instead. We > could then have folders like: > > - configs/default (current default-configs) > - configs/no-tcg (all machines that work without tcg) > - configs/lean-kvm (for "nemu"-style minimalistic settings) > > etc. > > What do you think? I don't really understand the suggestion. My first reaction is that this is more confusing than --disable-tcg, and trying to automatically dtrt with that. r~
next prev parent reply other threads:[~2020-10-03 10:37 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 22:43 [PATCH v4 00/12] Support disabling TCG on ARM (part 2) Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-30 7:08 ` Thomas Huth 2020-09-30 7:08 ` Thomas Huth 2020-10-03 9:09 ` Richard Henderson 2020-10-03 9:09 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-30 12:50 ` Claudio Fontana 2020-09-30 12:50 ` Claudio Fontana 2020-09-30 13:17 ` Paolo Bonzini 2020-09-30 13:17 ` Paolo Bonzini 2020-10-03 9:13 ` Richard Henderson 2020-10-03 9:13 ` Richard Henderson 2020-10-03 9:15 ` Paolo Bonzini 2020-10-03 9:15 ` Paolo Bonzini 2020-10-03 9:32 ` Richard Henderson 2020-10-03 9:32 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:43 ` Richard Henderson 2020-10-03 9:43 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-30 8:03 ` Philippe Mathieu-Daudé 2020-09-30 8:03 ` Philippe Mathieu-Daudé 2020-10-03 9:17 ` Thomas Huth 2020-10-03 9:17 ` Thomas Huth 2020-09-29 22:43 ` [PATCH v4 05/12] target/arm: Restrict ARMv5 " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 06/12] target/arm: Restrict ARMv6 " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 07/12] target/arm: Restrict ARMv7 R-profile " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 08/12] target/arm: Restrict ARMv7 M-profile " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 09/12] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:48 ` Richard Henderson 2020-10-03 9:48 ` Richard Henderson 2021-01-29 18:53 ` Philippe Mathieu-Daudé 2021-01-29 18:53 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 10/12] target/arm: Do not build TCG objects when TCG is off Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:52 ` Richard Henderson 2020-10-03 9:52 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 11/12] target/arm: Reorder meson.build rules Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:53 ` Richard Henderson 2020-10-03 9:53 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 10:03 ` Richard Henderson 2020-10-03 10:03 ` Richard Henderson 2020-10-03 10:14 ` Thomas Huth 2020-10-03 10:14 ` Thomas Huth 2020-10-03 10:37 ` Richard Henderson [this message] 2020-10-03 10:37 ` Richard Henderson 2020-09-30 7:58 ` [PATCH v4 00/12] Support disabling TCG on ARM (part 2) Igor Mammedov 2020-09-30 7:58 ` Igor Mammedov 2020-09-30 10:20 ` Philippe Mathieu-Daudé 2020-09-30 10:20 ` Philippe Mathieu-Daudé 2021-01-28 0:41 ` Alex Bennée 2021-01-28 0:41 ` Alex Bennée 2021-01-28 11:02 ` Philippe Mathieu-Daudé 2021-01-28 11:02 ` Philippe Mathieu-Daudé 2021-01-28 15:42 ` Alex Bennée 2021-01-28 15:42 ` Alex Bennée
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=01fa70d1-0f11-78a1-aeb6-885e91501429@linaro.org \ --to=richard.henderson@linaro.org \ --cc=alex.bennee@linaro.org \ --cc=fam@euphon.net \ --cc=kvm@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=philmd@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.