Re: [PATCH v10 09/28] qmp: add query-sev command

From: Eric Blake <eblake@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Eduardo Habkost <ehabkost@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Alistair Francis <alistair.francis@xilinx.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Lendacky <Thomas.Lendacky@amd.com>,
	Borislav Petkov <bp@suse.de>, Bruce Rogers <brogers@suse.com>
Subject: Re: [PATCH v10 09/28] qmp: add query-sev command
Date: Thu, 1 Mar 2018 14:09:09 -0600	[thread overview]
Message-ID: <056098e9-43a8-222b-f265-e746c3ae00c5@redhat.com> (raw)
In-Reply-To: <20180228211028.83970-10-brijesh.singh@amd.com>

On 02/28/2018 03:10 PM, Brijesh Singh wrote:
> The QMP query command can used to retrieve the SEV information when
> memory encryption is enabled on AMD platform.
> 
> Cc: Eric Blake <eblake@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>   monitor.c             |  7 ++++++
>   qapi-schema.json      | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++

Based on the pull request I just sent:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00394.html
you will have to rebase this to stick things in qapi/misc.json instead.

>   target/i386/monitor.c |  8 +++++++
>   3 files changed, 76 insertions(+)
> 

> +++ b/qapi-schema.json
> @@ -3189,3 +3189,64 @@
>   # Since: 2.11
>   ##
>   { 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} }
> +
> +##
> +# @SevState:
> +#
> +# An enumeration of SEV state information used during @query-sev.
> +#
> +# Since: 2.12
> +##
> +{ 'enum': 'SevState',
> +  'data': ['uninit', 'lupdate', 'lsecret', 'running', 'supdate', 'rupdate' ] }

Could perhaps give more details about the meaning of each state.  But 
I'm not seeing anything blatantly wrong with the UI changes.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org