All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0
@ 2021-12-03 10:28 Jan Beulich
  2021-12-14  9:29 ` Roger Pau Monné
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2021-12-03 10:28 UTC (permalink / raw)
  To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné

Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
running in. Permit further PCI related ones (only their modern forms).
Also include the USB2 debug port operation at this occasion. While
largely relevant for the latter, drop the has_vpci() part of the
conditional as redundant with is_hardware_domain(): There's no PVH Dom0
without vPCI.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v5: For now leave out PHYSDEVOP_{prepare,release}_msix and
    PHYSDEVOP_restore_msi_ext. Drop has_vpci() part of the conditional.
v3: New.

--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -94,7 +94,10 @@ static long hvm_physdev_op(int cmd, XEN_
         break;
 
     case PHYSDEVOP_pci_mmcfg_reserved:
-        if ( !has_vpci(currd) || !is_hardware_domain(currd) )
+    case PHYSDEVOP_pci_device_add:
+    case PHYSDEVOP_pci_device_remove:
+    case PHYSDEVOP_dbgp_op:
+        if ( !is_hardware_domain(currd) )
             return -ENOSYS;
         break;
 



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0
  2021-12-03 10:28 [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0 Jan Beulich
@ 2021-12-14  9:29 ` Roger Pau Monné
  0 siblings, 0 replies; 2+ messages in thread
From: Roger Pau Monné @ 2021-12-14  9:29 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Andrew Cooper, Wei Liu

On Fri, Dec 03, 2021 at 11:28:39AM +0100, Jan Beulich wrote:
> Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
> running in. Permit further PCI related ones (only their modern forms).
> Also include the USB2 debug port operation at this occasion. While
> largely relevant for the latter, drop the has_vpci() part of the
> conditional as redundant with is_hardware_domain(): There's no PVH Dom0
> without vPCI.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-14  9:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 10:28 [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0 Jan Beulich
2021-12-14  9:29 ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.