Re: [PATCH 06/14] can: af_can: rename find_rcv_list() to can_rcv_list_find()

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 08/02/2017 07:44 PM, Marc Kleine-Budde wrote:
> This patch add the commonly used prefix "can_" to the find_rcv_list()
> function and add the "find" to the end, as the function returns a struct
> rcv_list. This improves the overall readability of the code.

The function should be named according to it's natural function.

If you want to move it to some kind of 'can' namespace I would suggest

find_can_rcv_list()

> -		rl = find_rcv_list(&can_id, &mask, dev_rcv_lists);
> +		rl = can_rcv_list_find(&can_id, &mask, dev_rcv_lists);

find_... is better to understand than can_...

And this is a local function not visible to anyone else outside of 
af_can.c .

Regards,
Oliver