Re: [PATCH 04/14] can: af_can: give variable holding the CAN per device receive lists a sensible name

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1534 bytes --]

On 08/24/2017 03:03 PM, Oliver Hartkopp wrote:
> On 08/02/2017 07:44 PM, Marc Kleine-Budde wrote:
>> This patch gives the variables holding the CAN receive filter lists a
>> better name by renaming them from "d" to "dev_rcv_lists".
>>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>>   net/can/af_can.c | 87 ++++++++++++++++++++++++++++----------------------------
>>   1 file changed, 43 insertions(+), 44 deletions(-)
>>
>> diff --git a/net/can/af_can.c b/net/can/af_can.c
>> index 2b12f713f4ca..43f4f51d5a73 100644
>> --- a/net/can/af_can.c
>> +++ b/net/can/af_can.c
>> @@ -381,7 +381,7 @@ static unsigned int effhash(canid_t can_id)
>>    *  Reduced can_id to have a preprocessed filter compare value.
>>    */
>>   static struct hlist_head *find_rcv_list(canid_t *can_id, canid_t *mask,
>> -					struct can_dev_rcv_lists *d)
>> +					struct can_dev_rcv_lists *dev_rcv_lists)
> 
> 					struct can_dev_rcv_lists *cdrl)
> 
> Ok. 'd' might be too short and not be easy to bring into connection with 
> can_dev_rcv_lists ... but 'dev_rcv_lists' smells like just another 
> structure definition an not a handy variable name, like e.g. cdrl ;-)

"d" is short - yes, but "cdrl" doesn't speak to me either.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]