All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] t/t9001-send-email.sh: ensure generated script is executed with $SHELL_PATH
@ 2009-06-22 17:32 Brandon Casey
  0 siblings, 0 replies; only message in thread
From: Brandon Casey @ 2009-06-22 17:32 UTC (permalink / raw)
  To: gitster; +Cc: git, Brandon Casey

From: Brandon Casey <drafnel@gmail.com>

If the shell is not specified using the '#!' notation, then the OS will
use '/bin/sh' to execute the script which may not produce the desired
results.  In particular, /bin/sh on Solaris interprets '^' specially which
has an affect on the sed command that this patch touches.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 t/t9001-send-email.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index fb7d9f3..7b4cf55 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -152,7 +152,9 @@ test_expect_success 'cccmd works' '
 	clean_fake_sendmail &&
 	cp $patches cccmd.patch &&
 	echo cccmd--cccmd@example.com >>cccmd.patch &&
-	echo sed -n s/^cccmd--//p \"\$1\" > cccmd-sed &&
+	{ echo "#!$SHELL_PATH"
+	  echo sed -n s/^cccmd--//p \"\$1\"
+	} > cccmd-sed &&
 	chmod +x cccmd-sed &&
 	git send-email \
 		--from="Example <nobody@example.com>" \
-- 
1.6.3.1.24.g152f4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-22 17:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-22 17:32 [PATCH] t/t9001-send-email.sh: ensure generated script is executed with $SHELL_PATH Brandon Casey

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.