From: Guenter Roeck <linux@roeck-us.net> To: Alistair Francis <alistair@alistair23.me>, lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, kernel@pengutronix.de Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, amitk@kernel.org, rui.zhang@intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alistair23@gmail.com, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v12 06/10] hwmon: sy7636a: Add temperature driver for sy7636a Date: Sat, 9 Oct 2021 06:49:50 -0700 [thread overview] Message-ID: <0ac0f13e-12eb-2272-3d4b-480dc6b54ee1@roeck-us.net> (raw) In-Reply-To: <20211009115031.18392-10-alistair@alistair23.me> On 10/9/21 4:50 AM, Alistair Francis wrote: > This is a multi-function device to interface with the sy7636a > EPD PMIC chip from Silergy. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > arch/arm/configs/imx_v6_v7_defconfig | 1 + That should be a separate patch. > drivers/hwmon/Kconfig | 10 ++++ > drivers/hwmon/Makefile | 1 + > drivers/hwmon/sy7636a-hwmon.c | 77 ++++++++++++++++++++++++++++ Documentation/hwmon/sy7636a-hwmon is missing. > 4 files changed, 89 insertions(+) > create mode 100644 drivers/hwmon/sy7636a-hwmon.c > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index 8a54a4d0181a..b87adf823e44 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -228,6 +228,7 @@ CONFIG_RN5T618_POWER=m > CONFIG_SENSORS_MC13783_ADC=y > CONFIG_SENSORS_GPIO_FAN=y > CONFIG_SENSORS_IIO_HWMON=y > +CONFIG_SENSORS_SY7636A=y > CONFIG_THERMAL_STATISTICS=y > CONFIG_THERMAL_WRITABLE_TRIPS=y > CONFIG_CPU_THERMAL=y > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index c4578e8f34bb..59f358293202 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1651,6 +1651,16 @@ config SENSORS_SIS5595 > This driver can also be built as a module. If so, the module > will be called sis5595. > > +config SENSORS_SY7636A > + tristate "Silergy SY7636A" > + depends on I2C That is an arbitrary dependency. The driver doesn't use I2C. > + help > + If you say yes here you get support for the thermistor readout of > + the Silergy SY7636A PMIC. > + > + This driver can also be built as a module. If so, the module > + will be called sy7636a-hwmon. > + > config SENSORS_DME1737 > tristate "SMSC DME1737, SCH311x and compatibles" > depends on I2C && !PPC > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 162940270661..1355ffdb1481 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -181,6 +181,7 @@ obj-$(CONFIG_SENSORS_SMSC47M1) += smsc47m1.o > obj-$(CONFIG_SENSORS_SMSC47M192)+= smsc47m192.o > obj-$(CONFIG_SENSORS_SPARX5) += sparx5-temp.o > obj-$(CONFIG_SENSORS_STTS751) += stts751.o > +obj-$(CONFIG_SENSORS_SY7636A) += sy7636a-hwmon.o > obj-$(CONFIG_SENSORS_AMC6821) += amc6821.o > obj-$(CONFIG_SENSORS_TC74) += tc74.o > obj-$(CONFIG_SENSORS_THMC50) += thmc50.o > diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c > new file mode 100644 > index 000000000000..e0204278339b > --- /dev/null > +++ b/drivers/hwmon/sy7636a-hwmon.c > @@ -0,0 +1,77 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Functions to access SY3686A power management chip temperature > + * > + * Copyright (C) 2019 reMarkable AS - http://www.remarkable.com/ > + * > + * Authors: Lars Ivar Miljeteig <lars.ivar.miljeteig@remarkable.com> > + * Alistair Francis <alistair@alistair23.me> > + */ > + > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/slab.h> > +#include <linux/jiffies.h> > +#include <linux/hwmon.h> > +#include <linux/hwmon-sysfs.h> > +#include <linux/err.h> > +#include <linux/sysfs.h> > +#include <linux/platform_device.h> > + > +#include <linux/mfd/sy7636a.h> > + Alphabetic include file order please, and drop the includes which are not needed (I don't see a need for slab.h or jiffies.h). On the other side, the include of regmap.h is missing. > +static ssize_t show_temp(struct device *dev, > + struct device_attribute *attr, char *buf) If you use continuation lines, please align with "(". > +{ > + unsigned int reg_val; > + struct regmap *regmap = dev_get_drvdata(dev); > + int ret; > + > + ret = regmap_read(regmap, > + SY7636A_REG_TERMISTOR_READOUT, ®_val); Line length limit is now 100, so this continuation line should not be needed. > + if (ret) > + return ret; > + > + return snprintf(buf, PAGE_SIZE, "%d\n", reg_val); > +} > + > +static SENSOR_DEVICE_ATTR(temp0, 0444, show_temp, NULL, 0); > + > +static struct attribute *sy7636a_attrs[] = { > + &sensor_dev_attr_temp0.dev_attr.attr, FWIW, there is no "temp0" in the hwmon ABI. Temperature sensor numbering starts with 1. Not that it matters, devm_hwmon_device_register_with_info() creates attributes internally. > + NULL > +}; > + > +ATTRIBUTE_GROUPS(sy7636a); > + > +static int sy7636a_sensor_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL); > + struct device *hwmon_dev; > + int err; > + > + if (!regmap) > + return -EPROBE_DEFER; > + > + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, > + "sy7636a_temperature", regmap, sy7636a_groups); > + Please use devm_hwmon_device_register_with_info(). > + if (IS_ERR(hwmon_dev)) { > + err = PTR_ERR(hwmon_dev); > + dev_err(&pdev->dev, "Unable to register hwmon device, returned %d", err); I dislike driver noise, but if it is retained please add "\n". > + return err; > + } > + > + return 0; > +} > + > +static struct platform_driver sy7636a_sensor_driver = { > + .probe = sy7636a_sensor_probe, > + .driver = { > + .name = "sy7636a-temperature", > + }, > +}; > +module_platform_driver(sy7636a_sensor_driver); > + > +MODULE_DESCRIPTION("SY7636A sensor driver"); > +MODULE_LICENSE("GPL"); >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Alistair Francis <alistair@alistair23.me>, lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, kernel@pengutronix.de Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, amitk@kernel.org, rui.zhang@intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alistair23@gmail.com, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v12 06/10] hwmon: sy7636a: Add temperature driver for sy7636a Date: Sat, 9 Oct 2021 06:49:50 -0700 [thread overview] Message-ID: <0ac0f13e-12eb-2272-3d4b-480dc6b54ee1@roeck-us.net> (raw) In-Reply-To: <20211009115031.18392-10-alistair@alistair23.me> On 10/9/21 4:50 AM, Alistair Francis wrote: > This is a multi-function device to interface with the sy7636a > EPD PMIC chip from Silergy. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > arch/arm/configs/imx_v6_v7_defconfig | 1 + That should be a separate patch. > drivers/hwmon/Kconfig | 10 ++++ > drivers/hwmon/Makefile | 1 + > drivers/hwmon/sy7636a-hwmon.c | 77 ++++++++++++++++++++++++++++ Documentation/hwmon/sy7636a-hwmon is missing. > 4 files changed, 89 insertions(+) > create mode 100644 drivers/hwmon/sy7636a-hwmon.c > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index 8a54a4d0181a..b87adf823e44 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -228,6 +228,7 @@ CONFIG_RN5T618_POWER=m > CONFIG_SENSORS_MC13783_ADC=y > CONFIG_SENSORS_GPIO_FAN=y > CONFIG_SENSORS_IIO_HWMON=y > +CONFIG_SENSORS_SY7636A=y > CONFIG_THERMAL_STATISTICS=y > CONFIG_THERMAL_WRITABLE_TRIPS=y > CONFIG_CPU_THERMAL=y > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index c4578e8f34bb..59f358293202 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1651,6 +1651,16 @@ config SENSORS_SIS5595 > This driver can also be built as a module. If so, the module > will be called sis5595. > > +config SENSORS_SY7636A > + tristate "Silergy SY7636A" > + depends on I2C That is an arbitrary dependency. The driver doesn't use I2C. > + help > + If you say yes here you get support for the thermistor readout of > + the Silergy SY7636A PMIC. > + > + This driver can also be built as a module. If so, the module > + will be called sy7636a-hwmon. > + > config SENSORS_DME1737 > tristate "SMSC DME1737, SCH311x and compatibles" > depends on I2C && !PPC > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 162940270661..1355ffdb1481 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -181,6 +181,7 @@ obj-$(CONFIG_SENSORS_SMSC47M1) += smsc47m1.o > obj-$(CONFIG_SENSORS_SMSC47M192)+= smsc47m192.o > obj-$(CONFIG_SENSORS_SPARX5) += sparx5-temp.o > obj-$(CONFIG_SENSORS_STTS751) += stts751.o > +obj-$(CONFIG_SENSORS_SY7636A) += sy7636a-hwmon.o > obj-$(CONFIG_SENSORS_AMC6821) += amc6821.o > obj-$(CONFIG_SENSORS_TC74) += tc74.o > obj-$(CONFIG_SENSORS_THMC50) += thmc50.o > diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c > new file mode 100644 > index 000000000000..e0204278339b > --- /dev/null > +++ b/drivers/hwmon/sy7636a-hwmon.c > @@ -0,0 +1,77 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Functions to access SY3686A power management chip temperature > + * > + * Copyright (C) 2019 reMarkable AS - http://www.remarkable.com/ > + * > + * Authors: Lars Ivar Miljeteig <lars.ivar.miljeteig@remarkable.com> > + * Alistair Francis <alistair@alistair23.me> > + */ > + > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/slab.h> > +#include <linux/jiffies.h> > +#include <linux/hwmon.h> > +#include <linux/hwmon-sysfs.h> > +#include <linux/err.h> > +#include <linux/sysfs.h> > +#include <linux/platform_device.h> > + > +#include <linux/mfd/sy7636a.h> > + Alphabetic include file order please, and drop the includes which are not needed (I don't see a need for slab.h or jiffies.h). On the other side, the include of regmap.h is missing. > +static ssize_t show_temp(struct device *dev, > + struct device_attribute *attr, char *buf) If you use continuation lines, please align with "(". > +{ > + unsigned int reg_val; > + struct regmap *regmap = dev_get_drvdata(dev); > + int ret; > + > + ret = regmap_read(regmap, > + SY7636A_REG_TERMISTOR_READOUT, ®_val); Line length limit is now 100, so this continuation line should not be needed. > + if (ret) > + return ret; > + > + return snprintf(buf, PAGE_SIZE, "%d\n", reg_val); > +} > + > +static SENSOR_DEVICE_ATTR(temp0, 0444, show_temp, NULL, 0); > + > +static struct attribute *sy7636a_attrs[] = { > + &sensor_dev_attr_temp0.dev_attr.attr, FWIW, there is no "temp0" in the hwmon ABI. Temperature sensor numbering starts with 1. Not that it matters, devm_hwmon_device_register_with_info() creates attributes internally. > + NULL > +}; > + > +ATTRIBUTE_GROUPS(sy7636a); > + > +static int sy7636a_sensor_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL); > + struct device *hwmon_dev; > + int err; > + > + if (!regmap) > + return -EPROBE_DEFER; > + > + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, > + "sy7636a_temperature", regmap, sy7636a_groups); > + Please use devm_hwmon_device_register_with_info(). > + if (IS_ERR(hwmon_dev)) { > + err = PTR_ERR(hwmon_dev); > + dev_err(&pdev->dev, "Unable to register hwmon device, returned %d", err); I dislike driver noise, but if it is retained please add "\n". > + return err; > + } > + > + return 0; > +} > + > +static struct platform_driver sy7636a_sensor_driver = { > + .probe = sy7636a_sensor_probe, > + .driver = { > + .name = "sy7636a-temperature", > + }, > +}; > +module_platform_driver(sy7636a_sensor_driver); > + > +MODULE_DESCRIPTION("SY7636A sensor driver"); > +MODULE_LICENSE("GPL"); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-09 13:49 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-09 11:50 [PATCH v12 00/10] Add support for the silergy,sy7636a Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:50 ` [PATCH v12 01/10] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis 2021-10-09 11:50 ` [PATCH v12 01/10] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml Alistair Francis 2021-10-09 11:50 ` [PATCH v12 02/10] mfd: simple-mfd-i2c: Add a Kconfig name Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:50 ` [PATCH 3/7] capsules: symmetric_encryption/aes: Reduce code size Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:55 ` Alistair Francis 2021-10-09 11:55 ` Alistair Francis 2021-10-09 11:50 ` [PATCH v12 03/10] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Alistair Francis 2021-10-09 11:50 ` [PATCH v12 03/10] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a Alistair Francis 2021-10-09 11:50 ` [PATCH 4/7] capsules: sha: Continue reducing code size Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:56 ` Alistair Francis 2021-10-09 11:56 ` Alistair Francis 2021-10-09 11:50 ` [PATCH v12 04/10] regulator: sy7636a: Remove requirement on sy7636a mfd Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:50 ` [PATCH 5/7] capsules: hmac: Continue reducing code size Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:56 ` Alistair Francis 2021-10-09 11:56 ` Alistair Francis 2021-10-09 11:50 ` [PATCH v12 05/10] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 23:49 ` Guenter Roeck 2021-10-09 23:49 ` Guenter Roeck 2021-10-09 11:50 ` [PATCH v12 06/10] hwmon: sy7636a: Add temperature " Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 13:49 ` Guenter Roeck [this message] 2021-10-09 13:49 ` Guenter Roeck 2021-10-09 11:50 ` [PATCH v12 07/10] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 11:50 ` [PATCH v12 08/10] ARM: dts: imx7d: remarkable2: " Alistair Francis 2021-10-09 11:50 ` [PATCH v12 08/10] ARM: dts: imx7d: remarkable2: Enable silergy, sy7636a Alistair Francis 2021-10-09 11:50 ` [PATCH v12 09/10] ARM: imx_v6_v7_defconfig: Enable backlight class devices Alistair Francis 2021-10-09 11:50 ` Alistair Francis 2021-10-09 14:29 ` Fabio Estevam 2021-10-09 14:29 ` Fabio Estevam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ac0f13e-12eb-2272-3d4b-480dc6b54ee1@roeck-us.net \ --to=linux@roeck-us.net \ --cc=alistair23@gmail.com \ --cc=alistair@alistair23.me \ --cc=amitk@kernel.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.