* [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing
@ 2020-12-29 13:50 ` Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-29 13:50 UTC (permalink / raw)
To: rmfrfs, johan, elder, gregkh, devel, linux-kernel; +Cc: Zheng Yongjun
Use kzalloc rather than kcalloc(1,...)
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
- kcalloc(1,
+ kzalloc(
...)
// </smpl>
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/staging/greybus/light.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index d2672b65c3f4..d227382fca20 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);
if (!channel->attrs)
return -ENOMEM;
- channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),
+ channel->attr_group = kzalloc(sizeof(*channel->attr_group),
GFP_KERNEL);
if (!channel->attr_group)
return -ENOMEM;
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing
@ 2020-12-29 13:50 ` Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-29 13:50 UTC (permalink / raw)
To: rmfrfs, johan, elder, gregkh, devel, linux-kernel; +Cc: Zheng Yongjun
Use kzalloc rather than kcalloc(1,...)
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
- kcalloc(1,
+ kzalloc(
...)
// </smpl>
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/staging/greybus/light.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index d2672b65c3f4..d227382fca20 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);
if (!channel->attrs)
return -ENOMEM;
- channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),
+ channel->attr_group = kzalloc(sizeof(*channel->attr_group),
GFP_KERNEL);
if (!channel->attr_group)
return -ENOMEM;
--
2.22.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing
2020-12-29 13:50 ` Zheng Yongjun
@ 2020-12-29 13:54 ` Alex Elder
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2020-12-29 13:54 UTC (permalink / raw)
To: Zheng Yongjun, rmfrfs, johan, elder, gregkh, devel, linux-kernel
On 12/29/20 7:50 AM, Zheng Yongjun wrote:
> Use kzalloc rather than kcalloc(1,...)
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
> ...)
> // </smpl>
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/greybus/light.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index d2672b65c3f4..d227382fca20 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
> channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);
> if (!channel->attrs)
> return -ENOMEM;
> - channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),
> + channel->attr_group = kzalloc(sizeof(*channel->attr_group),
> GFP_KERNEL);
Looks good but that shortens the line enough to avoid a line wrap.
Please send v2 with GFP_KERNEL on the same line as the kzalloc()
call.
-Alex
> if (!channel->attr_group)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing
@ 2020-12-29 13:54 ` Alex Elder
0 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2020-12-29 13:54 UTC (permalink / raw)
To: Zheng Yongjun, rmfrfs, johan, elder, gregkh, devel, linux-kernel
On 12/29/20 7:50 AM, Zheng Yongjun wrote:
> Use kzalloc rather than kcalloc(1,...)
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
> ...)
> // </smpl>
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/greybus/light.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index d2672b65c3f4..d227382fca20 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
> channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);
> if (!channel->attrs)
> return -ENOMEM;
> - channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),
> + channel->attr_group = kzalloc(sizeof(*channel->attr_group),
> GFP_KERNEL);
Looks good but that shortens the line enough to avoid a line wrap.
Please send v2 with GFP_KERNEL on the same line as the kzalloc()
call.
-Alex
> if (!channel->attr_group)
> return -ENOMEM;
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-29 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 13:50 [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing Zheng Yongjun
2020-12-29 13:50 ` Zheng Yongjun
2020-12-29 13:54 ` Alex Elder
2020-12-29 13:54 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.