Re: [PATCH net] net: dsa: sja1105: fix use-after-free after calling of_find_compatible_node, or worse

["Alvin Šipraga" <ALSI@bang-olufsen.dk>]

[-- Attachment #1: Type: text/plain, Size: 2804 bytes --]

Hi Vladimir,

On 8/18/21 12:31 AM, Vladimir Oltean wrote:
> 
> So it's a circular dependency? Switch cannot finish probing because it
> cannot connect to PHY, which cannot probe because switch has not
> finished probing, which....
> 
> So how is it supposed to be solved then? Intuitively the 'mdio_bus SMI-0:00'
> device should not be added to the deferred list, it should have everything
> it needs right now (after all, it works without fw_devlink). No?

If I understand correctly, it's just the probing of the PHY driver that 
is getting deferred. This happens both when everything is builtin, and 
when the switch driver (realtek-smi in my case) is built as a module. 
Additionally, when the switch is finished probing, the PHY driver 
doesn't actually get probed. I'm not sure if this is because it has been 
replaced with the Generic PHY driver in the mean time.

What's strange is that if I unload the switch driver module and reload 
it, this time the PHY driver _does_ get probed on demand. I have 
attached a debug log which illustrates the difference. Please note that 
this is using a subdriver of realtek-smi which I have not yet posted to 
the list, but the semantics are the pretty much same as rtl8366rb. See here:

1st load:

[   83.659809] device_add:3270: device: 'SMI-0:00': device_add
[   83.659883] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:00
[   83.659970] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:00
[   83.660122] device_add:3270: device: 
'platform:ethernet-switch--mdio_bus:SMI-0:00': device_add
[   83.660274] devices_kset_move_last:2701: devices_kset: Moving 
SMI-0:00 to end of list
[   83.660282] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:00 to 
end of list
[   83.660293] device_link_add:859: mdio_bus SMI-0:00: Linked as a 
consumer to ethernet-switch
[   83.660350] __driver_probe_device:736: bus: 'mdio_bus': 
__driver_probe_device: matched device SMI-0:00 with driver RTL8365MB-VC 
Gigabit Ethernet
[   83.660365] device_links_check_suppliers:1001: mdio_bus SMI-0:00: 
probe deferral - supplier ethernet-switch not ready

2nd load:

[  138.945901] device_add:3270: device: 'SMI-0:00': device_add
[  138.946003] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:00
[  138.946097] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:00
[  138.946309] __driver_probe_device:736: bus: 'mdio_bus': 
__driver_probe_device: matched device SMI-0:00 with driver RTL8365MB-VC 
Gigabit Ethernet
[  138.946326] really_probe:561: bus: 'mdio_bus': really_probe: probing 
driver RTL8365MB-VC Gigabit Ethernet with device SMI-0:00

I don't know the gory details of the driver core so I am reluctant to 
provide an explanation, but I hope it makes things clear.

Kind regards,
Alvin

[-- Attachment #2: dmesg.txt --]
[-- Type: text/plain, Size: 37089 bytes --]

[   83.374196] bus_add_driver:600: bus: 'platform': add driver realtek-smi
[   83.374409] __driver_probe_device:736: bus: 'platform': __driver_probe_device: matched device ethernet-switch with driver realtek-smi
[   83.374427] really_probe:561: bus: 'platform': really_probe: probing driver realtek-smi with device ethernet-switch
[   83.374469] pinctrl_bind_pins:34: realtek-smi ethernet-switch: no pinctrl handle
[   83.374487] of_dma_configure_id:151: realtek-smi ethernet-switch: device is not dma coherent
[   83.374497] of_dma_configure_id:163: realtek-smi ethernet-switch: device is not behind an iommu
[   83.516721] realtek-smi ethernet-switch: deasserted RESET
[   83.517239] realtek-smi ethernet-switch: found an RTL8365MB-VC switch (ver=0x0040)
[   83.652325] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/interrupt-controller, index=0
[   83.652351] of_irq_parse_one:319: OF:  parent=/soc@0/bus@30000000/gpio@30230000, intsize=2
[   83.652366] of_irq_parse_one:332: OF:  intspec=31
[   83.652372] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/soc@0/bus@30000000/gpio@30230000, size=2
[   83.652386] of_irq_parse_raw:143: OF:  -> addrsize=1
[   83.652391] of_irq_parse_raw:163: OF:  -> got it !
[   83.653213] device_add:3270: device: 'SMI-0': device_add
[   83.653905] device_pm_add:136: PM: Adding info for No Bus:SMI-0
[   83.654055] device_add:3270: device: 'platform:ethernet-switch--mdio_bus:SMI-0': device_add
[   83.654224] device_link_add:843: mdio_bus SMI-0: Linked as a sync state only consumer to ethernet-switch
[   83.654291] libphy: SMI slave MII: probed
[   83.659598] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@0, index=0
[   83.659687] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[   83.659699] of_irq_parse_one:332: OF:  intspec=0
[   83.659705] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[   83.659716] of_irq_parse_raw:143: OF:  -> addrsize=0
[   83.659722] of_irq_parse_raw:163: OF:  -> got it !
[   83.659809] device_add:3270: device: 'SMI-0:00': device_add
[   83.659883] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:00
[   83.659970] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:00
[   83.660122] device_add:3270: device: 'platform:ethernet-switch--mdio_bus:SMI-0:00': device_add
[   83.660274] devices_kset_move_last:2701: devices_kset: Moving SMI-0:00 to end of list
[   83.660282] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:00 to end of list
[   83.660293] device_link_add:859: mdio_bus SMI-0:00: Linked as a consumer to ethernet-switch
[   83.660350] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:00 with driver RTL8365MB-VC Gigabit Ethernet
[   83.660365] device_links_check_suppliers:1001: mdio_bus SMI-0:00: probe deferral - supplier ethernet-switch not ready
[   83.660376] driver_deferred_probe_add:138: mdio_bus SMI-0:00: Added to deferred list
[   83.660388] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0b990 fwnode at address 0
[   83.665538] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@1, index=0
[   83.665578] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[   83.665590] of_irq_parse_one:332: OF:  intspec=1
[   83.665596] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[   83.665607] of_irq_parse_raw:143: OF:  -> addrsize=0
[   83.665613] of_irq_parse_raw:163: OF:  -> got it !
[   83.665693] device_add:3270: device: 'SMI-0:01': device_add
[   83.665765] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:01
[   83.665846] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:01
[   83.665993] device_add:3270: device: 'platform:ethernet-switch--mdio_bus:SMI-0:01': device_add
[   83.666155] devices_kset_move_last:2701: devices_kset: Moving SMI-0:01 to end of list
[   83.666164] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:01 to end of list
[   83.666176] device_link_add:859: mdio_bus SMI-0:01: Linked as a consumer to ethernet-switch
[   83.666241] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:01 with driver RTL8365MB-VC Gigabit Ethernet
[   83.666258] device_links_check_suppliers:1001: mdio_bus SMI-0:01: probe deferral - supplier ethernet-switch not ready
[   83.666270] driver_deferred_probe_add:138: mdio_bus SMI-0:01: Added to deferred list
[   83.666282] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0bc50 fwnode at address 1
[   83.673533] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@2, index=0
[   83.673584] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[   83.673596] of_irq_parse_one:332: OF:  intspec=2
[   83.673602] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[   83.673613] of_irq_parse_raw:143: OF:  -> addrsize=0
[   83.673619] of_irq_parse_raw:163: OF:  -> got it !
[   83.673715] device_add:3270: device: 'SMI-0:02': device_add
[   83.673816] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:02
[   83.673890] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:02
[   83.674108] device_add:3270: device: 'platform:ethernet-switch--mdio_bus:SMI-0:02': device_add
[   83.674306] devices_kset_move_last:2701: devices_kset: Moving SMI-0:02 to end of list
[   83.674315] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:02 to end of list
[   83.674327] device_link_add:859: mdio_bus SMI-0:02: Linked as a consumer to ethernet-switch
[   83.674391] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:02 with driver RTL8365MB-VC Gigabit Ethernet
[   83.674408] device_links_check_suppliers:1001: mdio_bus SMI-0:02: probe deferral - supplier ethernet-switch not ready
[   83.674420] driver_deferred_probe_add:138: mdio_bus SMI-0:02: Added to deferred list
[   83.674433] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0bf10 fwnode at address 2
[   83.681037] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@3, index=0
[   83.681076] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[   83.681088] of_irq_parse_one:332: OF:  intspec=3
[   83.681094] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[   83.681105] of_irq_parse_raw:143: OF:  -> addrsize=0
[   83.681110] of_irq_parse_raw:163: OF:  -> got it !
[   83.681195] device_add:3270: device: 'SMI-0:03': device_add
[   83.681266] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:03
[   83.681349] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:03
[   83.681490] device_add:3270: device: 'platform:ethernet-switch--mdio_bus:SMI-0:03': device_add
[   83.681646] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[   83.681653] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[   83.681664] device_link_add:859: mdio_bus SMI-0:03: Linked as a consumer to ethernet-switch
[   83.681720] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:03 with driver RTL8365MB-VC Gigabit Ethernet
[   83.681735] device_links_check_suppliers:1001: mdio_bus SMI-0:03: probe deferral - supplier ethernet-switch not ready
[   83.681746] driver_deferred_probe_add:138: mdio_bus SMI-0:03: Added to deferred list
[   83.681757] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0c1d0 fwnode at address 3
[   83.682997] __device_link_del:876: Generic PHY SMI-0:00: Dropping the link to ethernet-switch
[   83.683012] device_unregister:3574: device: 'platform:ethernet-switch--mdio_bus:SMI-0:00': device_unregister
[   83.683207] driver_bound:382: driver: 'Generic PHY': driver_bound: bound to device 'SMI-0:00'
[   83.683228] driver_deferred_probe_del:148: Generic PHY SMI-0:00: Removed from deferred list
[   83.683282] devices_kset_move_last:2701: devices_kset: Moving SMI-0:01 to end of list
[   83.683292] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:01 to end of list
[   83.683302] deferred_probe_work_func:121: mdio_bus SMI-0:01: Retrying from deferred list
[   83.683332] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:01 with driver RTL8365MB-VC Gigabit Ethernet
[   83.683347] device_links_check_suppliers:1001: mdio_bus SMI-0:01: probe deferral - supplier ethernet-switch not ready
[   83.683358] driver_deferred_probe_add:138: mdio_bus SMI-0:01: Added to deferred list
[   83.683367] devices_kset_move_last:2701: devices_kset: Moving SMI-0:02 to end of list
[   83.683373] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:02 to end of list
[   83.683380] deferred_probe_work_func:121: mdio_bus SMI-0:02: Retrying from deferred list
[   83.683395] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:02 with driver RTL8365MB-VC Gigabit Ethernet
[   83.683404] device_links_check_suppliers:1001: mdio_bus SMI-0:02: probe deferral - supplier ethernet-switch not ready
[   83.683412] driver_deferred_probe_add:138: mdio_bus SMI-0:02: Added to deferred list
[   83.683419] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[   83.683425] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[   83.683432] deferred_probe_work_func:121: mdio_bus SMI-0:03: Retrying from deferred list
[   83.683446] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:03 with driver RTL8365MB-VC Gigabit Ethernet
[   83.683455] device_links_check_suppliers:1001: mdio_bus SMI-0:03: probe deferral - supplier ethernet-switch not ready
[   83.683463] driver_deferred_probe_add:138: mdio_bus SMI-0:03: Added to deferred list
[   83.683852] realtek-smi ethernet-switch swp0 (uninitialized): PHY [SMI-0:00] driver [Generic PHY] (irq=POLL)
[   83.683867] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp0 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[   83.683919] device_add:3270: device: 'swp0': device_add
[   83.684285] device_pm_add:136: PM: Adding info for No Bus:swp0
[   83.690497] __device_link_del:876: Generic PHY SMI-0:01: Dropping the link to ethernet-switch
[   83.690520] device_unregister:3574: device: 'platform:ethernet-switch--mdio_bus:SMI-0:01': device_unregister
[   83.690734] driver_bound:382: driver: 'Generic PHY': driver_bound: bound to device 'SMI-0:01'
[   83.690763] driver_deferred_probe_del:148: Generic PHY SMI-0:01: Removed from deferred list
[   83.691166] devices_kset_move_last:2701: devices_kset: Moving SMI-0:02 to end of list
[   83.691180] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:02 to end of list
[   83.691194] deferred_probe_work_func:121: mdio_bus SMI-0:02: Retrying from deferred list
[   83.691224] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:02 with driver RTL8365MB-VC Gigabit Ethernet
[   83.691239] device_links_check_suppliers:1001: mdio_bus SMI-0:02: probe deferral - supplier ethernet-switch not ready
[   83.691250] driver_deferred_probe_add:138: mdio_bus SMI-0:02: Added to deferred list
[   83.691259] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[   83.691265] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[   83.691273] deferred_probe_work_func:121: mdio_bus SMI-0:03: Retrying from deferred list
[   83.691287] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:03 with driver RTL8365MB-VC Gigabit Ethernet
[   83.691297] device_links_check_suppliers:1001: mdio_bus SMI-0:03: probe deferral - supplier ethernet-switch not ready
[   83.691305] driver_deferred_probe_add:138: mdio_bus SMI-0:03: Added to deferred list
[   83.691433] realtek-smi ethernet-switch swp1 (uninitialized): PHY [SMI-0:01] driver [Generic PHY] (irq=POLL)
[   83.691450] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp1 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[   83.691540] device_add:3270: device: 'swp1': device_add
[   83.691908] device_pm_add:136: PM: Adding info for No Bus:swp1
[   83.708741] __device_link_del:876: Generic PHY SMI-0:02: Dropping the link to ethernet-switch
[   83.708757] device_unregister:3574: device: 'platform:ethernet-switch--mdio_bus:SMI-0:02': device_unregister
[   83.708979] driver_bound:382: driver: 'Generic PHY': driver_bound: bound to device 'SMI-0:02'
[   83.709011] driver_deferred_probe_del:148: Generic PHY SMI-0:02: Removed from deferred list
[   83.709647] realtek-smi ethernet-switch swp2 (uninitialized): PHY [SMI-0:02] driver [Generic PHY] (irq=POLL)
[   83.709665] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp2 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[   83.709756] device_add:3270: device: 'swp2': device_add
[   83.710102] device_pm_add:136: PM: Adding info for No Bus:swp2
[   83.710765] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[   83.710784] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[   83.710799] deferred_probe_work_func:121: mdio_bus SMI-0:03: Retrying from deferred list
[   83.710832] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:03 with driver RTL8365MB-VC Gigabit Ethernet
[   83.710847] device_links_check_suppliers:1001: mdio_bus SMI-0:03: probe deferral - supplier ethernet-switch not ready
[   83.710860] driver_deferred_probe_add:138: mdio_bus SMI-0:03: Added to deferred list
[   83.713895] __device_link_del:876: Generic PHY SMI-0:03: Dropping the link to ethernet-switch
[   83.713919] device_unregister:3574: device: 'platform:ethernet-switch--mdio_bus:SMI-0:03': device_unregister
[   83.714185] driver_bound:382: driver: 'Generic PHY': driver_bound: bound to device 'SMI-0:03'
[   83.714243] driver_deferred_probe_del:148: Generic PHY SMI-0:03: Removed from deferred list
[   83.715325] realtek-smi ethernet-switch swp3 (uninitialized): PHY [SMI-0:03] driver [Generic PHY] (irq=POLL)
[   83.715349] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp3 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[   83.715412] device_add:3270: device: 'swp3': device_add
[   83.715855] device_pm_add:136: PM: Adding info for No Bus:swp3
[   83.726038] DSA: failed to set STP state 3 (-95)
[   83.726045] realtek-smi ethernet-switch: configuring for fixed/rgmii-id link mode
[   83.726058] phylink_major_config:454: realtek-smi ethernet-switch: major config rgmii-id
[   83.726068] phylink_mac_config:425: realtek-smi ethernet-switch: phylink_mac_config: mode=fixed/rgmii-id/1Gbps/Full adv=0000000,00000000,00006260 pause=03 link=0 an=1
[   83.726539] device_add:3270: device: 'platform:30be0000.ethernet--platform:ethernet-switch': device_add
[   83.726747] devices_kset_move_last:2701: devices_kset: Moving ethernet-switch to end of list
[   83.726755] device_pm_move_last:203: PM: Moving platform:ethernet-switch to end of list
[   83.726762] devices_kset_move_last:2701: devices_kset: Moving SMI-0 to end of list
[   83.726768] device_pm_move_last:203: PM: Moving No Bus:SMI-0 to end of list
[   83.726774] devices_kset_move_last:2701: devices_kset: Moving SMI-0:00 to end of list
[   83.726781] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:00 to end of list
[   83.726788] devices_kset_move_last:2701: devices_kset: Moving SMI-0:01 to end of list
[   83.726794] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:01 to end of list
[   83.726800] devices_kset_move_last:2701: devices_kset: Moving SMI-0:02 to end of list
[   83.726806] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:02 to end of list
[   83.726813] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[   83.726818] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[   83.726825] devices_kset_move_last:2701: devices_kset: Moving swp0 to end of list
[   83.726831] device_pm_move_last:203: PM: Moving No Bus:swp0 to end of list
[   83.726837] devices_kset_move_last:2701: devices_kset: Moving swp1 to end of list
[   83.726843] device_pm_move_last:203: PM: Moving No Bus:swp1 to end of list
[   83.726848] devices_kset_move_last:2701: devices_kset: Moving swp2 to end of list
[   83.726854] device_pm_move_last:203: PM: Moving No Bus:swp2 to end of list
[   83.726860] devices_kset_move_last:2701: devices_kset: Moving swp3 to end of list
[   83.726865] device_pm_move_last:203: PM: Moving No Bus:swp3 to end of list
[   83.726875] device_link_add:859: realtek-smi ethernet-switch: Linked as a consumer to 30be0000.ethernet
[   83.727000] DSA: tree 0 setup
[   83.727011] driver_bound:382: driver: 'realtek-smi': driver_bound: bound to device 'ethernet-switch'
[   83.727052] __device_link_del:876: realtek-smi ethernet-switch: Dropping the link to 30230000.gpio
[   83.727060] device_unregister:3574: device: 'platform:30230000.gpio--platform:ethernet-switch': device_unregister
[   83.727219] __device_link_del:876: realtek-smi ethernet-switch: Dropping the link to ethernet-switch
[   83.727227] device_unregister:3574: device: 'platform:ethernet-switch--platform:ethernet-switch': device_unregister
[   83.727436] really_probe:644: bus: 'platform': really_probe: bound device ethernet-switch to driver realtek-smi
[   83.728496] phylink_mac_config:425: realtek-smi ethernet-switch: phylink_mac_config: mode=fixed/rgmii-id/1Gbps/Full adv=0000000,00000000,00006260 pause=03 link=1 an=1
[   83.729182] realtek-smi ethernet-switch: Link is Up - 1Gbps/Full - flow control rx/tx
[   83.920969] br0: port 1(brwan0) entered disabled state
[   83.923179] br0: port 3(swp2) entered blocking state
[   83.923201] br0: port 3(swp2) entered disabled state
[   83.923594] realtek-smi ethernet-switch: enable filtering on port 2
[   83.923627] device swp2 entered promiscuous mode
[   83.924034] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[   83.964396] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[   83.964417] realtek-smi ethernet-switch: port is DSA or CPU port
[   84.052238] driver_bound:382: driver: 'Generic PHY': driver_bound: bound to device 'fixed-0:00'
[   84.052584] Generic PHY fixed-0:00: attached PHY driver (mii_bus:phy_addr=fixed-0:00, irq=POLL)
[   84.053854] fec 30be0000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx
[   84.053878] phy_state_machine:1145: Generic PHY fixed-0:00: PHY state change UP -> RUNNING
[   84.072768] device_unregister:3574: device: 'wakeup3': device_unregister
[   84.073651] device eth0 entered promiscuous mode
[   84.074771] realtek-smi ethernet-switch swp2: configuring for phy/ link mode
[   84.074786] phylink_major_config:454: realtek-smi ethernet-switch swp2: major config 
[   84.074796] phylink_mac_config:425: realtek-smi ethernet-switch swp2: phylink_mac_config: mode=phy//Unknown/Unknown adv=0000000,00000000,00000000 pause=00 link=0 an=0
[   84.081841] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[   84.083377] phylink_phy_change:945: realtek-smi ethernet-switch swp2: phy link down /Unknown/Unknown
[   84.083393] phy_state_machine:1145: Generic PHY SMI-0:02: PHY state change UP -> NOLINK
[   84.086760] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[   84.086772] realtek-smi ethernet-switch: port is DSA or CPU port
[   87.136746] phylink_phy_change:945: realtek-smi ethernet-switch swp2: phy link up /1Gbps/Full
[   87.136767] phy_state_machine:1145: Generic PHY SMI-0:02: PHY state change NOLINK -> RUNNING
[   87.136780] phylink_mac_config:425: realtek-smi ethernet-switch swp2: phylink_mac_config: mode=phy//1Gbps/Full adv=0000000,00000000,00000000 pause=03 link=1 an=0
[   87.136809] realtek-smi ethernet-switch swp2: Link is Up - 1Gbps/Full - flow control rx/tx
[   87.136855] br0: port 3(swp2) entered blocking state
[   87.136868] br0: port 3(swp2) entered forwarding state
[   87.171073] br0: port 1(brwan0) entered blocking state
[   87.171106] br0: port 1(brwan0) entered forwarding state
[   87.325549] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[   87.329594] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[   87.329612] realtek-smi ethernet-switch: port is DSA or CPU port
[   87.387104] device_add:3270: device: 'lo': device_add
[   87.387457] device_pm_add:136: PM: Adding info for No Bus:lo
[  117.873950] device_pm_remove:157: PM: Removing info for No Bus:lo
[  134.225421] bus_remove_driver:674: bus: 'platform': remove driver realtek-smi
[  134.270168] device_pm_remove:157: PM: Removing info for No Bus:swp0
[  134.370066] device_pm_remove:157: PM: Removing info for No Bus:swp1
[  134.481366] phylink_phy_change:945: realtek-smi ethernet-switch swp2: phy link down /1Gbps/Full
[  134.483955] device eth0 left promiscuous mode
[  134.484472] br0: port 3(swp2) entered disabled state
[  134.513782] device swp2 left promiscuous mode
[  134.513818] br0: port 3(swp2) entered disabled state
[  134.513963] realtek-smi ethernet-switch: del VLAN 0001 on port 2
[  134.529559] realtek-smi ethernet-switch: disable filtering on port 2
[  134.529583] DSA: failed to set STP state 3 (-95)
[  134.546619] device_pm_remove:157: PM: Removing info for No Bus:swp2
[  134.633024] br0: port 1(brwan0) entered disabled state
[  134.670303] device_pm_remove:157: PM: Removing info for No Bus:swp3
[  134.753163] realtek-smi ethernet-switch: Link is Down
[  134.753197] DSA: failed to set STP state 0 (-95)
[  134.753339] bus_remove_device:527: bus: 'mdio_bus': remove device SMI-0:00
[  134.753349] device_pm_remove:157: PM: Removing info for mdio_bus:SMI-0:00
[  134.753551] bus_remove_device:527: bus: 'mdio_bus': remove device SMI-0:01
[  134.753559] device_pm_remove:157: PM: Removing info for mdio_bus:SMI-0:01
[  134.753698] bus_remove_device:527: bus: 'mdio_bus': remove device SMI-0:02
[  134.753705] device_pm_remove:157: PM: Removing info for mdio_bus:SMI-0:02
[  134.753849] bus_remove_device:527: bus: 'mdio_bus': remove device SMI-0:03
[  134.753855] device_pm_remove:157: PM: Removing info for mdio_bus:SMI-0:03
[  134.754463] device_pm_remove:157: PM: Removing info for No Bus:SMI-0
[  134.754479] __device_link_del:876: mdio_bus SMI-0: Dropping the link to ethernet-switch
[  134.754487] device_unregister:3574: device: 'platform:ethernet-switch--mdio_bus:SMI-0': device_unregister
[  134.757201] DSA: tree 0 torn down
[  134.758604] __device_link_del:876: realtek-smi ethernet-switch: Dropping the link to 30be0000.ethernet
[  134.758622] device_unregister:3574: device: 'platform:30be0000.ethernet--platform:ethernet-switch': device_unregister
[  134.759169] driver_release:90: driver: 'realtek-smi': driver_release
[  134.793043] device_add:3270: device: 'lo': device_add
[  134.793424] device_pm_add:136: PM: Adding info for No Bus:lo
[  138.674861] bus_add_driver:600: bus: 'platform': add driver realtek-smi
[  138.675096] __driver_probe_device:736: bus: 'platform': __driver_probe_device: matched device ethernet-switch with driver realtek-smi
[  138.675112] really_probe:561: bus: 'platform': really_probe: probing driver realtek-smi with device ethernet-switch
[  138.675157] pinctrl_bind_pins:34: realtek-smi ethernet-switch: no pinctrl handle
[  138.675175] of_dma_configure_id:151: realtek-smi ethernet-switch: device is not dma coherent
[  138.675185] of_dma_configure_id:163: realtek-smi ethernet-switch: device is not behind an iommu
[  138.820701] realtek-smi ethernet-switch: deasserted RESET
[  138.821180] realtek-smi ethernet-switch: found an RTL8365MB-VC switch (ver=0x0040)
[  138.937173] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/interrupt-controller, index=0
[  138.937195] of_irq_parse_one:319: OF:  parent=/soc@0/bus@30000000/gpio@30230000, intsize=2
[  138.937209] of_irq_parse_one:332: OF:  intspec=31
[  138.937214] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/soc@0/bus@30000000/gpio@30230000, size=2
[  138.937228] of_irq_parse_raw:143: OF:  -> addrsize=1
[  138.937234] of_irq_parse_raw:163: OF:  -> got it !
[  138.938252] device_add:3270: device: 'SMI-0': device_add
[  138.938879] device_pm_add:136: PM: Adding info for No Bus:SMI-0
[  138.939064] libphy: SMI slave MII: probed
[  138.945677] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@0, index=0
[  138.945729] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[  138.945742] of_irq_parse_one:332: OF:  intspec=0
[  138.945748] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[  138.945760] of_irq_parse_raw:143: OF:  -> addrsize=0
[  138.945766] of_irq_parse_raw:163: OF:  -> got it !
[  138.945901] device_add:3270: device: 'SMI-0:00': device_add
[  138.946003] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:00
[  138.946097] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:00
[  138.946309] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:00 with driver RTL8365MB-VC Gigabit Ethernet
[  138.946326] really_probe:561: bus: 'mdio_bus': really_probe: probing driver RTL8365MB-VC Gigabit Ethernet with device SMI-0:00
[  138.946379] pinctrl_bind_pins:34: RTL8365MB-VC Gigabit Ethernet SMI-0:00: no pinctrl handle
[  138.947516] driver_bound:382: driver: 'RTL8365MB-VC Gigabit Ethernet': driver_bound: bound to device 'SMI-0:00'
[  138.947729] really_probe:644: bus: 'mdio_bus': really_probe: bound device SMI-0:00 to driver RTL8365MB-VC Gigabit Ethernet
[  138.947763] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0b990 fwnode at address 0
[  138.955596] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@1, index=0
[  138.955650] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[  138.955662] of_irq_parse_one:332: OF:  intspec=1
[  138.955668] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[  138.955681] of_irq_parse_raw:143: OF:  -> addrsize=0
[  138.955687] of_irq_parse_raw:163: OF:  -> got it !
[  138.955792] device_add:3270: device: 'SMI-0:01': device_add
[  138.955888] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:01
[  138.955972] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:01
[  138.956191] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:01 with driver RTL8365MB-VC Gigabit Ethernet
[  138.956210] really_probe:561: bus: 'mdio_bus': really_probe: probing driver RTL8365MB-VC Gigabit Ethernet with device SMI-0:01
[  138.956266] pinctrl_bind_pins:34: RTL8365MB-VC Gigabit Ethernet SMI-0:01: no pinctrl handle
[  138.957465] driver_bound:382: driver: 'RTL8365MB-VC Gigabit Ethernet': driver_bound: bound to device 'SMI-0:01'
[  138.957672] really_probe:644: bus: 'mdio_bus': really_probe: bound device SMI-0:01 to driver RTL8365MB-VC Gigabit Ethernet
[  138.957704] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0bc50 fwnode at address 1
[  138.965135] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@2, index=0
[  138.965176] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[  138.965188] of_irq_parse_one:332: OF:  intspec=2
[  138.965193] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[  138.965205] of_irq_parse_raw:143: OF:  -> addrsize=0
[  138.965210] of_irq_parse_raw:163: OF:  -> got it !
[  138.965286] device_add:3270: device: 'SMI-0:02': device_add
[  138.965356] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:02
[  138.965427] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:02
[  138.965670] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:02 with driver RTL8365MB-VC Gigabit Ethernet
[  138.965686] really_probe:561: bus: 'mdio_bus': really_probe: probing driver RTL8365MB-VC Gigabit Ethernet with device SMI-0:02
[  138.965730] pinctrl_bind_pins:34: RTL8365MB-VC Gigabit Ethernet SMI-0:02: no pinctrl handle
[  138.972311] driver_bound:382: driver: 'RTL8365MB-VC Gigabit Ethernet': driver_bound: bound to device 'SMI-0:02'
[  138.972481] really_probe:644: bus: 'mdio_bus': really_probe: bound device SMI-0:02 to driver RTL8365MB-VC Gigabit Ethernet
[  138.972503] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0bf10 fwnode at address 2
[  138.982999] of_irq_parse_one:293: OF: of_irq_parse_one: dev=/ethernet-switch/mdio/phy@3, index=0
[  138.983047] of_irq_parse_one:319: OF:  parent=/ethernet-switch/interrupt-controller, intsize=1
[  138.983060] of_irq_parse_one:332: OF:  intspec=3
[  138.983066] of_irq_parse_raw:124: OF: of_irq_parse_raw: ipar=/ethernet-switch/interrupt-controller, size=1
[  138.983077] of_irq_parse_raw:143: OF:  -> addrsize=0
[  138.983083] of_irq_parse_raw:163: OF:  -> got it !
[  138.983177] device_add:3270: device: 'SMI-0:03': device_add
[  138.983257] bus_add_device:447: bus: 'mdio_bus': add device SMI-0:03
[  138.983358] device_pm_add:136: PM: Adding info for mdio_bus:SMI-0:03
[  138.983519] __driver_probe_device:736: bus: 'mdio_bus': __driver_probe_device: matched device SMI-0:03 with driver RTL8365MB-VC Gigabit Ethernet
[  138.983534] really_probe:561: bus: 'mdio_bus': really_probe: probing driver RTL8365MB-VC Gigabit Ethernet with device SMI-0:03
[  138.983583] pinctrl_bind_pins:34: RTL8365MB-VC Gigabit Ethernet SMI-0:03: no pinctrl handle
[  138.984715] driver_bound:382: driver: 'RTL8365MB-VC Gigabit Ethernet': driver_bound: bound to device 'SMI-0:03'
[  138.985118] really_probe:644: bus: 'mdio_bus': really_probe: bound device SMI-0:03 to driver RTL8365MB-VC Gigabit Ethernet
[  138.985150] fwnode_mdiobus_phy_device_register:79: mdio_bus SMI-0: registered phy ffff00003de0c1d0 fwnode at address 3
[  138.985941] realtek-smi ethernet-switch swp0 (uninitialized): PHY [SMI-0:00] driver [RTL8365MB-VC Gigabit Ethernet] (irq=221)
[  138.985963] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp0 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[  138.986092] device_add:3270: device: 'swp0': device_add
[  138.986453] device_pm_add:136: PM: Adding info for No Bus:swp0
[  138.997467] realtek-smi ethernet-switch swp1 (uninitialized): PHY [SMI-0:01] driver [RTL8365MB-VC Gigabit Ethernet] (irq=222)
[  138.997497] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp1 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[  138.997639] device_add:3270: device: 'swp1': device_add
[  138.998008] device_pm_add:136: PM: Adding info for No Bus:swp1
[  139.006406] realtek-smi ethernet-switch swp2 (uninitialized): PHY [SMI-0:02] driver [RTL8365MB-VC Gigabit Ethernet] (irq=223)
[  139.006439] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp2 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[  139.006627] device_add:3270: device: 'swp2': device_add
[  139.008270] device_pm_add:136: PM: Adding info for No Bus:swp2
[  139.010816] realtek-smi ethernet-switch swp3 (uninitialized): PHY [SMI-0:03] driver [RTL8365MB-VC Gigabit Ethernet] (irq=224)
[  139.010914] phylink_bringup_phy:1019: realtek-smi ethernet-switch swp3 (uninitialized): phy: setting supported 0000000,00000000,000062ef advertising 0000000,00000000,000062ef
[  139.011098] device_add:3270: device: 'swp3': device_add
[  139.011743] device_pm_add:136: PM: Adding info for No Bus:swp3
[  139.013288] DSA: failed to set STP state 3 (-95)
[  139.013294] realtek-smi ethernet-switch: configuring for fixed/rgmii-id link mode
[  139.013307] phylink_major_config:454: realtek-smi ethernet-switch: major config rgmii-id
[  139.013317] phylink_mac_config:425: realtek-smi ethernet-switch: phylink_mac_config: mode=fixed/rgmii-id/1Gbps/Full adv=0000000,00000000,00006260 pause=03 link=0 an=1
[  139.013785] device_add:3270: device: 'platform:30be0000.ethernet--platform:ethernet-switch': device_add
[  139.014013] devices_kset_move_last:2701: devices_kset: Moving ethernet-switch to end of list
[  139.014021] device_pm_move_last:203: PM: Moving platform:ethernet-switch to end of list
[  139.014029] devices_kset_move_last:2701: devices_kset: Moving SMI-0 to end of list
[  139.014034] device_pm_move_last:203: PM: Moving No Bus:SMI-0 to end of list
[  139.014041] devices_kset_move_last:2701: devices_kset: Moving SMI-0:00 to end of list
[  139.014047] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:00 to end of list
[  139.014054] devices_kset_move_last:2701: devices_kset: Moving SMI-0:01 to end of list
[  139.014060] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:01 to end of list
[  139.014066] devices_kset_move_last:2701: devices_kset: Moving SMI-0:02 to end of list
[  139.014072] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:02 to end of list
[  139.014079] devices_kset_move_last:2701: devices_kset: Moving SMI-0:03 to end of list
[  139.014084] device_pm_move_last:203: PM: Moving mdio_bus:SMI-0:03 to end of list
[  139.014091] devices_kset_move_last:2701: devices_kset: Moving swp0 to end of list
[  139.014097] device_pm_move_last:203: PM: Moving No Bus:swp0 to end of list
[  139.014104] devices_kset_move_last:2701: devices_kset: Moving swp1 to end of list
[  139.014110] device_pm_move_last:203: PM: Moving No Bus:swp1 to end of list
[  139.014117] devices_kset_move_last:2701: devices_kset: Moving swp2 to end of list
[  139.014122] device_pm_move_last:203: PM: Moving No Bus:swp2 to end of list
[  139.014128] devices_kset_move_last:2701: devices_kset: Moving swp3 to end of list
[  139.014134] device_pm_move_last:203: PM: Moving No Bus:swp3 to end of list
[  139.014143] device_link_add:859: realtek-smi ethernet-switch: Linked as a consumer to 30be0000.ethernet
[  139.014548] DSA: tree 0 setup
[  139.014565] driver_bound:382: driver: 'realtek-smi': driver_bound: bound to device 'ethernet-switch'
[  139.014709] really_probe:644: bus: 'platform': really_probe: bound device ethernet-switch to driver realtek-smi
[  139.018967] phylink_mac_config:425: realtek-smi ethernet-switch: phylink_mac_config: mode=fixed/rgmii-id/1Gbps/Full adv=0000000,00000000,00006260 pause=03 link=1 an=1
[  139.019281] realtek-smi ethernet-switch: Link is Up - 1Gbps/Full - flow control rx/tx
[  139.173698] br0: port 3(swp2) entered blocking state
[  139.173740] br0: port 3(swp2) entered disabled state
[  139.174273] realtek-smi ethernet-switch: enable filtering on port 2
[  139.174326] device swp2 entered promiscuous mode
[  139.174754] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[  139.221959] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[  139.221989] realtek-smi ethernet-switch: port is DSA or CPU port
[  139.236864] device eth0 entered promiscuous mode
[  139.238007] realtek-smi ethernet-switch swp2: configuring for phy/ link mode
[  139.238019] phylink_major_config:454: realtek-smi ethernet-switch swp2: major config 
[  139.238029] phylink_mac_config:425: realtek-smi ethernet-switch swp2: phylink_mac_config: mode=phy//Unknown/Unknown adv=0000000,00000000,00000000 pause=00 link=0 an=0
[  139.239141] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[  139.254043] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[  139.254065] realtek-smi ethernet-switch: port is DSA or CPU port
[  139.257162] phylink_phy_change:945: realtek-smi ethernet-switch swp2: phy link down /Unknown/Unknown
[  139.257203] phy_state_machine:1145: RTL8365MB-VC Gigabit Ethernet SMI-0:02: PHY state change UP -> NOLINK
[  143.225157] phylink_phy_change:945: realtek-smi ethernet-switch swp2: phy link up /1Gbps/Full
[  143.225158] phylink_mac_config:425: realtek-smi ethernet-switch swp2: phylink_mac_config: mode=phy//1Gbps/Full adv=0000000,00000000,00000000 pause=03 link=1 an=0
[  143.225181] phy_state_machine:1145: RTL8365MB-VC Gigabit Ethernet SMI-0:02: PHY state change NOLINK -> RUNNING
[  143.225199] realtek-smi ethernet-switch swp2: Link is Up - 1Gbps/Full - flow control rx/tx
[  143.225252] br0: port 3(swp2) entered blocking state
[  143.225267] br0: port 3(swp2) entered forwarding state
[  143.265881] br0: port 1(brwan0) entered blocking state
[  143.265908] br0: port 1(brwan0) entered forwarding state
[  143.461233] realtek-smi ethernet-switch: add VLAN 1 on port 2, untagged,  PVID
[  143.477285] realtek-smi ethernet-switch: add VLAN 1 on port 4, untagged, no PVID
[  143.477312] realtek-smi ethernet-switch: port is DSA or CPU port