All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <chao.yu@linux.dev>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent
Date: Thu, 5 Aug 2021 08:29:46 +0800	[thread overview]
Message-ID: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> (raw)
In-Reply-To: <YQsmfm3ibU6bhvZr@google.com>

Jaegeuk,

On 2021/8/5 7:45, Jaegeuk Kim wrote:
> Chao,
> 
> How about this?
> https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0

Looks more clean, thanks,

> 
> I'm digging one bug in __insert_extent_tree w/ the patch tho.

Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
__try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
w/ uninitialized c_len of @ei.

>> On 08/04, Chao Yu wrote:
>>> +	if (from_dnode)
>>> +		goto skip_reading_dnode;

Wrong condition here, thanks for fixing.

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao.yu@linux.dev>
Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent
Date: Thu, 5 Aug 2021 08:29:46 +0800	[thread overview]
Message-ID: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> (raw)
In-Reply-To: <YQsmfm3ibU6bhvZr@google.com>

Jaegeuk,

On 2021/8/5 7:45, Jaegeuk Kim wrote:
> Chao,
> 
> How about this?
> https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0

Looks more clean, thanks,

> 
> I'm digging one bug in __insert_extent_tree w/ the patch tho.

Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
__try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
w/ uninitialized c_len of @ei.

>> On 08/04, Chao Yu wrote:
>>> +	if (from_dnode)
>>> +		goto skip_reading_dnode;

Wrong condition here, thanks for fixing.

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-08-05  0:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  2:23 [RFC v3] f2fs: extent cache: support unaligned extent Chao Yu
2021-08-04  2:23 ` [f2fs-dev] " Chao Yu
2021-08-04  6:52 ` kernel test robot
2021-08-04  7:27   ` Chao Yu
2021-08-04  7:28 ` kernel test robot
2021-08-04 21:37 ` Jaegeuk Kim
2021-08-04 21:37   ` [f2fs-dev] " Jaegeuk Kim
2021-08-04 23:45   ` Jaegeuk Kim
2021-08-04 23:45     ` Jaegeuk Kim
2021-08-05  0:29     ` Chao Yu [this message]
2021-08-05  0:29       ` Chao Yu
2021-08-05  2:53       ` Jaegeuk Kim
2021-08-05  2:53         ` Jaegeuk Kim
2021-08-05  3:04         ` Chao Yu
2021-08-05  3:04           ` Chao Yu
2021-08-05  3:14           ` Chao Yu
2021-08-05  3:14             ` Chao Yu
2021-08-05 13:35     ` Chao Yu
2021-08-05 13:35       ` Chao Yu
2021-08-05 18:36       ` Jaegeuk Kim
2021-08-05 18:36         ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org \
    --to=chao@kernel.org \
    --cc=chao.yu@linux.dev \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.